On Thu, 23 Feb 2023 09:04:23 GMT, Justin Lu wrote:
> This PR converts Unicode sequences to UTF-8 native in .properties file.
> (Excluding the Unicode space and tab sequence). The conversion was done using
> native2ascii.
>
> In addition, the build logic is adjusted to support reading in the
>
> Please review this PR to use modern APIs and language features to simplify
> `equals` and `hashCode` in security area.
>
> I understand that security area is sensitive and a non-expert, such as
> myself, should tread carefully; so below are my notes to assist the review.
>
> * Unlike `hashCod
On Tue, 27 Jun 2023 15:06:45 GMT, Sean Coffey wrote:
>> New functionality in the -XshowSettings menu to display relevant information
>> about JDK security configuration
>
> Sean Coffey has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev exclu
> Please review this PR to use modern APIs and language features to simplify
> `equals` and `hashCode` in security area.
>
> I understand that security area is sensitive and a non-expert, such as
> myself, should tread carefully; so below are my notes to assist the review.
>
> * Unlike `hashCod
On Thu, 6 Jul 2023 17:06:31 GMT, Sean Mullan wrote:
>> src/java.base/share/classes/sun/security/x509/X500Name.java line 422:
>>
>>> 420: // quick check that number of RDNs and AVAs match before
>>> canonicalizing
>>> 421: if (!Arrays.equals(this.names, other.names,
>>> 422:
On Thu, 6 Jul 2023 16:55:12 GMT, Jonathan Gibbons wrote:
>> src/java.base/share/classes/java/security/cert/CertPath.java line 191:
>>
>>> 189:
>>> 190: /**
>>> 191: * {@return the hashcode value for this certification path} The
>>> hash code
>>
>> This looks a bit odd w/o a period at
On Wed, 5 Jul 2023 17:53:55 GMT, Roger Riggs wrote:
>> Pavel Rappo has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains six additional
>> commits sin
On Thu, 29 Jun 2023 08:27:43 GMT, Alan Bateman wrote:
> The changes make me wonder if `-XshowSetting:aardvark` should be an error
> rather than default to print all settings. Something we should look at again.
> Same thing for `-XshowSettings:system` on non-Linux, probably should have
> been a
On Wed, 5 Jul 2023 18:18:02 GMT, Roger Riggs wrote:
>> Pavel Rappo has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains six additional
>> commits sin
On Thu, 6 Jul 2023 16:41:37 GMT, Sean Mullan wrote:
>> Pavel Rappo has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains six additional
>> commits sin
On Wed, 5 Jul 2023 14:52:22 GMT, Pavel Rappo wrote:
>> Please review this PR to use modern APIs and language features to simplify
>> `equals` and `hashCode` in security area.
>>
>> I understand that security area is sensitive and a non-expert, such as
>> myself, should tread carefully; so belo
On Thu, 6 Jul 2023 16:25:05 GMT, Sean Mullan wrote:
>> Pavel Rappo has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains six additional
>> commits sin
On Wed, 5 Jul 2023 14:52:22 GMT, Pavel Rappo wrote:
>> Please review this PR to use modern APIs and language features to simplify
>> `equals` and `hashCode` in security area.
>>
>> I understand that security area is sensitive and a non-expert, such as
>> myself, should tread carefully; so belo
On Thu, 6 Jul 2023 15:52:00 GMT, Kevin Driver wrote:
>> JDK-8295068: an NPE is thrown when an invalid `id` is found to match up a
>> `ClientCertificateType`; rather than throwing the `NPE`, we now ignore an
>> `id` which does match a `ClientCertificateType`.
>
> Kevin Driver has updated the pul
> JDK-8295068: an NPE is thrown when an invalid `id` is found to match up a
> `ClientCertificateType`; rather than throwing the `NPE`, we now throw an
> `IllegalArgumentException`. This does not seem to be a scenario where
> recovery is possible or desired, so the `IAE` should be the proper beha
On Thu, 6 Jul 2023 07:05:46 GMT, Xue-Lei Andrew Fan wrote:
>> JDK-8295068: an NPE is thrown when an invalid `id` is found to match up a
>> `ClientCertificateType`; rather than throwing the `NPE`, we now throw an
>> `IllegalArgumentException`. This does not seem to be a scenario where
>> recove
On Tue, 27 Jun 2023 15:06:45 GMT, Sean Coffey wrote:
>> New functionality in the -XshowSettings menu to display relevant information
>> about JDK security configuration
>
> Sean Coffey has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev exclu
On Tue, 20 Jun 2023 16:44:28 GMT, Vladimir Ivanov wrote:
>> Thank you once more for the comments @iwanowww . I’ll address them asap.
>>
>> Can I ask what requirements are there for a product flag?
>
>> Can I ask what requirements are there for a product flag?
>
> Product flags are treated as p
> Can I please get reviews for this PR?
>
> The most common and frequent use of NonEscaping Phis merging object
> allocations is for debugging information. The two graphs below show numbers
> for Renaissance and DaCapo benchmarks - similar results are obtained for all
> other applications that
On Tue, 4 Jul 2023 19:05:58 GMT, Pavel Rappo wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [7b3c2dc5](https://github.com/openjdk/jdk/commit/7b3c2dc5f45afc3646ff5cdc0f6efd68e0b70ea5)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> The commit being
On Wed, 5 Jul 2023 20:25:26 GMT, Kevin Driver wrote:
> JDK-8295068: an NPE is thrown when an invalid `id` is found to match up a
> `ClientCertificateType`; rather than throwing the `NPE`, we now throw an
> `IllegalArgumentException`. This does not seem to be a scenario where
> recovery is poss
21 matches
Mail list logo
