Re: [jdk21] RFR: 8311122: Fix typos in java.base

2023-07-04 Thread Iris Clark
On Tue, 4 Jul 2023 19:05:58 GMT, Pavel Rappo wrote: > Hi all, > > This pull request contains a backport of commit > [7b3c2dc5](https://github.com/openjdk/jdk/commit/7b3c2dc5f45afc3646ff5cdc0f6efd68e0b70ea5) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being

Re: [jdk21] RFR: 8311122: Fix typos in java.base

2023-07-04 Thread Pavel Rappo
On Tue, 4 Jul 2023 19:05:58 GMT, Pavel Rappo wrote: > Hi all, > > This pull request contains a backport of commit > [7b3c2dc5](https://github.com/openjdk/jdk/commit/7b3c2dc5f45afc3646ff5cdc0f6efd68e0b70ea5) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being

[jdk21] RFR: 8311122: Fix typos in java.base

2023-07-04 Thread Pavel Rappo
Hi all, This pull request contains a backport of commit [7b3c2dc5](https://github.com/openjdk/jdk/commit/7b3c2dc5f45afc3646ff5cdc0f6efd68e0b70ea5) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Pavel Rappo on 4 Jul 2023 and was revie

Integrated: 8311122: Fix typos in java.base

2023-07-04 Thread Pavel Rappo
On Thu, 29 Jun 2023 21:17:49 GMT, Pavel Rappo wrote: > Please review this IDE-assisted typo hunt, which I plan to backport to jdk21. This pull request has now been integrated. Changeset: 7b3c2dc5 Author:Pavel Rappo URL: https://git.openjdk.org/jdk/commit/7b3c2dc5f45afc3646ff5cdc0f6e

Re: RFR: 8311122: Fix typos in java.base

2023-07-04 Thread Pavel Rappo
On Thu, 29 Jun 2023 21:17:49 GMT, Pavel Rappo wrote: > Please review this IDE-assisted typo hunt, which I plan to backport to jdk21. Alright, I think all the areas that this PR touches have been reviewed by area experts. - PR Comment: https://git.openjdk.org/jdk/pull/14718#issueco

Re: RFR: 8311170: Simplify and modernize equals and hashCode in security area [v3]

2023-07-04 Thread Pavel Rappo
> Please review this PR to use modern APIs and language features to simplify > `equals` and `hashCode` in security area. > > I understand that security area is sensitive and a non-expert, such as > myself, should tread carefully; so below are my notes to assist the review. > > * Unlike `hashCod

Re: RFR: JDK-8308398 Move SunEC crypto provider into java.base

2023-07-04 Thread Peter Firmstone
Thanks Anthony, Always interesting to see how others are managing modularity. Some time ago now (circa 2007), Sun released Jini as open source, set up a project at Apache called River, we struggled to get developers though, we had a big monolithic codebase and developers couldn't get their hea

[jdk21] Integrated: 8310549: avoid potential leaks in KeystoreImpl.m related to JNU_CHECK_EXCEPTION early returns

2023-07-04 Thread Matthias Baesken
On Fri, 30 Jun 2023 12:28:43 GMT, Matthias Baesken wrote: > 8310549: avoid potential leaks in KeystoreImpl.m related to > JNU_CHECK_EXCEPTION early returns This pull request has now been integrated. Changeset: 8d6ef6fd Author:Matthias Baesken URL: https://git.openjdk.org/jdk21/comm

Re: [jdk21] RFR: 8310549: avoid potential leaks in KeystoreImpl.m related to JNU_CHECK_EXCEPTION early returns

2023-07-04 Thread Christoph Langer
On Fri, 30 Jun 2023 12:28:43 GMT, Matthias Baesken wrote: > 8310549: avoid potential leaks in KeystoreImpl.m related to > JNU_CHECK_EXCEPTION early returns Marked as reviewed by clanger (Reviewer). - PR Review: https://git.openjdk.org/jdk21/pull/86#pullrequestreview-1512250194