Re: RFR: JDK-8308398 Move SunEC crypto provider into java.base [v3]

2023-07-03 Thread Valerie Peng
On Mon, 3 Jul 2023 17:51:10 GMT, Anthony Scarpino wrote: >> Hi, >> >> I need a code review for moving the contents of the jdk.crypto.ec module >> into java.base. This moves the SunEC JCE Provider (Elliptic Curve) into >> java.base. EC has always been separate from the base module/pkg because

Re: RFR: 8310901: Convert String::newStringNoRepl with Latin-1 to String::newStringLatin1NoRepl [v6]

2023-07-03 Thread Glavo
> Added a new method `newStringLatin1NoRepl` to the `JavaLangAccess`. > > Reasons: > > * Most use cases of `newStringNoRepl` use `ISO_8859_1` as the charset, > creating a new shortcut can make writing shorter; > * Since all possible values of `byte` are legal Latin-1 characters, > `newStringLat

Re: RFR: 8310901: Convert String::newStringNoRepl with Latin-1 to String::newStringLatin1NoRepl [v5]

2023-07-03 Thread Glavo
> Added a new method `newStringLatin1NoRepl` to the `JavaLangAccess`. > > Reasons: > > * Most use cases of `newStringNoRepl` use `ISO_8859_1` as the charset, > creating a new shortcut can make writing shorter; > * Since all possible values of `byte` are legal Latin-1 characters, > `newStringLat

Re: RFR: JDK-8308398 Move SunEC crypto provider into java.base [v3]

2023-07-03 Thread Anthony Scarpino
> Hi, > > I need a code review for moving the contents of the jdk.crypto.ec module into > java.base. This moves the SunEC JCE Provider (Elliptic Curve) into > java.base. EC has always been separate from the base module/pkg because of > its dependence on a native library. That library was rem

Re: [jdk21] RFR: 8301379: Verify TLS_ECDH_* cipher suites cannot be negotiated

2023-07-03 Thread Sean Mullan
On Tue, 27 Jun 2023 18:37:57 GMT, Rajan Halade wrote: > This test update should be included in JDK 21 LTS release. Marked as reviewed by mullan (Reviewer). - PR Review: https://git.openjdk.org/jdk21/pull/71#pullrequestreview-1511474824

Re: RFR: 8311122: Fix typos in java.base

2023-07-03 Thread Sean Mullan
On Thu, 29 Jun 2023 21:17:49 GMT, Pavel Rappo wrote: > Please review this IDE-assisted typo hunt, which I plan to backport to jdk21. The changes in the security classes look fine to me. - Marked as reviewed by mullan (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/14718#pu

Re: RFR: JDK-8308398 Move SunEC crypto provider into java.base

2023-07-03 Thread Anthony Scarpino
On 6/30/23 4:26 AM, Peter Firmstone wrote: On 17/06/2023 11:13 pm, Alan Bateman wrote: On Tue, 13 Jun 2023 20:36:28 GMT, Anthony Scarpino wrote: This moves the SunEC JCE Provider (Elliptic Curve) into java.base. EC has always been separate from the base module/pkg because of its depende