Re: RFR: 8311170: Simplify and modernize equals and hashCode in security area [v2]

2023-06-30 Thread Pavel Rappo
> Please review this PR to use modern APIs and language features to simplify > `equals` and `hashCode` in security area. > > I understand that security area is sensitive and a non-expert, such as > myself, should tread carefully; so below are my notes to assist the review. > > * Unlike `hashCod

RFR: 8311170: Simplify and modernize equals and hashCode in security area

2023-06-30 Thread Pavel Rappo
Please review this PR to use modern APIs and language features to simplify `equals` and `hashCode` in security area. I understand that security area is sensitive and a non-expert, such as myself, should tread carefully; so below are my notes to assist the review. * Unlike `hashCode`, non-secure

Re: RFR: 8311043: Remove trailing blank lines in source files

2023-06-30 Thread Daniel D . Daugherty
On Wed, 28 Jun 2023 16:54:51 GMT, Leo Korinth wrote: > Remove trailing "blank" lines in source files. > > I like to use global-whitespace-cleanup-mode, but I can not use it if the > files are "dirty" to begin with. This fix will make more files "clean". I > also considered adding a check for t

[jdk21] RFR: 8310549: avoid potential leaks in KeystoreImpl.m related to JNU_CHECK_EXCEPTION early returns

2023-06-30 Thread Matthias Baesken
8310549: avoid potential leaks in KeystoreImpl.m related to JNU_CHECK_EXCEPTION early returns - Commit messages: - Backport 7da3f1999fc5d1b9162443d97dfae7fe7b04dfc5 Changes: https://git.openjdk.org/jdk21/pull/86/files Webrev: https://webrevs.openjdk.org/?repo=jdk21&pr=86&range=00

Re: RFR: JDK-8308398 Move SunEC crypto provider into java.base

2023-06-30 Thread Peter Firmstone
On 17/06/2023 11:13 pm, Alan Bateman wrote: On Tue, 13 Jun 2023 20:36:28 GMT, Anthony Scarpino wrote: This moves the SunEC JCE Provider (Elliptic Curve) into java.base. EC has always been separate from the base module/pkg because of its dependence on a native library. That library was rem