[jdk21] Integrated: 8309740: Expand timeout windows for tests in JDK-8179502

2023-06-23 Thread Jamil Nimeh
On Fri, 23 Jun 2023 14:55:45 GMT, Jamil Nimeh wrote: > This is a backport of the test fixes comprising JDK-8309740. This pull request has now been integrated. Changeset: 17b6f7b9 Author:Jamil Nimeh URL: https://git.openjdk.org/jdk21/commit/17b6f7b9a5a14a869d3f1efd0ab51fea4fa40c83 St

Re: RFR: JDK-8287061: Support for rematerializing scalar replaced objects participating in allocation merges [v18]

2023-06-23 Thread Vladimir Ivanov
On Fri, 23 Jun 2023 15:00:15 GMT, Cesar Soares Lucas wrote: >> src/hotspot/share/opto/c2_globals.hpp line 473: >> >>> 471: " register allocation.") >>> \ >>> 472: >>>

Re: [jdk21] RFR: 8309740: Expand timeout windows for tests in JDK-8179502

2023-06-23 Thread Weijun Wang
On Fri, 23 Jun 2023 18:35:25 GMT, Xue-Lei Andrew Fan wrote: > Looks good to me. I was just wondering, if the /backport tag could work from > the original PR for backporting. It looks Jamil did use the `/backport` command from the original commit. Or are you wondering why a review is still need

Re: [jdk21] RFR: 8309740: Expand timeout windows for tests in JDK-8179502

2023-06-23 Thread Hai-May Chao
On Fri, 23 Jun 2023 14:55:45 GMT, Jamil Nimeh wrote: > This is a backport of the test fixes comprising JDK-8309740. Marked as reviewed by hchao (Committer). - PR Review: https://git.openjdk.org/jdk21/pull/58#pullrequestreview-1495731841

Re: [jdk21] RFR: 8309740: Expand timeout windows for tests in JDK-8179502

2023-06-23 Thread Xue-Lei Andrew Fan
On Fri, 23 Jun 2023 14:55:45 GMT, Jamil Nimeh wrote: > This is a backport of the test fixes comprising JDK-8309740. Looks good to me. I was just wondering, if the /backport tag could work from the original PR for backporting. - Marked as reviewed by xuelei (Reviewer). PR Review:

Integrated: 8279254: PKCS9Attribute SigningTime always encoded in UTFTime

2023-06-23 Thread Ben Perez
On Thu, 22 Jun 2023 18:45:14 GMT, Ben Perez wrote: > Added single-argument `putTime` method to `DerOutputStream` that selects the > correct encoding based on the `Date` value. Similarly, a `getTime` method was > added to `DerValue` to automatically call the correct decoding function based > on

Re: RFR: 8279254: PKCS9Attribute SigningTime always encoded in UTFTime [v4]

2023-06-23 Thread Jamil Nimeh
On Fri, 23 Jun 2023 15:20:24 GMT, Ben Perez wrote: >> Added single-argument `putTime` method to `DerOutputStream` that selects the >> correct encoding based on the `Date` value. Similarly, a `getTime` method >> was added to `DerValue` to automatically call the correct decoding function >> base

Re: RFR: 8279254: PKCS9Attribute SigningTime always encoded in UTFTime [v4]

2023-06-23 Thread Ben Perez
> Added single-argument `putTime` method to `DerOutputStream` that selects the > correct encoding based on the `Date` value. Similarly, a `getTime` method was > added to `DerValue` to automatically call the correct decoding function based > on the date type specified by the `tag`. Furthermore, t

Re: RFR: JDK-8287061: Support for rematerializing scalar replaced objects participating in allocation merges [v18]

2023-06-23 Thread Cesar Soares Lucas
On Wed, 14 Jun 2023 20:19:58 GMT, Vladimir Ivanov wrote: >> Cesar Soares Lucas has updated the pull request with a new target base due >> to a merge or a rebase. The pull request now contains 19 commits: >> >> - Merge branch 'openjdk:master' into rematerialization-of-merges >> - Rome minor re

[jdk21] RFR: 8309740: Expand timeout windows for tests in JDK-8179502

2023-06-23 Thread Jamil Nimeh
This is a backport of the test fixes comprising JDK-8309740. - Commit messages: - Backport 5ca4cdd2caceba9dad8025e5a8851740a3961921 Changes: https://git.openjdk.org/jdk21/pull/58/files Webrev: https://webrevs.openjdk.org/?repo=jdk21&pr=58&range=00 Issue: https://bugs.openjdk.org/

Re: RFR: 8309740: Expand timeout windows for tests in JDK-8179502

2023-06-23 Thread Jamil Nimeh
On Fri, 16 Jun 2023 18:42:32 GMT, Xue-Lei Andrew Fan wrote: >> This PR is for tests that were modified/added in JDK-8179502. The timeout >> windows for those tests were a little too short on some test systems, >> especially when the system is under heavy load. After a few iterations >> tryin

Integrated: 8309740: Expand timeout windows for tests in JDK-8179502

2023-06-23 Thread Jamil Nimeh
On Fri, 16 Jun 2023 18:19:45 GMT, Jamil Nimeh wrote: > This PR is for tests that were modified/added in JDK-8179502. The timeout > windows for those tests were a little too short on some test systems, > especially when the system is under heavy load. After a few iterations > trying out vario

Re: RFR: 8309740: Expand timeout windows for tests in JDK-8179502

2023-06-23 Thread Matthias Baesken
On Fri, 16 Jun 2023 18:19:45 GMT, Jamil Nimeh wrote: > This PR is for tests that were modified/added in JDK-8179502. The timeout > windows for those tests were a little too short on some test systems, > especially when the system is under heavy load. After a few iterations > trying out vario

[jdk21] Integrated: 8304885: Reuse stale data to improve DNS resolver resiliency

2023-06-23 Thread Sergey Bylokhov
On Wed, 21 Jun 2023 14:50:21 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit > [bdd81b31](https://github.com/openjdk/jdk/commit/bdd81b31825a9eb6a0f0883fca56a011ac2aebf8) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit

Re: [External] : Re: PrivilegedAction et al and JEP411

2023-06-23 Thread Ron Pressler
> On 23 Jun 2023, at 08:16, Peter Firmstone wrote: > > > When someone comes up with a simpler design, I'm all up for the effectiveness > challenge, I'm pretty sure that whatever it is, we'll blow it away both on > performance and effectiveness, we've had years to perfect it, but I would > a

Re: [jdk21] RFR: 8304885: Reuse stale data to improve DNS resolver resiliency

2023-06-23 Thread Michael McMahon
On Wed, 21 Jun 2023 14:50:21 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit > [bdd81b31](https://github.com/openjdk/jdk/commit/bdd81b31825a9eb6a0f0883fca56a011ac2aebf8) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit

Re: RFR: 8308286 Fix clang warnings in linux code [v8]

2023-06-23 Thread Daniel Jeliński
On Fri, 23 Jun 2023 08:03:45 GMT, Artem Semenov wrote: >> When using the clang compiler to build OpenJDk on Linux, we encounter >> various "warnings as errors". >> They can be fixed with small changes. > > Artem Semenov has updated the pull request incrementally with one additional > commit sin

Re: RFR: 8308286 Fix clang warnings in linux code [v8]

2023-06-23 Thread Artem Semenov
> When using the clang compiler to build OpenJDk on Linux, we encounter various > "warnings as errors". > They can be fixed with small changes. Artem Semenov has updated the pull request incrementally with one additional commit since the last revision: update - Changes: - all:

Re: RFR: 8308286 Fix clang warnings in linux code [v6]

2023-06-23 Thread Artem Semenov
On Fri, 23 Jun 2023 06:19:31 GMT, Daniel Jeliński wrote: >> make/modules/java.desktop/lib/Awt2dLibraries.gmk line 241: >> >>> 239: DISABLED_WARNINGS_gcc_OGLPaints.c := >>> format-nonliteral, \ >>> 240: DISABLED_WARNINGS_gcc_sun_awt_X11_GtkFileDialogPeer.c >>> :=

Re: RFR: 8279254: PKCS9Attribute SigningTime always encoded in UTFTime [v3]

2023-06-23 Thread Jamil Nimeh
On Thu, 22 Jun 2023 23:22:14 GMT, Ben Perez wrote: >> Added single-argument `putTime` method to `DerOutputStream` that selects the >> correct encoding based on the `Date` value. Similarly, a `getTime` method >> was added to `DerValue` to automatically call the correct decoding function >> base

Re: [External] : Re: PrivilegedAction et al and JEP411

2023-06-23 Thread Peter Firmstone
On 23/06/2023 11:06 am, Ron Pressler wrote: On 22 Jun 2023, at 23:50, Peter Firmstone wrote: If you are able to share, I'd be interested to learn about challenges you had with SM, if we one day have the opportunity to reimplement it, the lessons might be valuable, so we can avoid the sam