On Fri, 16 Jun 2023 12:14:49 GMT, Sean Coffey wrote:
>> New functionality in the -XshowSettings menu to display relevant information
>> about JDK security configuration
>
> Sean Coffey has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Pass P
On Wed, 14 Jun 2023 19:29:45 GMT, Cesar Soares Lucas
wrote:
>> Can I please get reviews for this PR?
>>
>> The most common and frequent use of NonEscaping Phis merging object
>> allocations is for debugging information. The two graphs below show numbers
>> for Renaissance and DaCapo benchmar
On Mon, 12 Jun 2023 21:21:05 GMT, Justin Lu wrote:
> Please review this PR which updates the JDK's localized resources since the
> previous L10n translation drop (1/26).
>
> To help with reviewing the changes, @jonathan-gibbons created a tool which
> displays the localized changes next to the
On Fri, 16 Jun 2023 04:39:42 GMT, Justin Lu wrote:
>> Please review this PR which updates the JDK's localized resources since the
>> previous L10n translation drop (1/26).
>>
>> To help with reviewing the changes, @jonathan-gibbons created a tool which
>> displays the localized changes next to
On Tue, 13 Jun 2023 20:36:28 GMT, Anthony Scarpino
wrote:
> Hi,
>
> I need a code review for moving the contents of the jdk.crypto.ec module into
> java.base. This moves the SunEC JCE Provider (Elliptic Curve) into
> java.base. EC has always been separate from the base module/pkg because of
Hi,
I need a code review for moving the contents of the jdk.crypto.ec module into
java.base. This moves the SunEC JCE Provider (Elliptic Curve) into java.base.
EC has always been separate from the base module/pkg because of its dependence
on a native library. That library was removed in JDK
On Fri, 16 Jun 2023 18:19:45 GMT, Jamil Nimeh wrote:
> This PR is for tests that were modified/added in JDK-8179502. The timeout
> windows for those tests were a little too short on some test systems,
> especially when the system is under heavy load. After a few iterations
> trying out vario
This PR is for tests that were modified/added in JDK-8179502. The timeout
windows for those tests were a little too short on some test systems,
especially when the system is under heavy load. After a few iterations trying
out various longer time windows I have a set that should not run into is
On Fri, 16 Jun 2023 01:21:57 GMT, Weijun Wang wrote:
> The `attributes` field inside the `PKCS12KeyStore.Entry` class might be
> modified and retrieved at the same time. Make it concurrent.
>
> The test uses some reflection to get this field and try updating it in
> multiple threads.
This pul
On Fri, 16 Jun 2023 12:52:00 GMT, Weijun Wang wrote:
>> The `attributes` field inside the `PKCS12KeyStore.Entry` class might be
>> modified and retrieved at the same time. Make it concurrent.
>>
>> The test uses some reflection to get this field and try updating it in
>> multiple threads.
>
>
See also https://bugs.openjdk.org/browse/JDK-8296244
--Sean
On 6/16/23 1:48 AM, Alan Bateman wrote:
On 16/06/2023 03:48, Peter Firmstone wrote:
:
As it isn't yet clear how a Subject context will be preserved across
threads in future version of OpenJDK, (currently we use the
AccessControlConte
On Fri, 16 Jun 2023 15:06:30 GMT, Jonathan Gibbons wrote:
>> Left some comments on the translations mainly in Japanese. It is now very
>> easy to look at the l10n changes in the generated HTML. One small comment to
>> the tool is that it would be nice if the order in HTML (alphabetically
>> so
On Mon, 12 Jun 2023 18:49:59 GMT, Ben Perez wrote:
> Changed `getEncoded` for both EC and RSA to return a copy of the internal key
> array to avoid mutability issues.
This pull request has now been integrated.
Changeset: 4eb4f20a
Author:Ben Perez
Committer: Sean Mullan
URL:
https:
On Fri, 16 Jun 2023 12:14:49 GMT, Sean Coffey wrote:
>> New functionality in the -XshowSettings menu to display relevant information
>> about JDK security configuration
>
> Sean Coffey has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Pass P
On Tue, 13 Jun 2023 18:38:28 GMT, Naoto Sato wrote:
> Left some comments on the translations mainly in Japanese. It is now very
> easy to look at the l10n changes in the generated HTML. One small comment to
> the tool is that it would be nice if the order in HTML (alphabetically sorted
> curre
On Fri, 16 Jun 2023 14:52:44 GMT, Xue-Lei Andrew Fan wrote:
>> There is a difference, though. The close() method in SSLSocketImpl is not
>> synchronized and there is the chance of a NullPointerException in
>> duplexCloseOutput() because `conContext.handshakeContext` is being set to
>> null by
On Fri, 16 Jun 2023 14:45:52 GMT, Matthew Donovan wrote:
>> I may update both SSLSocketImpl and SSLEngineImpl, as SSLSocketImpl uses the
>> locks similar to SSLEngineImpl.
>
> There is a difference, though. The close() method in SSLSocketImpl is not
> synchronized and there is the chance of a N
On Fri, 16 Jun 2023 14:30:33 GMT, Xue-Lei Andrew Fan wrote:
>> I see what you're saying with respect to SSLEngineImpl. It looks like all of
>> the public methods are synchronized with `engineLock` so I shouldn't have
>> made any changes there. I will revert them.
>>
>> Are you ok with the chan
On Fri, 16 Jun 2023 14:24:17 GMT, Matthew Donovan wrote:
>> I had a search of the value assignment of handshakeSession. Here is one
>> example of the calling stack:
>> SSLEngineImpl.DelegatedTask.run()->TransportContext.dispatch()->SSLHandshake().consume()->HandshakeConsumer.consume()->SSLExten
On Fri, 16 Jun 2023 13:54:37 GMT, Xue-Lei Andrew Fan wrote:
>> `engineLock` was used to here to make sure that
>> `conContext.handshakeContext` is not null before accessing it. The problem
>> is that the `handshakeContext` is modified (set to null) by the
>> `TransportContext` class. So using
On Fri, 16 Jun 2023 12:45:58 GMT, Weijun Wang wrote:
>> src/java.base/share/classes/sun/security/pkcs12/PKCS12KeyStore.java line
>> 1438:
>>
>>> 1436:
>>> 1437: if (entry.attributes == null) {
>>> 1438: entry.attributes = ConcurrentHashMap.newKeySet();
>>
>> It seems that
On Fri, 16 Jun 2023 11:59:01 GMT, Matthew Donovan wrote:
>> src/java.base/share/classes/sun/security/ssl/SSLEngineImpl.java line 914:
>>
>>> 912: @Override
>>> 913: public SSLSession getHandshakeSession() {
>>> 914: engineLock.lock();
>>
>> I'm not very sure of this update. By r
On Fri, 16 Jun 2023 09:25:30 GMT, Daniel Fuchs wrote:
>> Weijun Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> more cases to cover
>
> src/java.base/share/classes/sun/security/pkcs12/PKCS12KeyStore.java line 1438:
>
>> 1436:
>> 1
On Fri, 16 Jun 2023 09:53:10 GMT, Daniel Jeliński wrote:
>> Weijun Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> more cases to cover
>
> src/java.base/share/classes/sun/security/pkcs12/PKCS12KeyStore.java line 1:
>
>> 1: /*
>
>
> The `attributes` field inside the `PKCS12KeyStore.Entry` class might be
> modified and retrieved at the same time. Make it concurrent.
>
> The test uses some reflection to get this field and try updating it in
> multiple threads.
Weijun Wang has updated the pull request incrementally with one
> The `attributes` field inside the `PKCS12KeyStore.Entry` class might be
> modified and retrieved at the same time. Make it concurrent.
>
> The test uses some reflection to get this field and try updating it in
> multiple threads.
Weijun Wang has updated the pull request incrementally with one
> New functionality in the -XshowSettings menu to display relevant information
> about JDK security configuration
Sean Coffey has updated the pull request incrementally with one additional
commit since the last revision:
Pass PrintStream to security helper
-
Changes:
- all: ht
On Fri, 16 Jun 2023 06:24:36 GMT, Xue-Lei Andrew Fan wrote:
>> Matthew Donovan has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains five additional
>
> In this PR, I added methods to the TransportContext class to synchronize
> access to the handshakeContext field. I also updated locations in the code
> that rely on the handshakeContext field to not be null to use the
> synchronized methods.
>
> Thanks
Matthew Donovan has updated the pull re
On Fri, 16 Jun 2023 11:09:23 GMT, Sean Coffey wrote:
> Logged https://bugs.openjdk.org/browse/JDK-8310201 to track the Locale
> changes Alan.
Thanks, probably should treat this as a bug for JDK 21 so that a new addition
doesn't change behavior between 21 and 22.
-
PR Review Comme
On Fri, 16 Jun 2023 11:14:38 GMT, Sean Coffey wrote:
>> New functionality in the -XshowSettings menu to display relevant information
>> about JDK security configuration
>
> Sean Coffey has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Refa
On Wed, 14 Jun 2023 11:39:14 GMT, Sean Coffey wrote:
>> New functionality in the -XshowSettings menu to display relevant information
>> about JDK security configuration
>
> Sean Coffey has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Incorp
On Wed, 14 Jun 2023 12:46:36 GMT, Weijun Wang wrote:
>> Sean Coffey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Incorporate review comments from Roger and tweak some code
>
> src/java.base/share/classes/sun/launcher/LauncherHelper.ja
On Wed, 14 Jun 2023 14:06:33 GMT, Sean Mullan wrote:
>> src/java.base/share/classes/sun/launcher/LauncherHelper.java line 424:
>>
>>> 422:if (!services.isEmpty()) {
>>> 423:services.stream()
>>> 424:
>>> .sorted(Comparator.comparing
On Thu, 15 Jun 2023 06:32:06 GMT, Alan Bateman wrote:
>> src/java.base/share/classes/sun/launcher/LauncherHelper.java line 183:
>>
>>> 181: case "locale":
>>> 182: printLocale();
>>> 183: break;
>>
>> printLocale might need the same treatment to avoid
> New functionality in the -XshowSettings menu to display relevant information
> about JDK security configuration
Sean Coffey has updated the pull request incrementally with two additional
commits since the last revision:
- Refactor out security code to helper class
- Print aliases. Order Pro
On Fri, 16 Jun 2023 01:21:57 GMT, Weijun Wang wrote:
> The `attributes` field inside the `PKCS12KeyStore.Entry` class might be
> modified and retrieved at the same time. Make it concurrent.
>
> The test uses some reflection to get this field and try updating it in
> multiple threads.
Would it
On Fri, 16 Jun 2023 01:21:57 GMT, Weijun Wang wrote:
> The `attributes` field inside the `PKCS12KeyStore.Entry` class might be
> modified and retrieved at the same time. Make it concurrent.
>
> The test uses some reflection to get this field and try updating it in
> multiple threads.
src/java
Thanks Alan,
That's quite interesting. Often we use Executor tasks to perform event
notifications to listeners, context is the same across many, in fact we
do this for distributed garbage collection over TLS connections too.
--
Regards,
Peter
On 16/06/2023 3:48 pm, Alan Bateman wrote:
39 matches
Mail list logo
