Re: RFR: 8304478: Initial nroff manpage generation for JDK 22

2023-06-13 Thread David Holmes
On Wed, 14 Jun 2023 06:08:59 GMT, Alan Bateman wrote: >> Updated the version to 22-ea and year to 2024. >> >> The following unpublished changes will also be included in this update: >> - [JDK-8290626](https://bugs.openjdk.org/browse/JDK-8290626): keytool >> manpage contains a special character

Re: RFR: 8304478: Initial nroff manpage generation for JDK 22

2023-06-13 Thread Alan Bateman
On Wed, 14 Jun 2023 04:53:58 GMT, David Holmes wrote: > Updated the version to 22-ea and year to 2024. > > The following unpublished changes will also be included in this update: > - [JDK-8290626](https://bugs.openjdk.org/browse/JDK-8290626): keytool manpage > contains a special character > - [

RFR: 8304478: Initial nroff manpage generation for JDK 22

2023-06-13 Thread David Holmes
Updated the version to 22-ea and year to 2024. The following unpublished changes will also be included in this update: - [JDK-8290626](https://bugs.openjdk.org/browse/JDK-8290626): keytool manpage contains a special character - [JDK-8303928](https://bugs.openjdk.org/browse/JDK-8303928): Update ja

Re: RFR: 8309632: JDK 21 RDP1 L10n resource files update [v4]

2023-06-13 Thread Naoto Sato
On Tue, 13 Jun 2023 22:09:40 GMT, Justin Lu wrote: >> Please review this PR which updates the JDK's localized resources since the >> previous L10n translation drop (1/26). >> >> To help with reviewing the changes, @jonathan-gibbons created a tool which >> displays the localized changes next to

Re: RFR: 8309632: JDK 21 RDP1 L10n resource files update [v2]

2023-06-13 Thread Justin Lu
On Tue, 13 Jun 2023 20:56:31 GMT, Weijun Wang wrote: >> Justin Lu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Revert 'main.help.opt.any.file' value for _de > > Some comments: > > - `src/java.base/share/classes/sun/launcher/resources

Re: RFR: 8309632: JDK 21 RDP1 L10n resource files update [v4]

2023-06-13 Thread Justin Lu
> Please review this PR which updates the JDK's localized resources since the > previous L10n translation drop (1/26). > > To help with reviewing the changes, @jonathan-gibbons created a tool which > displays the localized changes next to the original file's changes in UTF-8 > native. Those fil

Re: RFR: 8309632: JDK 21 RDP1 L10n resource files update [v2]

2023-06-13 Thread Justin Lu
On Tue, 13 Jun 2023 19:59:28 GMT, Naoto Sato wrote: >> Justin Lu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Revert 'main.help.opt.any.file' value for _de > > src/java.desktop/macosx/classes/com/apple/laf/resources/aqua_ja.properties

Re: RFR: 8309632: JDK 21 RDP1 L10n resource files update [v3]

2023-06-13 Thread Justin Lu
> Please review this PR which updates the JDK's localized resources since the > previous L10n translation drop (1/26). > > To help with reviewing the changes, @jonathan-gibbons created a tool which > displays the localized changes next to the original file's changes in UTF-8 > native. Those fil

Re: RFR: 8309632: JDK 21 RDP1 L10n resource files update [v2]

2023-06-13 Thread Weijun Wang
On Mon, 12 Jun 2023 22:32:14 GMT, Justin Lu wrote: >> Please review this PR which updates the JDK's localized resources since the >> previous L10n translation drop (1/26). >> >> To help with reviewing the changes, @jonathan-gibbons created a tool which >> displays the localized changes next to

Re: RFR: 8309632: JDK 21 RDP1 L10n resource files update [v2]

2023-06-13 Thread Naoto Sato
On Mon, 12 Jun 2023 22:32:14 GMT, Justin Lu wrote: >> Please review this PR which updates the JDK's localized resources since the >> previous L10n translation drop (1/26). >> >> To help with reviewing the changes, @jonathan-gibbons created a tool which >> displays the localized changes next to

Re: RFR: 8309632: JDK 21 RDP1 L10n resource files update [v2]

2023-06-13 Thread Justin Lu
On Tue, 13 Jun 2023 18:13:12 GMT, Naoto Sato wrote: >> Justin Lu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Revert 'main.help.opt.any.file' value for _de > > src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler_de.p

Re: RFR: 8309632: JDK 21 RDP1 L10n resource files update [v2]

2023-06-13 Thread Naoto Sato
On Mon, 12 Jun 2023 22:32:14 GMT, Justin Lu wrote: >> Please review this PR which updates the JDK's localized resources since the >> previous L10n translation drop (1/26). >> >> To help with reviewing the changes, @jonathan-gibbons created a tool which >> displays the localized changes next to

Re: RFR: JDK-8287061: Support for rematerializing scalar replaced objects participating in allocation merges [v17]

2023-06-13 Thread Cesar Soares Lucas
On Fri, 9 Jun 2023 17:23:22 GMT, Vladimir Ivanov wrote: >> Cesar Soares Lucas has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Rome minor refactorings. > > Overall, I like how this patch shapes. > > I need to go through share/opto chang

Integrated: 8308474: DSA does not reset SecureRandom when initSign is called again

2023-06-13 Thread Ben Perez
On Thu, 1 Jun 2023 21:17:11 GMT, Ben Perez wrote: > Fixed `engineInitSign` in `DSA.java` and added `SecureRandomReset.java` to > DSA tests This pull request has now been integrated. Changeset: bed9161c Author:Ben Perez Committer: Weijun Wang URL: https://git.openjdk.org/jdk/commit

Re: RFR: 8281658: Add a security category to the java -XshowSettings option [v2]

2023-06-13 Thread Roger Riggs
On Tue, 13 Jun 2023 13:57:13 GMT, Sean Coffey wrote: >> New functionality in the -XshowSettings menu to display relevant information >> about JDK security configuration > > Sean Coffey has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev exclu

Re: RFR: 8309305: sun/security/ssl/SSLSocketImpl/BlockedAsyncClose.java fails with jtreg test timeout [v2]

2023-06-13 Thread Matthew Donovan
> This PR improves the reliability of the BlockedAsyncClose test by addressing > an edge case/race condition between the two test threads. The purpose of the > test is to verify that an SSLSocket can be closed if a thread is blocked in a > write operation. > > The test starts a "write" thread

Re: RFR: 8309305: sun/security/ssl/SSLSocketImpl/BlockedAsyncClose.java fails with jtreg test timeout

2023-06-13 Thread Andrey Turbanov
On Thu, 8 Jun 2023 14:25:26 GMT, Matthew Donovan wrote: > This PR improves the reliability of the BlockedAsyncClose test by addressing > an edge case/race condition between the two test threads. The purpose of the > test is to verify that an SSLSocket can be closed if a thread is blocked in a

Re: RFR: 8281658: Add a security category to the java -XshowSettings option

2023-06-13 Thread Sean Coffey
On Fri, 9 Jun 2023 13:54:14 GMT, Sean Coffey wrote: > New functionality in the -XshowSettings menu to display relevant information > about JDK security configuration Thanks for the feedback to date. I've pushed new changes to reflect requested changes. I've changed the default` -XshowSettings

Re: RFR: 8281658: Add a security category to the java -XshowSettings option [v2]

2023-06-13 Thread Sean Coffey
> New functionality in the -XshowSettings menu to display relevant information > about JDK security configuration Sean Coffey has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The

Re: RFR: 8281658: Add a security category to the java -XshowSettings option

2023-06-13 Thread Andrey Turbanov
On Fri, 9 Jun 2023 13:54:14 GMT, Sean Coffey wrote: > New functionality in the -XshowSettings menu to display relevant information > about JDK security configuration src/java.base/share/classes/sun/launcher/LauncherHelper.java line 330: > 328: if (arg.toLowerCase(Locale.ROOT).equals("p

Re: RFR: 8301379: Verify TLS_ECDH_* cipher suites cannot be negotiated [v3]

2023-06-13 Thread Matthew Donovan
> This PR implements a test to verify that Java will not negotiate TLS > connections when one side of the connection requests disabled cipher suites. Matthew Donovan has updated the pull request incrementally with one additional commit since the last revision: added all disabled ciphers

Re: RFR: 8301379: Verify TLS_ECDH_* cipher suites cannot be negotiated [v3]

2023-06-13 Thread Matthew Donovan
On Fri, 9 Jun 2023 17:25:52 GMT, Sean Mullan wrote: >> Matthew Donovan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> added all disabled ciphers > > test/jdk/javax/net/ssl/TLS/TLSWontNegotiateDisabledCipherAlgos.java line 35: > >> 33: