On Mon, 12 Jun 2023 22:17:25 GMT, Eirik Bjorsnos wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Revert 'main.help.opt.any.file' value for _de
>
> src/jdk.jartool/share/classes/sun/tools/jar/resources/jar_de.propertie
> Please review this PR which updates the JDK's localized resources since the
> previous L10n translation drop (1/26).
>
> To help with reviewing the changes, @jonathan-gibbons created a tool which
> displays the localized changes next to the original file's changes in UTF-8
> native. Those fil
On Mon, 12 Jun 2023 22:00:01 GMT, Justin Lu wrote:
> Please review this PR which updates the JDK's localized resources since the
> previous L10n translation drop (1/26).
>
> To help with reviewing the changes, @jonathan-gibbons created a tool which
> displays the localized changes next to the
On Mon, 12 Jun 2023 22:00:01 GMT, Justin Lu wrote:
> Please review this PR which updates the JDK's localized resources since the
> previous L10n translation drop (1/26).
>
> To help with reviewing the changes, @jonathan-gibbons created a tool which
> displays the localized changes next to the
Please review this PR which updates the JDK's localized resources since the
previous L10n translation drop (1/26).
To help with reviewing the changes, @jonathan-gibbons created a tool which
displays the localized changes next to the original file's changes in UTF-8
native. Those files can be vi
On Mon, 12 Jun 2023 21:42:24 GMT, Kevin Rushforth wrote:
>> @prrace @jonathan-gibbons @pavelrappo @lahodaj @wangweij @igraves
>> @AlanBateman @eirbjo could you please review the modules / changes you are
>> familiar with, thank you.
>
> @justin-curtis-lu Unless there is a strong reason to do ot
On Mon, 12 Jun 2023 21:27:05 GMT, Justin Lu wrote:
>> Please review this PR which updates the JDK's localized resources since the
>> previous L10n translation drop (1/26).
>>
>> To help with reviewing the changes, @jonathan-gibbons created a tool which
>> displays the localized changes next to
On Mon, 12 Jun 2023 21:21:05 GMT, Justin Lu wrote:
> Please review this PR which updates the JDK's localized resources since the
> previous L10n translation drop (1/26).
>
> To help with reviewing the changes, @jonathan-gibbons created a tool which
> displays the localized changes next to the
On Mon, 12 Jun 2023 21:21:05 GMT, Justin Lu wrote:
> Please review this PR which updates the JDK's localized resources since the
> previous L10n translation drop (1/26).
>
> To help with reviewing the changes, @jonathan-gibbons created a tool which
> displays the localized changes next to the
Please review this PR which updates the JDK's localized resources since the
previous L10n translation drop (1/26).
To help with reviewing the changes, @jonathan-gibbons created a tool which
displays the localized changes next to the original file's changes in UTF-8
native. Those files can be vi
On Mon, 12 Jun 2023 16:39:33 GMT, Xue-Lei Andrew Fan wrote:
> Hi,
>
> May I get this simple update reviewed?
>
> The class field RSAPadding.md can be converted to a local variable of the
> constructor, and save the class footprint.
>
> Thanks,
> Xuelei
This pull request has now been integrat
On Thu, 25 May 2023 21:17:40 GMT, Ben Perez wrote:
> Changed `namedParams` in XECParameters and EdDSAParameters to be `private
> final`
This pull request has now been integrated.
Changeset: 3c15ad8d
Author:Ben Perez
Committer: Sean Mullan
URL:
https://git.openjdk.org/jdk/commit/3c
On Mon, 12 Jun 2023 16:39:33 GMT, Xue-Lei Andrew Fan wrote:
> Hi,
>
> May I get this simple update reviewed?
>
> The class field RSAPadding.md can be converted to a local variable of the
> constructor, and save the class footprint.
>
> Thanks,
> Xuelei
Marked as reviewed by valeriep (Reviewe
Changed `getEncoded` for both EC and RSA to return a copy of the internal key
array to avoid mutability issues.
-
Commit messages:
- updated copywrite
- Fixed getEncoded for CRSAPublicKey
- Fixed imports and formatting
- Modify getEncoded to return copy of encoding. Added test.
On Thu, 25 May 2023 21:17:40 GMT, Ben Perez wrote:
> Changed `namedParams` in XECParameters and EdDSAParameters to be `private
> final`
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.org/jdk/pull/14162
This fix converted shell test to java code. Following are the updates done to
the original shell test logic:
- Test is updated to be a manual test as it is rather difficult/impossible to
have it run in virtualized environment where we can't update the security
keychain search list to include cr
On Mon, 12 Jun 2023 17:53:42 GMT, Hai-May Chao wrote:
>> Hi,
>>
>> May I get this simple update reviewed?
>>
>> The class field RSAPadding.md can be converted to a local variable of the
>> constructor, and save the class footprint.
>>
>> Thanks,
>> Xuelei
>
> LGTM
Thank you @haimaychao and @
On Mon, 12 Jun 2023 16:39:33 GMT, Xue-Lei Andrew Fan wrote:
> Hi,
>
> May I get this simple update reviewed?
>
> The class field RSAPadding.md can be converted to a local variable of the
> constructor, and save the class footprint.
>
> Thanks,
> Xuelei
Looks good. I'd be more inclined to cal
On Mon, 12 Jun 2023 16:39:33 GMT, Xue-Lei Andrew Fan wrote:
> Hi,
>
> May I get this simple update reviewed?
>
> The class field RSAPadding.md can be converted to a local variable of the
> constructor, and save the class footprint.
>
> Thanks,
> Xuelei
Marked as reviewed by weijun (Reviewer)
On Thu, 10 Nov 2022 06:20:41 GMT, Julian Waters wrote:
> After [JDK-8292008](https://bugs.openjdk.org/browse/JDK-8292008) and
> [JDK-8247283](https://bugs.openjdk.org/browse/JDK-8247283), some C and C++
> code across the JDK can be replaced and simplified with cleaner language
> features that
On Mon, 12 Jun 2023 16:39:33 GMT, Xue-Lei Andrew Fan wrote:
> Hi,
>
> May I get this simple update reviewed?
>
> The class field RSAPadding.md can be converted to a local variable of the
> constructor, and save the class footprint.
>
> Thanks,
> Xuelei
Marked as reviewed by hchao (Committer)
> This PR implements a test to verify that Java will not negotiate TLS
> connections when one side of the connection requests disabled cipher suites.
Matthew Donovan has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated chan
On Fri, 9 Jun 2023 17:23:00 GMT, Sean Mullan wrote:
>> Matthew Donovan has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains three additional
>> commi
Hi,
May I get this simple update reviewed?
The class field RSAPadding.md can be converted to a local variable of the
constructor, and save the class footprint.
Thanks,
Xuelei
-
Commit messages:
- 8309867: redundant class field RSAPadding.md
Changes: https://git.openjdk.org/jdk/p
On Fri, 9 Jun 2023 13:54:14 GMT, Sean Coffey wrote:
> New functionality in the -XshowSettings menu to display relevant information
> about JDK security configuration
Another possibility is to put this under a new option, ex
`-XshowSecuritySettings`.
-
PR Comment: https://git.open
On Sun, 11 Jun 2023 16:38:31 GMT, Artem Semenov wrote:
>> When using the clang compiler to build OpenJDk on Linux, we encounter
>> various "warnings as errors".
>> They can be fixed with small changes.
>
> Artem Semenov has updated the pull request with a new target base due to a
> merge or a r
On Fri, 9 Jun 2023 13:54:14 GMT, Sean Coffey wrote:
> New functionality in the -XshowSettings menu to display relevant information
> about JDK security configuration
Thanks for the reviews to date. All good comments, I'll implement.
Yes, the output of `-XShowSettings` is more verbose. Let me t
27 matches
Mail list logo
