Integrated: 8294985: SSLEngine throws IAE during parsing of X500Principal

2023-06-09 Thread Kevin Driver
On Thu, 13 Apr 2023 18:49:48 GMT, Kevin Driver wrote: > Fixes: [JDK-8294985](https://bugs.openjdk.org/browse/JDK-8294985) This pull request has now been integrated. Changeset: 80edd5c2 Author:Kevin Driver Committer: Bradford Wetmore URL: https://git.openjdk.org/jdk/commit/80edd5c29

Re: RFR: 8294985: SSLEngine throws IAE during parsing of X500Principal [v30]

2023-06-09 Thread Bradford Wetmore
On Fri, 9 Jun 2023 19:48:13 GMT, Kevin Driver wrote: >> Fixes: [JDK-8294985](https://bugs.openjdk.org/browse/JDK-8294985) > > Kevin Driver has updated the pull request incrementally with one additional > commit since the last revision: > > fixed server payload once more Latest change looks g

Re: RFR: 8294985: SSLEngine throws IAE during parsing of X500Principal [v30]

2023-06-09 Thread Kevin Driver
> Fixes: [JDK-8294985](https://bugs.openjdk.org/browse/JDK-8294985) Kevin Driver has updated the pull request incrementally with one additional commit since the last revision: fixed server payload once more - Changes: - all: https://git.openjdk.org/jdk/pull/13466/files - new:

Re: RFR: 8281658: Add a security category to the java -XshowSettings option

2023-06-09 Thread Sean Mullan
On Fri, 9 Jun 2023 13:54:14 GMT, Sean Coffey wrote: > New functionality in the -XshowSettings menu to display relevant information > about JDK security configuration Did you consider only showing the security settings if the "security" option is specified? Seems like a lot of data to show in t

RE: [External] : Re: test/jdk/sun/security/pkcs11/KeyStore/CertChainRemoval.java fails on Ubuntu 23.10 AMD64

2023-06-09 Thread Valerie Peng
Thanks for the notice. Matthias Baesken already filed a separate bug on this (https://bugs.openjdk.org/browse/JDK-8309214 : https://bugs.openjdk.org/browse/JDK-8309214) and we started exchange info as I can't reproduce the test failure. So you are observing this with NSS 3.89 but Francisco isn

Re: RFR: JDK-8287061: Support for rematerializing scalar replaced objects participating in allocation merges [v17]

2023-06-09 Thread Cesar Soares Lucas
On Tue, 6 Jun 2023 23:14:14 GMT, Cesar Soares Lucas wrote: >> Can I please get reviews for this PR? >> >> The most common and frequent use of NonEscaping Phis merging object >> allocations is for debugging information. The two graphs below show numbers >> for Renaissance and DaCapo benchmarks

Re: RFR: 8301379: Verify TLS_ECDH_* cipher suites cannot be negotiated

2023-06-09 Thread Sean Mullan
On Mon, 5 Jun 2023 18:22:13 GMT, Matthew Donovan wrote: > This PR implements a test to verify that Java will not negotiate TLS > connections when one side of the connection requests disabled cipher suites. test/jdk/javax/net/ssl/TLS/TLSWontNegotiateDisabledCipherAlgos.java line 35: > 33: * @t

Re: RFR: JDK-8287061: Support for rematerializing scalar replaced objects participating in allocation merges [v17]

2023-06-09 Thread Vladimir Ivanov
On Tue, 6 Jun 2023 23:14:14 GMT, Cesar Soares Lucas wrote: >> Can I please get reviews for this PR? >> >> The most common and frequent use of NonEscaping Phis merging object >> allocations is for debugging information. The two graphs below show numbers >> for Renaissance and DaCapo benchmarks

Re: RFR: JDK-8287061: Support for rematerializing scalar replaced objects participating in allocation merges [v13]

2023-06-09 Thread Cesar Soares Lucas
On Tue, 23 May 2023 17:19:23 GMT, Vladimir Ivanov wrote: >>> I verified that the new test cases do trigger SR+NSR scenario. >>> >>> How do you test that deoptimization works as expected? >>> >> >> I have a copy of the tests in AllocationMergesTests.java in a separate file >> (not included in

Re: RFR: 8294985: SSLEngine throws IAE during parsing of X500Principal [v29]

2023-06-09 Thread Kevin Driver
> Fixes: [JDK-8294985](https://bugs.openjdk.org/browse/JDK-8294985) Kevin Driver has updated the pull request incrementally with one additional commit since the last revision: uniformity in keystore paths - Changes: - all: https://git.openjdk.org/jdk/pull/13466/files - new: h

Re: RFR: 8294985: SSLEngine throws IAE during parsing of X500Principal [v28]

2023-06-09 Thread Kevin Driver
> Fixes: [JDK-8294985](https://bugs.openjdk.org/browse/JDK-8294985) Kevin Driver has updated the pull request incrementally with one additional commit since the last revision: test case now catching the proper variety of SSLException (the message is now correct) - Changes: - a

Re: RFR: 8281658: Add a security category to the java -XshowSettings option

2023-06-09 Thread Roger Riggs
On Fri, 9 Jun 2023 13:54:14 GMT, Sean Coffey wrote: > New functionality in the -XshowSettings menu to display relevant information > about JDK security configuration src/java.base/share/classes/sun/launcher/LauncherHelper.java line 65: > 63: import java.text.MessageFormat; > 64: import java.te

RFR: 8281658: Add a security category to the java -XshowSettings option

2023-06-09 Thread Sean Coffey
New functionality in the -XshowSettings menu to display relevant information about JDK security configuration - Commit messages: - minor edits, copyright, descriptions etc - Merge branch 'master' into 8281658-showsettings-security - Merge branch 'master' into 8281658-showsettings-

Re: test/jdk/sun/security/pkcs11/KeyStore/CertChainRemoval.java fails on Ubuntu 23.10 AMD64

2023-06-09 Thread Vladimir Petko
Hi, I have run the test in Mantic, which has NSS 3.89[1], and got the same failure. Best Regards, Vladimir. [1] https://launchpad.net/ubuntu/+source/nss/2:3.89-2 On Fri, Jun 9, 2023 at 10:09 PM Francisco Ferrari Bihurriet wrote: > > Hi Vladimir, > > This seems to be the same that is reported

Re: RFR: JDK-8305406: Add @spec tags in java.base/java.* (part 2) [v3]

2023-06-09 Thread Ferenc Rakoczi
On Thu, 8 Jun 2023 20:46:41 GMT, Jonathan Gibbons wrote: > > I checked out references to `nist.gov`. > > I found 7 references to 4 documents: > > ``` > > $ grep -r '*.*href=[^ ]*nist.gov' open/src/java.base | grep -o > > 'nist.gov[^"]*' > > nist.gov/nistpubs/FIPS/NIST.FIPS.140-2.pdf > > nist.gov

Re: test/jdk/sun/security/pkcs11/KeyStore/CertChainRemoval.java fails on Ubuntu 23.10 AMD64

2023-06-09 Thread Francisco Ferrari Bihurriet
Hi Vladimir, This seems to be the same that is reported in a JDK-8301154 comment [1], we incidentally hit this when fixing JDK-8309569 [2]. It was failing on Martin Balao's Fedora machine with an older NSS version and working on my newer Fedora with NSS 3.89. Copying Valerie for awareness j

test/jdk/sun/security/pkcs11/KeyStore/CertChainRemoval.java fails on Ubuntu 23.10 AMD64

2023-06-09 Thread Vladimir Petko
Hi, test/jdk/sun/security/pkcs11/KeyStore/CertChainRemoval.java[1] fails on Ubuntu Lunar (amd64) with CKR_GENERAL_ERROR . Reordering certificate addition (0001-CertChainRemoval-reorder-certificates.patch) allows the test to pass, but it may indicate a more serious underlying problem with library c