Integrated: 8309569: sun/security/pkcs11/Signature/TestRSAKeyLength.java fails after JDK-8301553

2023-06-07 Thread Martin Balao
On Wed, 7 Jun 2023 20:24:12 GMT, Martin Balao wrote: > We would like to propose a fix for 8309569. In this bug, a Java signature > buffer of length 0 is passed to > sun.security.pkcs11.wrapper.PKCS11::C_VerifyFinal to finish an ongoing > signature verification operation. Notice that finishing

Re: RFR: 8309569: sun/security/pkcs11/Signature/TestRSAKeyLength.java fails after JDK-8301553

2023-06-07 Thread Valerie Peng
On Wed, 7 Jun 2023 20:24:12 GMT, Martin Balao wrote: > We would like to propose a fix for 8309569. In this bug, a Java signature > buffer of length 0 is passed to > sun.security.pkcs11.wrapper.PKCS11::C_VerifyFinal to finish an ongoing > signature verification operation. Notice that finishing

Re: RFR: 8294985: SSLEngine throws IAE during parsing of X500Principal [v27]

2023-06-07 Thread Kevin Driver
> Fixes: [JDK-8294985](https://bugs.openjdk.org/browse/JDK-8294985) Kevin Driver has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 31 additional commits s

Re: RFR: 8309569: sun/security/pkcs11/Signature/TestRSAKeyLength.java fails after JDK-8301553

2023-06-07 Thread Valerie Peng
On Wed, 7 Jun 2023 20:24:12 GMT, Martin Balao wrote: > We would like to propose a fix for 8309569. In this bug, a Java signature > buffer of length 0 is passed to > sun.security.pkcs11.wrapper.PKCS11::C_VerifyFinal to finish an ongoing > signature verification operation. Notice that finishing

Re: RFR: 8294985: SSLEngine throws IAE during parsing of X500Principal [v26]

2023-06-07 Thread Kevin Driver
> Fixes: [JDK-8294985](https://bugs.openjdk.org/browse/JDK-8294985) Kevin Driver has updated the pull request incrementally with one additional commit since the last revision: latest version of TLS1.2 test - Changes: - all: https://git.openjdk.org/jdk/pull/13466/files - new:

RFR: 8305104: Remove old core reflection implementation

2023-06-07 Thread Mandy Chung
JEP 416 integrated in JDK 18 and since then, only a couple minor issues has been reported. Those issues were related with exception being thrown with invalid arguments. We propose to remove the old core reflection implementation in JDK 22. The `-Djdk.reflect.useDirectMethodHandle=false` wor

Re: RFR: 8308474: DSA does not reset SecureRandom when initSign is called again

2023-06-07 Thread Weijun Wang
On Wed, 7 Jun 2023 20:55:55 GMT, Bernd wrote: >> It does - I'll change the test to not have this potential failure mode. > > I think it’s fine (just wanted to make sure i understood the problem > correctly), especially with the fixed seed. You could just comment it with > „with this seed the fi

Re: RFR: 8308474: DSA does not reset SecureRandom when initSign is called again

2023-06-07 Thread Bernd
On Wed, 7 Jun 2023 19:53:26 GMT, Ben Perez wrote: >> test/jdk/sun/security/provider/DSA/SecureRandomReset.java line 51: >> >>> 49: >>> 50: // Re-initialize deterministic RNG and sign >>> 51: s.initSign(sk, deterministic()); >> >> Does this test depend on the fact that if the re

RFR: 8309569: sun/security/pkcs11/Signature/TestRSAKeyLength.java fails after JDK-8301553

2023-06-07 Thread Martin Balao
We would like to propose a fix for 8309569. In this bug, a Java signature buffer of length 0 is passed to sun.security.pkcs11.wrapper.PKCS11::C_VerifyFinal to finish an ongoing signature verification operation. Notice that finishing the operation by means of C_SessionCancel was either not tried

Re: RFR: JDK-8287061: Support for rematerializing scalar replaced objects participating in allocation merges [v13]

2023-06-07 Thread Cesar Soares Lucas
On Tue, 23 May 2023 17:19:23 GMT, Vladimir Ivanov wrote: >>> I verified that the new test cases do trigger SR+NSR scenario. >>> >>> How do you test that deoptimization works as expected? >>> >> >> I have a copy of the tests in AllocationMergesTests.java in a separate file >> (not included in

Re: RFR: 8308474: DSA does not reset SecureRandom when initSign is called again

2023-06-07 Thread Ben Perez
On Wed, 7 Jun 2023 07:00:45 GMT, Bernd wrote: >> Fixed `engineInitSign` in `DSA.java` and added `SecureRandomReset.java` to >> DSA tests > > test/jdk/sun/security/provider/DSA/SecureRandomReset.java line 51: > >> 49: >> 50: // Re-initialize deterministic RNG and sign >> 51: s.i

Re: RFR: 8307144: namedParams in XECParameters and EdDSAParameters can be private final

2023-06-07 Thread Sean Mullan
On Thu, 25 May 2023 21:17:40 GMT, Ben Perez wrote: > Changed `namedParams` in XECParameters and EdDSAParameters to be `private > final` src/jdk.crypto.ec/share/classes/sun/security/ec/XECParameters.java line 45: > 43: static final XECParameters X448; > 44: > 45: private static final P

Re: RFR: 8308474: DSA does not reset SecureRandom when initSign is called again

2023-06-07 Thread Bernd
On Thu, 1 Jun 2023 21:17:11 GMT, Ben Perez wrote: > Fixed `engineInitSign` in `DSA.java` and added `SecureRandomReset.java` to > DSA tests test/jdk/sun/security/provider/DSA/SecureRandomReset.java line 51: > 49: > 50: // Re-initialize deterministic RNG and sign > 51: s.initSig

Re: RFR: 8308286 Fix clang warnings in linux code [v4]

2023-06-07 Thread Alexey Ushakov
On Thu, 1 Jun 2023 15:01:37 GMT, Artem Semenov wrote: >> When using the clang compiler to build OpenJDk on Linux, we encounter >> various "warnings as errors". >> They can be fixed with small changes. > > Artem Semenov has updated the pull request incrementally with one additional > commit sinc