Re: RFR: 8308711: Develop additional Tests for KEM implementation [v5]

2023-06-01 Thread Sibabrata Sahoo
> Additional Tests for KEM API. Sibabrata Sahoo has updated the pull request incrementally with one additional commit since the last revision: Comment added - Changes: - all: https://git.openjdk.org/jdk/pull/14113/files - new: https://git.openjdk.org/jdk/pull/14113/files/f70d

Re: RFR: 8309330: Allow java.security to be extended via a properties directory

2023-06-01 Thread Alexey Bakhtin
On Fri, 2 Jun 2023 00:57:49 GMT, Andrew John Hughes wrote: > Currently, security properties are held within the `java.security` file in > the JDK tree for each installed JDK. The system property > `java.security.properties` can be used to point to a file containing > additional properties. The

Re: RFR: 8301553: Support Password-Based Cryptography in SunPKCS11 [v6]

2023-06-01 Thread Francisco Ferrari Bihurriet
On Thu, 1 Jun 2023 23:47:46 GMT, Francisco Ferrari Bihurriet wrote: >> src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11PBECipher.java >> line 221: >> >>> 219: // for the underlying cipher is equal to the PBE service key >>> length. >>> 220: // Otherwise, initializ

RFR: 8309330: Allow java.security to be extended via a properties directory

2023-06-01 Thread Andrew John Hughes
Currently, security properties are held within the `java.security` file in the JDK tree for each installed JDK. The system property `java.security.properties` can be used to point to a file containing additional properties. These can be appended to the existing set or override all existing prope

Re: RFR: 8301553: Support Password-Based Cryptography in SunPKCS11 [v6]

2023-06-01 Thread Francisco Ferrari Bihurriet
On Thu, 1 Jun 2023 21:04:32 GMT, Valerie Peng wrote: >> Martin Balao has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8301553: Support Password-Based Cryptography in SunPKCS11 (iteration #4) >> >> Co-authored-by: Francisco Ferrari >

Re: RFR: 8301553: Support Password-Based Cryptography in SunPKCS11 [v6]

2023-06-01 Thread Francisco Ferrari Bihurriet
On Thu, 1 Jun 2023 21:04:32 GMT, Valerie Peng wrote: > For example: For SecretKeyFactory.PBEWithHmacSHA1AndAES_128, use > `CKM_PKCS5_PBKD2 (required CKM_SHA_1_HMAC)` instead of `CKM_PKCS5_PBKD2 and > CKM_SHA_1_HMAC`. Ah, ok, now I see. Unfortunately I don't yet have a JBS user, but I'll send t

Re: RFR: 8301553: Support Password-Based Cryptography in SunPKCS11 [v6]

2023-06-01 Thread Francisco Ferrari Bihurriet
On Tue, 30 May 2023 23:42:24 GMT, Valerie Peng wrote: >> Martin Balao has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8301553: Support Password-Based Cryptography in SunPKCS11 (iteration #4) >> >> Co-authored-by: Francisco Ferrari

Re: RFR: 8301553: Support Password-Based Cryptography in SunPKCS11 [v6]

2023-06-01 Thread Francisco Ferrari Bihurriet
On Thu, 1 Jun 2023 22:06:04 GMT, Francisco Ferrari Bihurriet wrote: >> src/java.base/share/classes/sun/security/util/PBEUtil.java line 105: >> >>> 103: "needed for decryption"); >>> 104: } >>> 105: } >> >> Isn't there also def

Re: RFR: 8301553: Support Password-Based Cryptography in SunPKCS11 [v6]

2023-06-01 Thread Francisco Ferrari Bihurriet
On Tue, 30 May 2023 22:03:44 GMT, Valerie Peng wrote: >> Martin Balao has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8301553: Support Password-Based Cryptography in SunPKCS11 (iteration #4) >> >> Co-authored-by: Francisco Ferrari

Re: RFR: 8308592: Framework for CA interoperability testing [v7]

2023-06-01 Thread Rajan Halade
> The new approach uses test URLs directly to verify interoperability with CA > infrastructure. This would help us avoid having regular test fixes to update > test artifacts as long as CAs keep test domains up to date. Rajan Halade has updated the pull request incrementally with one additional

Re: RFR: 8301553: Support Password-Based Cryptography in SunPKCS11 [v6]

2023-06-01 Thread Valerie Peng
On Sat, 27 May 2023 06:24:36 GMT, Martin Balao wrote: >> We would like to propose an implementation for the [JDK-8301553: Support >> Password-Based Cryptography in >> SunPKCS11](https://bugs.openjdk.org/browse/JDK-8301553) enhancement >> requirement. >> >> In addition to pursuing the requirem

Re: RFR: 8308592: Framework for CA interoperability testing [v4]

2023-06-01 Thread Rajan Halade
On Thu, 1 Jun 2023 20:25:16 GMT, Sean Mullan wrote: >> Rajan Halade has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8308592: Framework for CA interoperability testing > > test/jdk/security/infra/java/security/cert/CertPathValidator/certi

Re: RFR: 8308592: Framework for CA interoperability testing [v6]

2023-06-01 Thread Rajan Halade
> The new approach uses test URLs directly to verify interoperability with CA > infrastructure. This would help us avoid having regular test fixes to update > test artifacts as long as CAs keep test domains up to date. Rajan Halade has updated the pull request incrementally with one additional

Re: RFR: 8308592: Framework for CA interoperability testing [v3]

2023-06-01 Thread Rajan Halade
On Thu, 1 Jun 2023 20:15:10 GMT, Sean Mullan wrote: >> Rajan Halade has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8308592: remove unused imports > > test/jdk/security/infra/java/security/cert/CertPathValidator/certification/ValidatePat

Re: RFR: 8308592: Framework for CA interoperability testing [v3]

2023-06-01 Thread Sean Mullan
On Wed, 31 May 2023 22:46:53 GMT, Rajan Halade wrote: >> The new approach uses test URLs directly to verify interoperability with CA >> infrastructure. This would help us avoid having regular test fixes to update >> test artifacts as long as CAs keep test domains up to date. > > Rajan Halade ha

Re: RFR: 8308592: Framework for CA interoperability testing [v4]

2023-06-01 Thread Sean Mullan
On Thu, 1 Jun 2023 20:09:39 GMT, Rajan Halade wrote: >> The new approach uses test URLs directly to verify interoperability with CA >> infrastructure. This would help us avoid having regular test fixes to update >> test artifacts as long as CAs keep test domains up to date. > > Rajan Halade has

Re: RFR: 8308592: Framework for CA interoperability testing [v5]

2023-06-01 Thread Rajan Halade
> The new approach uses test URLs directly to verify interoperability with CA > infrastructure. This would help us avoid having regular test fixes to update > test artifacts as long as CAs keep test domains up to date. Rajan Halade has updated the pull request incrementally with one additional

Re: RFR: 8308592: Framework for CA interoperability testing [v4]

2023-06-01 Thread Rajan Halade
> The new approach uses test URLs directly to verify interoperability with CA > infrastructure. This would help us avoid having regular test fixes to update > test artifacts as long as CAs keep test domains up to date. Rajan Halade has updated the pull request incrementally with one additional

Re: RFR: 8308592: Update CA interop test certificates [v3]

2023-06-01 Thread Sean Mullan
On Wed, 31 May 2023 22:46:53 GMT, Rajan Halade wrote: >> The new approach uses test URLs directly to verify interoperability with CA >> infrastructure. This would help us avoid having regular test fixes to update >> test artifacts as long as CAs keep test domains up to date. > > Rajan Halade ha

Re: RFR: 8306688: Support Windows serialized keystores (SST files)

2023-06-01 Thread Bernd
On Fri, 26 May 2023 21:09:35 GMT, Mat Carter wrote: > Added ability to load keystores from SST files on Windows. Example usage: > > KeyStore keyStore = KeyStore.getInstance("Windows-SST"); > try (FileInputStream fis = new FileInputStream("mykeystore.sst")) { >keyStore.load(fis, null); > } >

Re: RFR: 8306688: Support Windows serialized keystores (SST files)

2023-06-01 Thread Weijun Wang
On Fri, 26 May 2023 21:09:35 GMT, Mat Carter wrote: > Added ability to load keystores from SST files on Windows. Example usage: > > KeyStore keyStore = KeyStore.getInstance("Windows-SST"); > try (FileInputStream fis = new FileInputStream("mykeystore.sst")) { >keyStore.load(fis, null); > } >

Re: RFR: 8306688: Support Windows serialized keystores (SST files)

2023-06-01 Thread Mat Carter
On Fri, 26 May 2023 21:09:35 GMT, Mat Carter wrote: > Added ability to load keystores from SST files on Windows. Example usage: > > KeyStore keyStore = KeyStore.getInstance("Windows-SST"); > try (FileInputStream fis = new FileInputStream("mykeystore.sst")) { >keyStore.load(fis, null); > } >

Re: RFR: 8306688: Support Windows serialized keystores (SST files)

2023-06-01 Thread Weijun Wang
On Fri, 26 May 2023 21:09:35 GMT, Mat Carter wrote: > Added ability to load keystores from SST files on Windows. Example usage: > > KeyStore keyStore = KeyStore.getInstance("Windows-SST"); > try (FileInputStream fis = new FileInputStream("mykeystore.sst")) { >keyStore.load(fis, null); > } >

Re: RFR: 8308592: Update CA interop test certificates [v3]

2023-06-01 Thread Rajan Halade
On Wed, 31 May 2023 22:46:53 GMT, Rajan Halade wrote: >> The new approach uses test URLs directly to verify interoperability with CA >> infrastructure. This would help us avoid having regular test fixes to update >> test artifacts as long as CAs keep test domains up to date. > > Rajan Halade ha

Re: RFR: 8306688: Support Windows serialized keystores (SST files)

2023-06-01 Thread Mat Carter
On Fri, 26 May 2023 21:09:35 GMT, Mat Carter wrote: > Added ability to load keystores from SST files on Windows. Example usage: > > KeyStore keyStore = KeyStore.getInstance("Windows-SST"); > try (FileInputStream fis = new FileInputStream("mykeystore.sst")) { >keyStore.load(fis, null); > } >

Re: RFR: 8296411: AArch64: Accelerated Poly1305 intrinsics [v5]

2023-06-01 Thread Andrew Haley
> This provides a solid speedup of about 3-4x over the Java implementation. > > I have a vectorized version of this which uses a bunch of tricks to speed it > up, but it's complex and can still be improved. We're getting close to ramp > down, so I'm submitting this simple intrinsic so that we ca

Re: RFR: 8296411: AArch64: Accelerated Poly1305 intrinsics [v4]

2023-06-01 Thread Andrew Haley
On Thu, 1 Jun 2023 15:00:26 GMT, Andrew Haley wrote: > This comment and the next one both need correcting. They mention U_0HI and > U_1HI and, as the previous comment says, those registers are dead. > > What actually happens here is best summarized as > > // U_2:U_1:U_0 += (U2 >> 2) * 5 > > or,

Re: RFR: 8308286 Fix clang warnings in linux code [v3]

2023-06-01 Thread Weijun Wang
On Thu, 1 Jun 2023 15:02:16 GMT, Artem Semenov wrote: >> src/java.security.jgss/share/native/libj2gss/gssapi.h line 47: >> >>> 45: >>> 46: // Condition was copied from >>> 47: // >>> Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/gssapi/gssapi.h >>

Re: RFR: 8308286 Fix clang warnings in linux code [v3]

2023-06-01 Thread Artem Semenov
On Wed, 31 May 2023 13:52:39 GMT, Weijun Wang wrote: >> Artem Semenov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> update > > src/java.security.jgss/share/native/libj2gss/gssapi.h line 47: > >> 45: >> 46: // Condition was copied fro

Re: RFR: 8308286 Fix clang warnings in linux code [v4]

2023-06-01 Thread Artem Semenov
> When using the clang compiler to build OpenJDk on Linux, we encounter various > "warnings as errors". > They can be fixed with small changes. Artem Semenov has updated the pull request incrementally with one additional commit since the last revision: update - Changes: - all:

Re: RFR: 8296411: AArch64: Accelerated Poly1305 intrinsics [v4]

2023-06-01 Thread Andrew Haley
On Thu, 1 Jun 2023 12:16:45 GMT, Andrew Dinn wrote: > This comment and the next one both need correcting. They mention U_0HI and > U_1HI and, as the previous comment says, those registers are dead. > > What actually happens here is best summarized as > > // U_2:U_1:U_0 += (U2 >> 2) * 5 > > or, i

Re: RFR: 8308711: Develop additional Tests for KEM implementation [v4]

2023-06-01 Thread Weijun Wang
On Thu, 1 Jun 2023 14:44:53 GMT, Sibabrata Sahoo wrote: >> test/jdk/javax/crypto/KEM/KemTest.java line 138: >> >>> 136: >>> decT.decapsulate(enc.encapsulation()).getEncoded().length); >>> 137: >>> Asserts.assertEQ(decT.decapsulate(enc.encapsulation()).ge

Re: RFR: 8308711: Develop additional Tests for KEM implementation [v4]

2023-06-01 Thread Sibabrata Sahoo
On Thu, 1 Jun 2023 14:16:23 GMT, Weijun Wang wrote: >> Sibabrata Sahoo has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Comments addressed > > test/jdk/javax/crypto/KEM/GenLargeNumberOfKeys.java line 79: > >> 77: sk.getEn

Re: RFR: 8308711: Develop additional Tests for KEM implementation [v4]

2023-06-01 Thread Weijun Wang
On Thu, 1 Jun 2023 07:37:38 GMT, Sibabrata Sahoo wrote: >> Additional Tests for KEM API. > > Sibabrata Sahoo has updated the pull request incrementally with one > additional commit since the last revision: > > Comments addressed Looks good to me. Thanks! - Marked as reviewed by

Re: RFR: 8308592: Update CA interop test certificates [v3]

2023-06-01 Thread Weijun Wang
On Wed, 31 May 2023 22:46:53 GMT, Rajan Halade wrote: >> The new approach uses test URLs directly to verify interoperability with CA >> infrastructure. This would help us avoid having regular test fixes to update >> test artifacts as long as CAs keep test domains up to date. > > Rajan Halade ha

Re: RFR: 8308711: Develop additional Tests for KEM implementation [v4]

2023-06-01 Thread Weijun Wang
On Thu, 1 Jun 2023 07:37:38 GMT, Sibabrata Sahoo wrote: >> Additional Tests for KEM API. > > Sibabrata Sahoo has updated the pull request incrementally with one > additional commit since the last revision: > > Comments addressed test/jdk/javax/crypto/KEM/GenLargeNumberOfKeys.java line 79: >

Integrated: JDK-8307794 Test for HSS/LMS Signature Verification

2023-06-01 Thread Mark Powers
On Thu, 11 May 2023 19:06:59 GMT, Mark Powers wrote: > https://bugs.openjdk.org/browse/JDK-8307794 This pull request has now been integrated. Changeset: d9871764 Author:Mark Powers Committer: Weijun Wang URL: https://git.openjdk.org/jdk/commit/d987176412b0a1812c9b99aaaeaf65ac96fa05

Integrated: 8298127: HSS/LMS Signature Verification

2023-06-01 Thread Ferenc Rakoczi
On Thu, 27 Apr 2023 14:16:34 GMT, Ferenc Rakoczi wrote: > Implement support for Leighton-Micali Signatures (LMS) as described in RFC > 8554. LMS is an approved software signing algorithm for CNSA 2.0, with > SHA-256/192 parameters recommended. This pull request has now been integrated. Change

Re: RFR: 8296411: AArch64: Accelerated Poly1305 intrinsics [v4]

2023-06-01 Thread Andrew Dinn
On Wed, 24 May 2023 16:17:14 GMT, Andrew Haley wrote: >> This provides a solid speedup of about 3-4x over the Java implementation. >> >> I have a vectorized version of this which uses a bunch of tricks to speed it >> up, but it's complex and can still be improved. We're getting close to ramp >

Re: RFR: 8308711: Develop additional Tests for KEM implementation [v3]

2023-06-01 Thread Sibabrata Sahoo
On Wed, 31 May 2023 13:00:15 GMT, Weijun Wang wrote: >> Sibabrata Sahoo has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8308711: Comment addressed > > test/jdk/javax/crypto/KEM/GenLargeNumberOfKeys.java line 45: > >> 43: * X448 pro

Re: RFR: 8308711: Develop additional Tests for KEM implementation [v4]

2023-06-01 Thread Sibabrata Sahoo
> Additional Tests for KEM API. Sibabrata Sahoo has updated the pull request incrementally with one additional commit since the last revision: Comments addressed - Changes: - all: https://git.openjdk.org/jdk/pull/14113/files - new: https://git.openjdk.org/jdk/pull/14113/files