Re: RFD: Services lockdown for security providers

2023-05-25 Thread Martin Balao
On 5/25/23 19:54, Wei-Jun Wang wrote: So, the filter will look like this? SunPKCS11-Name.Signature.*,!*.Signature.*,* Yes, that's right. The filter that you showed will do the following: 1) Accept Signature services provided by SunPKCS11-Name, irrespective of the algorithm; 2) Block S

Re: RFR: 8301553: Support Password-Based Cryptography in SunPKCS11 [v3]

2023-05-25 Thread Martin Balao
On Tue, 23 May 2023 14:00:30 GMT, Sean Mullan wrote: >> We found several more cases of passwords and encoded keys not cleared that >> were addressed in out Iteration # 2 commit. These cases were both in Java >> and native code. We still have doubts about the effectiveness and need for >> these

Re: RFD: Services lockdown for security providers

2023-05-25 Thread Wei-Jun Wang
I see. So, the filter will look like this? SunPKCS11-Name.Signature.*,!*.Signature.*,* --Max > On May 25, 2023, at 6:40 PM, Martin Balao wrote: > > Hi Max, > > In this example, we want certificates validation from SUN but signature > verification from SunPKCS11 (only). The problem with t

Re: RFR: 8301553: Support Password-Based Cryptography in SunPKCS11 [v5]

2023-05-25 Thread Martin Balao
On Thu, 25 May 2023 20:22:03 GMT, Valerie Peng wrote: >> Martin Balao has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8301553: Support Password-Based Cryptography in SunPKCS11 (iteration #3) >> >> Co-authored-by: Francisco Ferrari

Re: RFR: 8301553: Support Password-Based Cryptography in SunPKCS11 [v5]

2023-05-25 Thread Martin Balao
On Thu, 25 May 2023 19:30:36 GMT, Valerie Peng wrote: >> Martin Balao has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8301553: Support Password-Based Cryptography in SunPKCS11 (iteration #3) >> >> Co-authored-by: Francisco Ferrari

Re: RFR: 8301553: Support Password-Based Cryptography in SunPKCS11 [v5]

2023-05-25 Thread Martin Balao
On Thu, 25 May 2023 00:11:54 GMT, Valerie Peng wrote: >> Martin Balao has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8301553: Support Password-Based Cryptography in SunPKCS11 (iteration #3) >> >> Co-authored-by: Francisco Ferrari

Re: RFR: 8297878: KEM: Implementation [v20]

2023-05-25 Thread Weijun Wang
> The KEM API and DHKEM impl. Note that this PR uses new methods in > https://github.com/openjdk/jdk/pull/13250. Weijun Wang has updated the pull request incrementally with one additional commit since the last revision: comment for RSA-KEM - Changes: - all: https://git.openjdk

Re: RFR: JDK-8287061: Support for rematerializing scalar replaced objects participating in allocation merges [v13]

2023-05-25 Thread Vladimir Ivanov
On Mon, 22 May 2023 17:56:41 GMT, Cesar Soares Lucas wrote: >> Are you sure there's no way to end up with nested ObjectMergeValues in >> presence of iterative EA? > I don't think so. Ok. Please, add asserts to catch such situation and a check which bails out compilation (triggering recompila

Re: RFR: JDK-8287061: Support for rematerializing scalar replaced objects participating in allocation merges [v14]

2023-05-25 Thread Cesar Soares Lucas
> Can I please get reviews for this PR? > > The most common and frequent use of NonEscaping Phis merging object > allocations is for debugging information. The two graphs below show numbers > for Renaissance and DaCapo benchmarks - similar results are obtained for all > other applications that

Re: RFD: Services lockdown for security providers

2023-05-25 Thread Martin Balao
Hi Max, In this example, we want certificates validation from SUN but signature verification from SunPKCS11 (only). The problem with the current design is that there could be a signature algorithm implemented in SUN but not in SunPKCS11. If that is the case, there is no way to prevent SUN from

Re: RFR: 8308144: HttpClient - uncontrolled memory consumption in SSLFlowDelegate.Reader

2023-05-25 Thread zhurs
On Thu, 25 May 2023 21:40:41 GMT, Daniel Fuchs wrote: >> When using HttpClient to make requests to HTTPS resources, there is an issue >> where the entire file is being downloaded into memory without the ability to >> limit the buffer size. >> If the SSLEngine cannot decode the entire buffer due

Re: RFR: 8308144: HttpClient - uncontrolled memory consumption in SSLFlowDelegate.Reader

2023-05-25 Thread Daniel Fuchs
On Thu, 25 May 2023 20:17:39 GMT, zhurs wrote: > When using HttpClient to make requests to HTTPS resources, there is an issue > where the entire file is being downloaded into memory without the ability to > limit the buffer size. > If the SSLEngine cannot decode the entire buffer due to the alg

Re: RFR: 8301553: Support Password-Based Cryptography in SunPKCS11 [v5]

2023-05-25 Thread Martin Balao
On Wed, 24 May 2023 23:35:55 GMT, Valerie Peng wrote: >> Martin Balao has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8301553: Support Password-Based Cryptography in SunPKCS11 (iteration #3) >> >> Co-authored-by: Francisco Ferrari

Re: RFR: 8301553: Support Password-Based Cryptography in SunPKCS11 [v5]

2023-05-25 Thread Valerie Peng
On Tue, 23 May 2023 19:29:47 GMT, Martin Balao wrote: >> We would like to propose an implementation for the [JDK-8301553: Support >> Password-Based Cryptography in >> SunPKCS11](https://bugs.openjdk.org/browse/JDK-8301553) enhancement >> requirement. >> >> In addition to pursuing the requirem

Re: RFR: 8297878: KEM: Implementation [v19]

2023-05-25 Thread Sean Mullan
On Thu, 25 May 2023 20:51:55 GMT, Weijun Wang wrote: >> The KEM API and DHKEM impl. Note that this PR uses new methods in >> https://github.com/openjdk/jdk/pull/13250. > > Weijun Wang has updated the pull request incrementally with one additional > commit since the last revision: > > test up

Re: RFR: 8297878: KEM: Implementation [v18]

2023-05-25 Thread Weijun Wang
On Thu, 18 May 2023 17:07:40 GMT, Weijun Wang wrote: >> The KEM API and DHKEM impl. Note that this PR uses new methods in >> https://github.com/openjdk/jdk/pull/13250. > > Weijun Wang has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev exclud

Re: RFR: 8297878: KEM: Implementation [v18]

2023-05-25 Thread Weijun Wang
On Thu, 25 May 2023 19:17:51 GMT, Sean Mullan wrote: >> Weijun Wang has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 18 additional >> commits sin

Re: RFR: 8297878: KEM: Implementation [v19]

2023-05-25 Thread Weijun Wang
> The KEM API and DHKEM impl. Note that this PR uses new methods in > https://github.com/openjdk/jdk/pull/13250. Weijun Wang has updated the pull request incrementally with one additional commit since the last revision: test update - Changes: - all: https://git.openjdk.org/jdk

RFR: 8308144: HttpClient - uncontrolled memory consumption in SSLFlowDelegate.Reader

2023-05-25 Thread zhurs
When using HttpClient to make requests to HTTPS resources, there is an issue where the entire file is being downloaded into memory without the ability to limit the buffer size. If the SSLEngine cannot decode the entire buffer due to the algorithm's blocking nature, it returns a decoded chunk of

Re: RFR: 8301553: Support Password-Based Cryptography in SunPKCS11 [v5]

2023-05-25 Thread Valerie Peng
On Tue, 23 May 2023 19:29:47 GMT, Martin Balao wrote: >> We would like to propose an implementation for the [JDK-8301553: Support >> Password-Based Cryptography in >> SunPKCS11](https://bugs.openjdk.org/browse/JDK-8301553) enhancement >> requirement. >> >> In addition to pursuing the requirem

Re: RFR: 8301553: Support Password-Based Cryptography in SunPKCS11 [v5]

2023-05-25 Thread Valerie Peng
On Tue, 23 May 2023 19:29:47 GMT, Martin Balao wrote: >> We would like to propose an implementation for the [JDK-8301553: Support >> Password-Based Cryptography in >> SunPKCS11](https://bugs.openjdk.org/browse/JDK-8301553) enhancement >> requirement. >> >> In addition to pursuing the requirem

Re: RFR: 8297878: KEM: Implementation [v18]

2023-05-25 Thread Sean Mullan
On Thu, 18 May 2023 17:07:40 GMT, Weijun Wang wrote: >> The KEM API and DHKEM impl. Note that this PR uses new methods in >> https://github.com/openjdk/jdk/pull/13250. > > Weijun Wang has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev exclud

Re: RFR: 8298127: HSS/LMS Signature Verification [v18]

2023-05-25 Thread Sean Mullan
On Thu, 25 May 2023 16:00:51 GMT, Ferenc Rakoczi wrote: >> Implement support for Leighton-Micali Signatures (LMS) as described in RFC >> 8554. LMS is an approved software signing algorithm for CNSA 2.0, with >> SHA-256/192 parameters recommended. > > Ferenc Rakoczi has updated the pull request

Re: RFR: 8298127: HSS/LMS Signature Verification [v18]

2023-05-25 Thread Ferenc Rakoczi
> Implement support for Leighton-Micali Signatures (LMS) as described in RFC > 8554. LMS is an approved software signing algorithm for CNSA 2.0, with > SHA-256/192 parameters recommended. Ferenc Rakoczi has updated the pull request incrementally with one additional commit since the last revisio

Re: RFR: 8298127: HSS/LMS Signature Verification [v17]

2023-05-25 Thread Ferenc Rakoczi
On Wed, 24 May 2023 15:14:26 GMT, Sean Mullan wrote: >> Ferenc Rakoczi has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Removed dead code, accepted code style suggestions. > > src/java.base/share/classes/sun/security/provider/HSS.java lin

RFR: JDK-8308872: enhance logging and some exception in krb5/Config.java

2023-05-25 Thread Matthias Baesken
There exists already some logging in krb5/Config.java (enabled by -Dsun.security.krb5.debug=true), this could be enhanced for easier analysis of problems. Additionally some exception(s) might be slightly adjusted. - Commit messages: - JDK-8308872 Changes: https://git.openjdk.org/j

Re: RFR: 8298127: HSS/LMS Signature Verification [v17]

2023-05-25 Thread Ferenc Rakoczi
On Wed, 24 May 2023 16:22:55 GMT, Sean Mullan wrote: >> Ferenc Rakoczi has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Removed dead code, accepted code style suggestions. > > src/java.base/share/classes/sun/security/provider/HSS.java lin