Re: RFR: JDK-8308156: VerifyCACerts.java misses blank in error output

2023-05-16 Thread Matthias Baesken
On Tue, 16 May 2023 08:48:03 GMT, Matthias Baesken wrote: > In the checksum-related check, we miss blanks in the error output of the > calculated and expected checksum. Hi Rajan and Sean, thanks for the reviews ! - PR Comment: https://git.openjdk.org/jdk/pull/14003#issuecomment-15

Integrated: JDK-8308156: VerifyCACerts.java misses blank in error output

2023-05-16 Thread Matthias Baesken
On Tue, 16 May 2023 08:48:03 GMT, Matthias Baesken wrote: > In the checksum-related check, we miss blanks in the error output of the > calculated and expected checksum. This pull request has now been integrated. Changeset: 5a92aae1 Author:Matthias Baesken URL: https://git.openjdk.o

Re: RFR: 8301553: Support Password-Based Cryptography in SunPKCS11 [v3]

2023-05-16 Thread Martin Balao
> We would like to propose an implementation for the [JDK-8301553: Support > Password-Based Cryptography in > SunPKCS11](https://bugs.openjdk.org/browse/JDK-8301553) enhancement > requirement. > > In addition to pursuing the requirement goals and guidelines of > [JDK-8301553](https://bugs.open

Re: RFR: 8298127: HSS/LMS Signature Verification [v14]

2023-05-16 Thread Mark Powers
On Mon, 15 May 2023 16:14:24 GMT, Ferenc Rakoczi wrote: >> Implement support for Leighton-Micali Signatures (LMS) as described in RFC >> 8554. LMS is an approved software signing algorithm for CNSA 2.0, with >> SHA-256/192 parameters recommended. > > Ferenc Rakoczi has updated the pull request

Re: RFR: 8301553: Support Password-Based Cryptography in SunPKCS11 [v2]

2023-05-16 Thread Valerie Peng
On Tue, 21 Mar 2023 20:31:44 GMT, Martin Balao wrote: >> We would like to propose an implementation for the [JDK-8301553: Support >> Password-Based Cryptography in >> SunPKCS11](https://bugs.openjdk.org/browse/JDK-8301553) enhancement >> requirement. >> >> In addition to pursuing the requirem

Re: RFR: 8294985: SSLEngine throws IAE during parsing of X500Principal [v7]

2023-05-16 Thread Kevin Driver
> Fixes: [JDK-8294985](https://bugs.openjdk.org/browse/JDK-8294985) Kevin Driver has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits

Re: RFR: 8307326: Package jdk.internal.classfile.java.lang.constant become obsolete

2023-05-16 Thread Chen Liang
On Mon, 15 May 2023 08:38:54 GMT, Adam Sotona wrote: > Package `jdk.internal.classfile.java.lang.constant` containing `ModuleDesc` > and `PackageDesc` become obsolete after > [JDK-8306729](https://bugs.openjdk.org/browse/JDK-8306729). > All references to `jdk.internal.classfile.java.lang.const

Re: RFR: 8308016: Use snippets in java.io package [v5]

2023-05-16 Thread Brian Burkhalter
> Replace `{@code ...}` patterns and the like with `{@snippet > lang=java : ...}`. Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision: 8308016: Reduce linking in File::toPath snippet - Changes: - all: https://git.open

Re: RFR: JDK-8308156: VerifyCACerts.java misses blank in error output

2023-05-16 Thread Rajan Halade
On Tue, 16 May 2023 08:48:03 GMT, Matthias Baesken wrote: > In the checksum-related check, we miss blanks in the error output of the > calculated and expected checksum. Marked as reviewed by rhalade (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/14003#pullrequestreview-

Re: RFR: 8297878: KEM: Implementation [v16]

2023-05-16 Thread Weijun Wang
> The KEM API and DHKEM impl. Note that this PR uses new methods in > https://github.com/openjdk/jdk/pull/13250. Weijun Wang has updated the pull request incrementally with one additional commit since the last revision: to and length and comments - Changes: - all: https://git.

Re: RFR: 8297878: KEM: Implementation [v15]

2023-05-16 Thread Weijun Wang
On Mon, 15 May 2023 19:07:59 GMT, Anthony Scarpino wrote: >> Weijun Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> deterministic randomness > > src/java.base/share/classes/javax/crypto/KEM.java line 217: > >> 215: * >>

Re: RFR: JDK-8308156: VerifyCACerts.java misses blank in error output

2023-05-16 Thread Sean Mullan
On Tue, 16 May 2023 08:48:03 GMT, Matthias Baesken wrote: > In the checksum-related check, we miss blanks in the error output of the > calculated and expected checksum. Please add a `noreg-self` label to the bug as this is a fix to the test. - Marked as reviewed by mullan (Reviewe

Re: RFR: 7065228: To interpret case-insensitive string locale independently

2023-05-16 Thread Naoto Sato
On Tue, 16 May 2023 10:38:52 GMT, Darragh Clarke wrote: > Updated instances of `toLowerCase` and `toUpperCase` in several net and io > files to specify `Locale.ROOT` to ensure that case conversion issues don't > occur, > > I didn't add any new tests but ran tier 1-3 with no issues LGTM. Nice

Re: RFR: 7065228: To interpret case-insensitive string locale independently

2023-05-16 Thread Daniel Fuchs
On Tue, 16 May 2023 10:38:52 GMT, Darragh Clarke wrote: > Updated instances of `toLowerCase` and `toUpperCase` in several net and io > files to specify `Locale.ROOT` to ensure that case conversion issues don't > occur, > > I didn't add any new tests but ran tier 1-3 with no issues Looks gener

Re: RFR: 8308118: Avoid multiarray allocations in AESCrypt.makeSessionKey [v2]

2023-05-16 Thread David Schlosnagle
On Tue, 16 May 2023 09:28:11 GMT, Aleksey Shipilev wrote: >> True, let me try that! > > New commit implements this, with even more performance benefits. Excellent, thanks! - PR Review Comment: https://git.openjdk.org/jdk/pull/13996#discussion_r1195043072

RFR: 7065228: To interpret case-insensitive string locale independently

2023-05-16 Thread Darragh Clarke
Updated instances of `toLowerCase` and `toUpperCase` in several net and io files to specify `Locale.ROOT` to ensure that case conversion issues don't occur, I didn't add any new tests but ran tier 1-3 with no issues - Commit messages: - added some case conversions missed previousl

Re: RFR: 8308118: Avoid multiarray allocations in AESCrypt.makeSessionKey [v2]

2023-05-16 Thread Aleksey Shipilev
On Tue, 16 May 2023 06:28:17 GMT, Aleksey Shipilev wrote: >> src/java.base/share/classes/com/sun/crypto/provider/AESCrypt.java line 1372: >> >>> 1370: >>> 1371: // It is significantly faster to allocate individual arrays, >>> 1372: // instead of doing the multi-array allocation.

Re: RFR: 8308118: Avoid multiarray allocations in AESCrypt.makeSessionKey [v2]

2023-05-16 Thread Aleksey Shipilev
On Tue, 16 May 2023 08:29:52 GMT, Aleksey Shipilev wrote: >> src/java.base/share/classes/com/sun/crypto/provider/AESCrypt.java line 1369: >> >>> 1367: int BC = 4; >>> 1368: int[][] Ke = new int[ROUNDS + 1][]; // encryption round keys >>> 1369: int[][] Kd = new int[ROUNDS

Re: RFR: 8303465: KeyStore of type KeychainStore, provider Apple does not show all trusted certificates [v2]

2023-05-16 Thread Christoph Langer
> With this PR we try to be better in loading certificates from the MacOS > Keychain into a JDK Trust store. > > The current implementation after JDK-8278449 would only load/trust > certificates from an identity (with private key available) and certificates > that have explicit trust set in the

Re: RFR: 8308118: Avoid multiarray allocations in AESCrypt.makeSessionKey [v2]

2023-05-16 Thread Aleksey Shipilev
> One of our services has a hot path with AES/GCM cipher reuse. The JDK code > reinitializes the session key on that path, and > [JDK-8308105](https://bugs.openjdk.org/browse/JDK-8308105) shows up > prominently there. While > [JDK-8308105](https://bugs.openjdk.org/browse/JDK-8308105) is being f

Re: RFR: 8303465: KeyStore of type KeychainStore, provider Apple does not show all trusted certificates

2023-05-16 Thread Matthias Baesken
On Thu, 11 May 2023 21:38:35 GMT, Christoph Langer wrote: > With this PR we try to be better in loading certificates from the MacOS > Keychain into a JDK Trust store. > > The current implementation after JDK-8278449 would only load/trust > certificates from an identity (with private key availa

RFR: JDK-8308156: VerifyCACerts.java misses blank in error output

2023-05-16 Thread Matthias Baesken
In the checksum-related check, we miss blanks in the error output of the calculated and expected checksum. - Commit messages: - JDK-8308156 Changes: https://git.openjdk.org/jdk/pull/14003/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=14003&range=00 Issue: https://bugs.o

Re: RFR: 8308118: Avoid multiarray allocations in AESCrypt.makeSessionKey

2023-05-16 Thread Aleksey Shipilev
On Tue, 16 May 2023 01:44:24 GMT, David Schlosnagle wrote: >> One of our services has a hot path with AES/GCM cipher reuse. The JDK code >> reinitializes the session key on that path, and >> [JDK-8308105](https://bugs.openjdk.org/browse/JDK-8308105) shows up >> prominently there. While >> [JD

Re: RFR: 8308016: Use snippets in java.io package [v4]

2023-05-16 Thread Alan Bateman
On Mon, 15 May 2023 20:48:47 GMT, Brian Burkhalter wrote: >> Replace `{@code ...}` patterns and the like with `{@snippet >> lang=java : ...}`. > > Brian Burkhalter has updated the pull request incrementally with one > additional commit since the last revision: > > 8308016: Fix link in snippe

Re: RFR: 8303465: KeyStore of type KeychainStore, provider Apple does not show all trusted certificates

2023-05-16 Thread Matthias Baesken
On Thu, 11 May 2023 21:38:35 GMT, Christoph Langer wrote: > With this PR we try to be better in loading certificates from the MacOS > Keychain into a JDK Trust store. > > The current implementation after JDK-8278449 would only load/trust > certificates from an identity (with private key availa