Re: RFR: 8155191: Specify that SecureRandom.nextBytes(byte[]) throws NullPointerException when byte array is null [v2]

2023-05-04 Thread Valerie Peng
> Just a trivial change for enforcing consistent NullPointerException behavior > for the SecureRandom.nextBytes(byte[]) method. > > Other similar methods such as Random.nextByte(byte[]) and its other > subclasses all throw NPE for null byte[] argument. Most JDK default > providers' SecureRandom

Re: RFR: 8250596: Update remaining manpage references from "OS X" to "macOS"

2023-05-04 Thread David Holmes
On Thu, 4 May 2023 15:50:02 GMT, Adam Sotona wrote: > Most of the manpages were updated a few years ago but some references remain. > This patch renames remaining references to "macOS". > > Please review. > > Thanks, > Adam Looks good. - Marked as reviewed by dholmes (Reviewer).

Re: RFR: 8298127: HSS/LMS Signature Verification [v5]

2023-05-04 Thread Weijun Wang
On Tue, 2 May 2023 21:43:19 GMT, Ferenc Rakoczi wrote: >> Implement support for Leighton-Micali Signatures (LMS) as described in RFC >> 8554. LMS is an approved software signing algorithm for CNSA 2.0, with >> SHA-256/192 parameters recommended. > > Ferenc Rakoczi has updated the pull request i

Re: RFR: 8298127: HSS/LMS Signature Verification [v5]

2023-05-04 Thread Weijun Wang
On Tue, 2 May 2023 21:43:19 GMT, Ferenc Rakoczi wrote: >> Implement support for Leighton-Micali Signatures (LMS) as described in RFC >> 8554. LMS is an approved software signing algorithm for CNSA 2.0, with >> SHA-256/192 parameters recommended. > > Ferenc Rakoczi has updated the pull request i

Integrated: 8307489: ProblemList jdk/incubator/vector/LoadJsvmlTest.java on windows-x64

2023-05-04 Thread Daniel D . Daugherty
On Thu, 4 May 2023 20:49:26 GMT, Daniel D. Daugherty wrote: > Trivial fixes to ProblemList a few tests: > - [JDK-8307489](https://bugs.openjdk.org/browse/JDK-8307489) ProblemList > jdk/incubator/vector/LoadJsvmlTest.java on windows-x64 > - [JDK-8307490](https://bugs.openjdk.org/browse/JDK-830749

Re: RFR: 8307489: ProblemList jdk/incubator/vector/LoadJsvmlTest.java on windows-x64

2023-05-04 Thread Daniel D . Daugherty
On Thu, 4 May 2023 21:21:38 GMT, Joe Darcy wrote: >> Trivial fixes to ProblemList a few tests: >> - [JDK-8307489](https://bugs.openjdk.org/browse/JDK-8307489) ProblemList >> jdk/incubator/vector/LoadJsvmlTest.java on windows-x64 >> - [JDK-8307490](https://bugs.openjdk.org/browse/JDK-8307490) Pro

Re: RFR: 8307489: ProblemList jdk/incubator/vector/LoadJsvmlTest.java on windows-x64

2023-05-04 Thread Joe Darcy
On Thu, 4 May 2023 20:49:26 GMT, Daniel D. Daugherty wrote: > Trivial fixes to ProblemList a few tests: > - [JDK-8307489](https://bugs.openjdk.org/browse/JDK-8307489) ProblemList > jdk/incubator/vector/LoadJsvmlTest.java on windows-x64 > - [JDK-8307490](https://bugs.openjdk.org/browse/JDK-830749

RFR: 8307489: ProblemList jdk/incubator/vector/LoadJsvmlTest.java on windows-x64

2023-05-04 Thread Daniel D . Daugherty
Trivial fixes to ProblemList a few tests: - [JDK-8307489](https://bugs.openjdk.org/browse/JDK-8307489) ProblemList jdk/incubator/vector/LoadJsvmlTest.java on windows-x64 - [JDK-8307490](https://bugs.openjdk.org/browse/JDK-8307490) ProblemList sun/security/pkcs11/Cipher/TestKATForGCM.java on linux

Re: RFR: 8294983: SSLEngine throws ClassCastException during handshake [v4]

2023-05-04 Thread Kevin Driver
> Fixes a scenario where a `ServerHandshakeContext` might be cast as a > `ClientHandshakeContext`. Kevin Driver has updated the pull request incrementally with one additional commit since the last revision: added explanatory comment - Changes: - all: https://git.openjdk.org/jd

Re: RFR: 8250596: Update remaining manpage references from "OS X" to "macOS"

2023-05-04 Thread Chris Plummer
On Thu, 4 May 2023 15:50:02 GMT, Adam Sotona wrote: > Most of the manpages were updated a few years ago but some references remain. > This patch renames remaining references to "macOS". > > Please review. > > Thanks, > Adam The jstatd.1 and jstat.1 files look good. Copyrights need updating on

Integrated: 8294983: SSLEngine throws ClassCastException during handshake

2023-05-04 Thread Kevin Driver
On Fri, 28 Apr 2023 19:28:03 GMT, Kevin Driver wrote: > Fixes a scenario where a `ServerHandshakeContext` might be cast as a > `ClientHandshakeContext`. This pull request has now been integrated. Changeset: 197d0cc6 Author:Kevin Driver Committer: Bradford Wetmore URL: https://git.

Re: RFR: 8155191: SunPKCS11's SecureRandom#nextBytes(byte[]) accepts null argument

2023-05-04 Thread Valerie Peng
On Thu, 4 May 2023 12:59:21 GMT, Sean Mullan wrote: > I suggest the title of this issue should be changed to better reflect the > proposed change: "Specify that SecureRandom.nextBytes(byte[]) throws > NullPointerException when byte array is null". Ok. > Also, would you consider making the sam

Re: RFR: 8250596: Update remaining manpage references from "OS X" to "macOS"

2023-05-04 Thread Sean Mullan
On Thu, 4 May 2023 15:50:02 GMT, Adam Sotona wrote: > Most of the manpages were updated a few years ago but some references remain. > This patch renames remaining references to "macOS". > > Please review. > > Thanks, > Adam keytool and jarsigner docs look good. - Marked as review

Re: RFR: 8301154: SunPKCS11 KeyStore deleteEntry results in dangling PrivateKey entries

2023-05-04 Thread Hai-May Chao
On Mon, 1 May 2023 19:49:05 GMT, Valerie Peng wrote: > Could someone help review this PKCS11KeyStore fix regarding the cert chain > removal? > > The proposed fix will not remove the cert if it has a corresponding private > key or is an issuer of other entities in the same keystore. > > Thanks

RFR: 8250596: Update remaining manpage references from "OS X" to "macOS"

2023-05-04 Thread Adam Sotona
Most of the manpages were updated a few years ago but some references remain. This patch renames remaining references to "macOS". Please review. Thanks, Adam - Commit messages: - 8250596: Update remaining manpage references from "OS X" to "macOS" Changes: https://git.openjdk.org/j

Re: RFR: 8168469: Memory leak in JceSecurity

2023-05-04 Thread Sergey Chernyshev
On Tue, 25 Apr 2023 21:16:41 GMT, Sergey Chernyshev wrote: > Hi all, > > I would like to propose a patch for an issue discussed in [1][2] that fixes > an OOME in the current code base. The issue appears when a SunJCE provider > object reference is stored in a non-static variable, which eventua

Re: RFR: 8155191: SunPKCS11's SecureRandom#nextBytes(byte[]) accepts null argument

2023-05-04 Thread Sean Mullan
On Thu, 4 May 2023 01:58:42 GMT, Valerie Peng wrote: > Just a trivial change for enforcing consistent NullPointerException behavior > for the SecureRandom.nextBytes(byte[]) method. > > Other similar methods such as Random.nextByte(byte[]) and its other > subclasses all throw NPE for null byte[