Re: RFR: 8297878: KEM: Implementation [v8]

2023-04-25 Thread Weijun Wang
> The KEM API and DHKEM impl. Note that this PR uses new methods in > https://github.com/openjdk/jdk/pull/13250. Weijun Wang has updated the pull request incrementally with one additional commit since the last revision: some constants, no local reverse - Changes: - all: https:

RFR: 8302182: Update Public Suffix List to 88467c9

2023-04-25 Thread Weijun Wang
Update PSL for JDK 21. - Commit messages: - the upgrade Changes: https://git.openjdk.org/jdk/pull/13662/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=13662&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8302182 Stats: 1479 lines in 5 files changed: 647 ins; 697 de

Re: RFR: JDK-8287061: Support for rematerializing scalar replaced objects participating in allocation merges [v10]

2023-04-25 Thread Cesar Soares Lucas
On Tue, 25 Apr 2023 21:19:06 GMT, Vladimir Ivanov wrote: >> @iwanowww - may I ask why always allocating a fresh object might be better >> than returning a pointer to a previous "selected" object? > > I don't mind there's caching happening if it gives any noticeable benefit. As > of now, the cod

RFR: 8168469: Memory leak in JceSecurity

2023-04-25 Thread Sergey Chernyshev
Hi all, I would like to propose a patch for an issue discussed in [1][2] that fixes an OOME in the current code base. The issue appears when a SunJCE provider object reference is stored in a non-static variable, which eventually leads to a Java heap OOME. The solution proposed earlier [1] rais

Re: RFR: JDK-8287061: Support for rematerializing scalar replaced objects participating in allocation merges [v10]

2023-04-25 Thread Vladimir Ivanov
On Tue, 25 Apr 2023 00:10:53 GMT, Cesar Soares Lucas wrote: >> src/hotspot/share/code/debugInfo.cpp line 257: >> >>> 255: } else { >>> 256: assert(selector < _possible_objects.length(), "sanity"); >>> 257: _selected = (ObjectValue*) _possible_objects.at(selector); >> >> Any particula

Integrated: 8304845: Update PCSC-Lite for Suse Linux to 1.9.9 and fix incomplete license wording

2023-04-25 Thread Valerie Peng
On Mon, 10 Apr 2023 16:56:04 GMT, Valerie Peng wrote: > Could someone please help review this fix? Besides updating the md and > COPYING files to address the incomplete license issue, this PR also updates > the version to 1.9.9. This pull request has now been integrated. Changeset: 33d66141 A

Re: RFR: 8304845: Update PCSC-Lite for Suse Linux to 1.9.9 and fix incomplete license wording [v2]

2023-04-25 Thread Valerie Peng
On Tue, 25 Apr 2023 14:13:29 GMT, Sean Mullan wrote: > For the JBS issue, I suggest using a different `noreg` tag than `noreg-doc` > since technically there is source code (`psclite.h`) that has been changed. > Perhaps `noreg-trivial` or `noreg-other`. Otherwise, looks good. Makes sense, will

Integrated: 8306772: Remove sun.security.x509.CertException, sun.security.x509.CertParseError

2023-04-25 Thread Eirik Bjorsnos
On Mon, 24 Apr 2023 18:42:50 GMT, Eirik Bjorsnos wrote: > Please review this patch which removes the classes > `sun.security.x509.CertException` and `sun.security.x509.CertParseError`. > > These classes have been deprecated since before OpenJDK. They are internal > classes which are not suppor

Re: RFR: 8306772: Remove sun.security.x509.CertException, sun.security.x509.CertParseError

2023-04-25 Thread Eirik Bjorsnos
On Tue, 25 Apr 2023 15:58:30 GMT, Sean Mullan wrote: > Add a `noreg` label to the issue. Otherwise, LGTM. Added "noreg-cleanup" with an small justification in the description. - PR Comment: https://git.openjdk.org/jdk/pull/13624#issuecomment-1522058524

Re: RFR: 8306772: Remove sun.security.x509.CertException, sun.security.x509.CertParseError

2023-04-25 Thread Sean Mullan
On Mon, 24 Apr 2023 18:42:50 GMT, Eirik Bjorsnos wrote: > Please review this patch which removes the classes > `sun.security.x509.CertException` and `sun.security.x509.CertParseError`. > > These classes have been deprecated since before OpenJDK. They are internal > classes which are not suppor

Re: RFR: 8304845: Update PCSC-Lite for Suse Linux to 1.9.9 and fix incomplete license wording [v2]

2023-04-25 Thread Sean Mullan
On Wed, 12 Apr 2023 18:39:40 GMT, Valerie Peng wrote: >> Could someone please help review this fix? Besides updating the md and >> COPYING files to address the incomplete license issue, this PR also updates >> the version to 1.9.9. > > Valerie Peng has updated the pull request incrementally wit