Re: RFR: JDK-8287061: Support for rematerializing scalar replaced objects participating in allocation merges [v10]

2023-04-21 Thread Vladimir Ivanov
On Thu, 20 Apr 2023 19:27:58 GMT, Cesar Soares Lucas wrote: >> Can I please get reviews for this PR? >> >> The most common and frequent use of NonEscaping Phis merging object >> allocations is for debugging information. The two graphs below show numbers >> for Renaissance and DaCapo benchmar

Re: Should deprecated classes CertException, CertParseError be marked forRemoval=true?

2023-04-21 Thread Eirik Bjørsnøs
> > JDK-8157707 [1] deprecated the java.security.Certificate API. In a comment > in that issue, Sean writes: > Sorry, I meant to say that java.security.Certificate was marked forRemoval=true in JDK-8157707, it was of course deprecated long before that. Eirik.

Re: RFR: JDK-8287061: Support for rematerializing scalar replaced objects participating in allocation merges [v5]

2023-04-21 Thread Xin Liu
On Fri, 14 Apr 2023 20:50:03 GMT, Cesar Soares Lucas wrote: >> src/hotspot/share/opto/escape.cpp line 457: >> >>> 455: found_sr_allocate = true; >>> 456: } else { >>> 457: ptn->set_scalar_replaceable(false); >> >> This member function is const. Do we really need to change

Should deprecated classes CertException, CertParseError be marked forRemoval=true?

2023-04-21 Thread Eirik Bjørsnøs
Hi, JDK-8157707 [1] deprecated the java.security.Certificate API. In a comment in that issue, Sean writes: As part of this change, the internal classes > sun.security.x509.CertException and sun.security.x509.CertParseError should > be marked for removal (they are already deprecated) and removed w

Re: RFR: JDK-8287061: Support for rematerializing scalar replaced objects participating in allocation merges [v9]

2023-04-21 Thread Vladimir Kozlov
On Fri, 21 Apr 2023 15:08:21 GMT, Cesar Soares Lucas wrote: > Since only the tests added in this PR are failing due to that problem do you > think I should create a separate PR to fix the Regex or just include the fix > in this PR? Create separate PR and fix it first. This PR still need revie

Re: RFR: JDK-8287061: Support for rematerializing scalar replaced objects participating in allocation merges [v9]

2023-04-21 Thread Cesar Soares Lucas
On Thu, 20 Apr 2023 00:35:19 GMT, Vladimir Kozlov wrote: > Again got failures in the test on Aarch64 running with -XX:-UseTLAB: > > ``` > testCmpMergeWithNull(boolean,int,int): > - Failed comparison: [found] 0 = 2 [given] > testCmpMergeWithNull_Second(boolean,int,int) > - Failed comparison: [fou

Re: Status: JDK-8191136 Remove deprecated java.security.{Certificate, Identity, IdentityScope, Signer} APIs

2023-04-21 Thread Alan Bateman
On 21/04/2023 09:11, Eirik Bjørsnøs wrote: : Based on these observations, it seems running the TCK on a JRE without java.security.Identity should either be a non-issue, or it should require relatively small efforts to allow the TCK to run on such JREs. I don't have access to the Java EE CTS

Re: Status: JDK-8191136 Remove deprecated java.security.{Certificate, Identity, IdentityScope, Signer} APIs

2023-04-21 Thread Eirik Bjørsnøs
> > Given that removing these APIs would cause TCK issues in these cases, I > have been reticent to remove the APIs. > To assess TCK impact, I downloaded jakarta-jakartaeetck-8.0.2.zip [1] and did a grep for getCallerIdentity: % grep -R getCallerIdentity . > ./src/com/sun/ts/tests/signaturetest/s