Re: RFR: JDK-8287061: Support for rematerializing scalar replaced objects participating in allocation merges [v4]

2023-03-24 Thread Cesar Soares Lucas
On Mon, 20 Mar 2023 19:23:34 GMT, Cesar Soares Lucas wrote: >> Can I please get reviews for this PR? >> >> The most common and frequent use of NonEscaping Phis merging object >> allocations is for debugging information. The two graphs below show numbers >> for Renaissance and DaCapo benchmar

Re: RFR: JDK-8287061: Support for rematerializing scalar replaced objects participating in allocation merges [v4]

2023-03-24 Thread Vladimir Kozlov
On Fri, 24 Mar 2023 23:57:07 GMT, Cesar Soares Lucas wrote: >> src/hotspot/share/opto/callnode.hpp line 511: >> >>> 509: // by a SafePoint; 2) A scalar replaced object is participating in an >>> allocation >>> 510: // merge (Phi) and the Phi is referenced by a SafePoint. The >>> schematics of

Re: RFR: JDK-8287061: Support for rematerializing scalar replaced objects participating in allocation merges [v4]

2023-03-24 Thread Cesar Soares Lucas
On Fri, 24 Mar 2023 19:02:57 GMT, Vladimir Kozlov wrote: >> Cesar Soares Lucas has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Add support for SR'ing some inputs of merges used for field loads > > src/hotspot/share/code/debugInfo.hpp lin

Re: RFR: JDK-8287061: Support for rematerializing scalar replaced objects participating in allocation merges [v4]

2023-03-24 Thread Cesar Soares Lucas
On Fri, 24 Mar 2023 19:53:52 GMT, Xin Liu wrote: >> Cesar Soares Lucas has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Add support for SR'ing some inputs of merges used for field loads > > src/hotspot/share/opto/callnode.hpp line 614: >

Re: RFR: JDK-8287061: Support for rematerializing scalar replaced objects participating in allocation merges [v4]

2023-03-24 Thread Vladimir Kozlov
On Fri, 24 Mar 2023 23:24:47 GMT, Cesar Soares Lucas wrote: >> src/hotspot/share/opto/macro.hpp line 196: >> >>> 194: Node* size_in_bytes); >>> 195: >>> 196: static Node* make_arraycopy_load(Compile* comp, PhaseIterGVN* igvn, >>> ArrayCopyNode* ac, intptr_t offset,

Re: RFR: JDK-8287061: Support for rematerializing scalar replaced objects participating in allocation merges [v4]

2023-03-24 Thread Cesar Soares Lucas
On Fri, 24 Mar 2023 19:06:18 GMT, Vladimir Kozlov wrote: >> Cesar Soares Lucas has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Add support for SR'ing some inputs of merges used for field loads > > src/hotspot/share/opto/callnode.cpp line

Re: RFR: 8304846: Provide a shared utility to dump generated classes defined via Lookup API [v2]

2023-03-24 Thread Mandy Chung
> This implements a shared utility to dump generated classes defined as > normal/hidden classes via `Lookup` API. This replaces the implementation in > `LambdaMetaFactory` and method handle implementation that dumps the hidden > class bytes on disk for debugging. > > For classes defined vi

Re: RFR: 8304846: Provide a shared utility to dump generated classes defined via Lookup API [v2]

2023-03-24 Thread Mandy Chung
On Fri, 24 Mar 2023 20:54:25 GMT, Chen Liang wrote: >> Mandy Chung has updated the pull request incrementally with one additional >> commit since the last revision: >> >> avoid another map lookup > > src/java.base/share/classes/java/lang/invoke/ClassFileDumper.java line 88: > >> 86:

Re: RFR: 8304846: Provide a shared utility to dump generated classes defined via Lookup API

2023-03-24 Thread Chen Liang
On Fri, 24 Mar 2023 20:41:41 GMT, Mandy Chung wrote: > This implements a shared utility to dump generated classes defined as > normal/hidden classes via `Lookup` API. This replaces the implementation in > `LambdaMetaFactory` and method handle implementation that dumps the hidden > class byte

RFR: 8304846: Provide a shared utility to dump generated classes defined via Lookup API

2023-03-24 Thread Mandy Chung
This implements a shared utility to dump generated classes defined as normal/hidden classes via `Lookup` API. This replaces the implementation in `LambdaMetaFactory` and method handle implementation that dumps the hidden class bytes on disk for debugging. For classes defined via `Lookup::d

Re: RFR: JDK-8287061: Support for rematerializing scalar replaced objects participating in allocation merges [v4]

2023-03-24 Thread Xin Liu
On Mon, 20 Mar 2023 19:23:34 GMT, Cesar Soares Lucas wrote: >> Can I please get reviews for this PR? >> >> The most common and frequent use of NonEscaping Phis merging object >> allocations is for debugging information. The two graphs below show numbers >> for Renaissance and DaCapo benchmar

Re: RFR: JDK-8287061: Support for rematerializing scalar replaced objects participating in allocation merges [v4]

2023-03-24 Thread Vladimir Kozlov
On Mon, 20 Mar 2023 19:23:34 GMT, Cesar Soares Lucas wrote: >> Can I please get reviews for this PR? >> >> The most common and frequent use of NonEscaping Phis merging object >> allocations is for debugging information. The two graphs below show numbers >> for Renaissance and DaCapo benchmar

Re: RFR: 8304136: Match allocation and free in sspi.cpp

2023-03-24 Thread Weijun Wang
On Tue, 14 Mar 2023 20:10:08 GMT, Daniel JeliƄski wrote: >> After this change, `gss_buffer_t` always uses `malloc` and `free`. All >> others use `new` and `delete`. It also initializes several `SecBuffer` to >> zeroes so it's safe to check for null when trying to free them. > > LGTM. Thanks! C

Integrated: 8304136: Match allocation and free in sspi.cpp

2023-03-24 Thread Weijun Wang
On Tue, 14 Mar 2023 14:02:43 GMT, Weijun Wang wrote: > After this change, `gss_buffer_t` always uses `malloc` and `free`. All others > use `new` and `delete`. It also initializes several `SecBuffer` to zeroes so > it's safe to check for null when trying to free them. This pull request has now

Re: Update to JEP draft: Key Encapsulation Mechanism API

2023-03-24 Thread Wei-Jun Wang
Hi All, The JEP draft was just updated again. The KEMParameterSpec argument is moved from getInstance() to newEncapsulator() and newDecapsulator(). The reason is that when delayed provider selection happens, a KEMSpi object is only created when newEncapsulator/newDecapsulator is called. If the

Re: RFR: 8302017: Allocate BadPaddingException only if it will be thrown

2023-03-24 Thread Xue-Lei Andrew Fan
On Tue, 14 Mar 2023 21:58:46 GMT, Xue-Lei Andrew Fan wrote: >> May I get a chance to review it before the integration? I may need more >> time to dig into time-constant issue. > >> May I get a chance to review it before the integration? I may need more time >> to dig into time-constant issue.

Re: RFR: JDK-8287061: Support for rematerializing scalar replaced objects participating in allocation merges [v4]

2023-03-24 Thread Vladimir Kozlov
On Mon, 20 Mar 2023 19:23:34 GMT, Cesar Soares Lucas wrote: >> Can I please get reviews for this PR? >> >> The most common and frequent use of NonEscaping Phis merging object >> allocations is for debugging information. The two graphs below show numbers >> for Renaissance and DaCapo benchmar

Re: RFR: JDK-8287061: Support for rematerializing scalar replaced objects participating in allocation merges [v4]

2023-03-24 Thread Vladimir Kozlov
On Mon, 20 Mar 2023 19:23:34 GMT, Cesar Soares Lucas wrote: >> Can I please get reviews for this PR? >> >> The most common and frequent use of NonEscaping Phis merging object >> allocations is for debugging information. The two graphs below show numbers >> for Renaissance and DaCapo benchmar