Re: RFR: 8301553: Support Password-Based Cryptography in SunPKCS11

2023-03-13 Thread Valerie Peng
On Fri, 3 Feb 2023 01:41:41 GMT, Martin Balao wrote: > We would like to propose an implementation for the [JDK-8301553: Support > Password-Based Cryptography in > SunPKCS11](https://bugs.openjdk.org/browse/JDK-8301553) enhancement > requirement. > > In addition to pursuing the requirement goa

Re: RFR: 8303809: Dispose context in SPNEGO NegotiatorImpl [v4]

2023-03-13 Thread Weijun Wang
On Mon, 13 Mar 2023 17:33:12 GMT, Alexey Bakhtin wrote: >> This patch fixes a possible native memory leak in case of a custom native >> GSS provider. >> The actual leak was reported in production. >> >> sun/security/jgss, sun/security/krb5, sun/net/www/protocol/http jtreg tests >> are passed >

Re: RFR: 8301553: Support Password-Based Cryptography in SunPKCS11

2023-03-13 Thread Valerie Peng
On Fri, 3 Feb 2023 01:41:41 GMT, Martin Balao wrote: > We would like to propose an implementation for the [JDK-8301553: Support > Password-Based Cryptography in > SunPKCS11](https://bugs.openjdk.org/browse/JDK-8301553) enhancement > requirement. > > In addition to pursuing the requirement goa

Re: RFR: 8303809: Dispose context in SPNEGO NegotiatorImpl [v4]

2023-03-13 Thread Alexey Bakhtin
> This patch fixes a possible native memory leak in case of a custom native GSS > provider. > The actual leak was reported in production. > > sun/security/jgss, sun/security/krb5, sun/net/www/protocol/http jtreg tests > are passed Alexey Bakhtin has updated the pull request incrementally with o

Re: RFR: 8303809: Dispose context in SPNEGO NegotiatorImpl [v2]

2023-03-13 Thread Alexey Bakhtin
On Mon, 13 Mar 2023 16:02:10 GMT, Weijun Wang wrote: >> Alexey Bakhtin has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix formatting > > src/java.base/share/classes/sun/net/www/protocol/http/NegotiateAuthentication.java > line 254: >

Re: RFR: 8303809: Dispose context in SPNEGO NegotiatorImpl [v3]

2023-03-13 Thread Alexey Bakhtin
> This patch fixes a possible native memory leak in case of a custom native GSS > provider. > The actual leak was reported in production. > > sun/security/jgss, sun/security/krb5, sun/net/www/protocol/http jtreg tests > are passed Alexey Bakhtin has updated the pull request incrementally with o

Re: RFR: 8303809: Dispose context in SPNEGO NegotiatorImpl [v2]

2023-03-13 Thread Weijun Wang
On Fri, 10 Mar 2023 16:22:56 GMT, Alexey Bakhtin wrote: >> This patch fixes a possible native memory leak in case of a custom native >> GSS provider. >> The actual leak was reported in production. >> >> sun/security/jgss, sun/security/krb5, sun/net/www/protocol/http jtreg tests >> are passed >

Withdrawn: 8303832: Use enhanced-for cycle instead of Enumeration in JceKeyStore

2023-03-13 Thread Andrey Turbanov
On Wed, 8 Mar 2023 19:10:11 GMT, Andrey Turbanov wrote: > java.util.Enumeration is a legacy interface from java 1.0. > There is couple of places with cycles which use it to iterate over > collections. We can replace this manual cycle with enchanced-for, which is > shorter and easier to read. T