Re: RFR: 8301553: Support Password-Based Cryptography in SunPKCS11

2023-03-09 Thread Valerie Peng
On Fri, 3 Feb 2023 01:41:41 GMT, Martin Balao wrote: > We would like to propose an implementation for the [JDK-8301553: Support > Password-Based Cryptography in > SunPKCS11](https://bugs.openjdk.org/browse/JDK-8301553) enhancement > requirement. > > In addition to pursuing the requirement goa

Re: RFR: 8296400: pointCrlIssuers might be null in DistributionPointFetcher::verifyURL [v2]

2023-03-09 Thread Weijun Wang
On Thu, 9 Mar 2023 20:53:44 GMT, Matthew Donovan wrote: >> Added null-checks for pointCrlIssuers before it is accessed. > > Matthew Donovan has updated the pull request incrementally with one > additional commit since the last revision: > > fixed indentation Looks good. You might need to add

Re: RFR: 8296400: pointCrlIssuers might be null in DistributionPointFetcher::verifyURL [v2]

2023-03-09 Thread Matthew Donovan
> Added null-checks for pointCrlIssuers before it is accessed. Matthew Donovan has updated the pull request incrementally with one additional commit since the last revision: fixed indentation - Changes: - all: https://git.openjdk.org/jdk/pull/12866/files - new: https://git.op

Re: RFR: 8303410: Remove ContentSigner APIs and jarsigner -altsigner and -altsignerpath options [v4]

2023-03-09 Thread Eirik Bjorsnos
On Thu, 9 Mar 2023 18:50:42 GMT, Eirik Bjorsnos wrote: >> The `-altsigner` and `-altsignerpath` options in JarSigner with the >> underlying `ContentSigner` mechanism were deprected in Java 9, for removal >> in Java 15. See [JDK-8076535](https://bugs.openjdk.org/browse/JDK-8076535), >> [JDK-824

Re: RFR: 8296400: pointCrlIssuers might be null in DistributionPointFetcher::verifyURL

2023-03-09 Thread Weijun Wang
On Fri, 3 Mar 2023 19:45:22 GMT, Matthew Donovan wrote: > Added null-checks for pointCrlIssuers before it is accessed. src/java.base/share/classes/sun/security/provider/certpath/DistributionPointFetcher.java line 485: > 483: // cannot all be missing from a certificate. > 48

Re: RFR: 8303410: Remove ContentSigner APIs and jarsigner -altsigner and -altsignerpath options [v4]

2023-03-09 Thread Weijun Wang
On Thu, 9 Mar 2023 18:50:42 GMT, Eirik Bjorsnos wrote: >> The `-altsigner` and `-altsignerpath` options in JarSigner with the >> underlying `ContentSigner` mechanism were deprected in Java 9, for removal >> in Java 15. See [JDK-8076535](https://bugs.openjdk.org/browse/JDK-8076535), >> [JDK-824

Re: RFR: 8303410: Remove ContentSigner APIs and jarsigner -altsigner and -altsignerpath options [v3]

2023-03-09 Thread Eirik Bjorsnos
On Thu, 9 Mar 2023 17:24:39 GMT, Eirik Bjorsnos wrote: >> The `-altsigner` and `-altsignerpath` options in JarSigner with the >> underlying `ContentSigner` mechanism were deprected in Java 9, for removal >> in Java 15. See [JDK-8076535](https://bugs.openjdk.org/browse/JDK-8076535), >> [JDK-824

Re: RFR: 8303410: Remove ContentSigner APIs and jarsigner -altsigner and -altsignerpath options [v4]

2023-03-09 Thread Eirik Bjorsnos
> The `-altsigner` and `-altsignerpath` options in JarSigner with the > underlying `ContentSigner` mechanism were deprected in Java 9, for removal in > Java 15. See [JDK-8076535](https://bugs.openjdk.org/browse/JDK-8076535), > [JDK-8242260](https://bugs.openjdk.org/browse/JDK-8242260). > > This

Re: RFR: 8303410: Remove ContentSigner APIs and jarsigner -altsigner and -altsignerpath options [v3]

2023-03-09 Thread Weijun Wang
On Thu, 9 Mar 2023 17:24:39 GMT, Eirik Bjorsnos wrote: >> The `-altsigner` and `-altsignerpath` options in JarSigner with the >> underlying `ContentSigner` mechanism were deprected in Java 9, for removal >> in Java 15. See [JDK-8076535](https://bugs.openjdk.org/browse/JDK-8076535), >> [JDK-824

Re: RFR: 8303410: Remove ContentSigner APIs and jarsigner -altsigner and -altsignerpath options [v3]

2023-03-09 Thread Weijun Wang
On Thu, 9 Mar 2023 17:24:39 GMT, Eirik Bjorsnos wrote: >> The `-altsigner` and `-altsignerpath` options in JarSigner with the >> underlying `ContentSigner` mechanism were deprected in Java 9, for removal >> in Java 15. See [JDK-8076535](https://bugs.openjdk.org/browse/JDK-8076535), >> [JDK-824

Re: RFR: 8303410: Remove ContentSigner APIs and jarsigner -altsigner and -altsignerpath options [v2]

2023-03-09 Thread Eirik Bjorsnos
On Thu, 9 Mar 2023 16:41:31 GMT, Weijun Wang wrote: > `src/jdk.jartool/share/classes/module-info.java` and `test/jdk/TEST.groups` > still reference `com.sun.jarsigner`. Well spotted, I have removed these references. I'm assuming the references in the jdk.compiler symbol tables will be updated

Re: RFR: 8303410: Remove ContentSigner APIs and jarsigner -altsigner and -altsignerpath options [v3]

2023-03-09 Thread Eirik Bjorsnos
The message from this sender included one or more files which could not be scanned for virus detection; do not open these files unless you are certain of the sender's intent. -- > The `-altsigner` and `-altsignerpath` options in J

Re: RFR: 8303410: Remove ContentSigner APIs and jarsigner -altsigner and -altsignerpath options [v2]

2023-03-09 Thread Weijun Wang
On Mon, 6 Mar 2023 19:02:02 GMT, Eirik Bjorsnos wrote: >> The `-altsigner` and `-altsignerpath` options in JarSigner with the >> underlying `ContentSigner` mechanism were deprected in Java 9, for removal >> in Java 15. See [JDK-8076535](https://bugs.openjdk.org/browse/JDK-8076535), >> [JDK-824

Re: RFR: 8303832: Use enhanced-for cycle instead of Enumeration in JceKeyStore

2023-03-09 Thread Sean Mullan
On Thu, 9 Mar 2023 00:14:33 GMT, Weijun Wang wrote: >> java.util.Enumeration is a legacy interface from java 1.0. >> There is couple of places with cycles which use it to iterate over >> collections. We can replace this manual cycle with enchanced-for, which is >> shorter and easier to read. >

Re: RFR: 8303809: Dispose context in SPNEGO NegotiatorImpl

2023-03-09 Thread Alexey Bakhtin
On Wed, 8 Mar 2023 09:05:19 GMT, Alexey Bakhtin wrote: > This patch fixes a possible native memory leak in case of a custom native GSS > provider. > The actual leak was reported in production. > > sun/security/jgss, sun/security/krb5, sun/net/www/protocol/http jtreg tests > are passed Unfortu

Re: RFR: 8303764: Turn off -Zc:wchar_t- for Visual C++ [v4]

2023-03-09 Thread Julian Waters
The message from this sender included one or more files which could not be scanned for virus detection; do not open these files unless you are certain of the sender's intent. -- > Was: sunmscapi.dll cannot compile with Visual C++

Re: RFR: 8303809: Dispose context in SPNEGO NegotiatorImpl

2023-03-09 Thread Weijun Wang
On Wed, 8 Mar 2023 09:05:19 GMT, Alexey Bakhtin wrote: > This patch fixes a possible native memory leak in case of a custom native GSS > provider. > The actual leak was reported in production. > > sun/security/jgss, sun/security/krb5, sun/net/www/protocol/http jtreg tests > are passed If cont

Re: RFR: 8303809: Dispose context in SPNEGO NegotiatorImpl

2023-03-09 Thread Weijun Wang
On Thu, 9 Mar 2023 08:21:15 GMT, Alexey Bakhtin wrote: >> This patch fixes a possible native memory leak in case of a custom native >> GSS provider. >> The actual leak was reported in production. >> >> sun/security/jgss, sun/security/krb5, sun/net/www/protocol/http jtreg tests >> are passed >

Re: RFR: 8303809: Dispose context in SPNEGO NegotiatorImpl

2023-03-09 Thread Daniel Jeliński
On Thu, 9 Mar 2023 08:21:15 GMT, Alexey Bakhtin wrote: >> This patch fixes a possible native memory leak in case of a custom native >> GSS provider. >> The actual leak was reported in production. >> >> sun/security/jgss, sun/security/krb5, sun/net/www/protocol/http jtreg tests >> are passed >

Re: RFR: 8303764: Turn off -Zc:wchar_t- for Visual C++ [v3]

2023-03-09 Thread Julian Waters
The message from this sender included one or more files which could not be scanned for virus detection; do not open these files unless you are certain of the sender's intent. -- On Thu, 9 Mar 2023 12:00:55 GMT, Daniel Jeliński wr

Re: RFR: 8303764: Turn off -Zc:wchar_t- for Visual C++ [v3]

2023-03-09 Thread Daniel Jeliński
On Thu, 9 Mar 2023 11:35:22 GMT, Julian Waters wrote: >> Was: sunmscapi.dll cannot compile with Visual C++ >> >> `-Zc:wchar_t-` has, until now, been passed to switch off wchar_t as a >> distinct C++ type when compiling with Visual C++ so jchar and wchar_t are >> typedef'd to shorts on Windows.

Re: RFR: 8303764: Turn off -Zc:wchar_t- for Visual C++ [v3]

2023-03-09 Thread Julian Waters
> Was: sunmscapi.dll cannot compile with Visual C++ > > `-Zc:wchar_t-` has, until now, been passed to switch off wchar_t as a > distinct C++ type when compiling with Visual C++ so jchar and wchar_t are > typedef'd to shorts on Windows. After some examination it appears this flag > is not actual

Re: RFR: 8303764: Turn off -Zc:wchar_t- for Visual C++ [v2]

2023-03-09 Thread Julian Waters
> security.cpp contains a few invalid implicit conversions between pointer > types that will not fly when the permissive- compiler option is active. Given > that permissive- will become the Visual C++ compiler's default mode of > operation in the future, it is better to handle this now so future

Re: RFR: 8303764: Turn off -Zc:wchar_t- for Visual C++

2023-03-09 Thread Julian Waters
On Tue, 7 Mar 2023 17:27:56 GMT, Julian Waters wrote: > security.cpp contains a few invalid implicit conversions between pointer > types that will not fly when the permissive- compiler option is active. Given > that permissive- will become the Visual C++ compiler's default mode of > operation

Re: RFR: 8303764: sunmscapi.dll cannot compile under permissive-

2023-03-09 Thread Julian Waters
The message from this sender included one or more files which could not be scanned for virus detection; do not open these files unless you are certain of the sender's intent. -- On Tue, 7 Mar 2023 17:27:56 GMT, Julian Waters wrot

Re: RFR: 8303764: sunmscapi.dll cannot compile under permissive-

2023-03-09 Thread Daniel Jeliński
The message from this sender included one or more files which could not be scanned for virus detection; do not open these files unless you are certain of the sender's intent. -- On Tue, 7 Mar 2023 17:27:56 GMT, Julian Waters wrot

Re: RFR: 8303809: Dispose context in SPNEGO NegotiatorImpl

2023-03-09 Thread Alexey Bakhtin
On Wed, 8 Mar 2023 12:29:55 GMT, Daniel Fuchs wrote: >> This patch fixes a possible native memory leak in case of a custom native >> GSS provider. >> The actual leak was reported in production. >> >> sun/security/jgss, sun/security/krb5, sun/net/www/protocol/http jtreg tests >> are passed > >

Integrated: JDK-8303576: addIdentitiesToKeystore in KeystoreImpl.m needs CFRelease call in early potential CHECK_NULL return

2023-03-09 Thread Matthias Baesken
The message from this sender included one or more files which could not be scanned for virus detection; do not open these files unless you are certain of the sender's intent. -- On Tue, 7 Mar 2023 15:56:55 GMT, Matthias Baesken w

Re: RFR: 8303764: sunmscapi.dll cannot compile under permissive-

2023-03-09 Thread Julian Waters
On Wed, 8 Mar 2023 14:46:55 GMT, Daniel Jeliński wrote: >> permissive- is a pretty big problem for Windows code in general, in >> particular our very jint and jlong typedefs themselves on Windows are >> completely broken on Windows and compiling with permissive- will straight up >> make the en

Re: RFR: 8303809: Dispose context in SPNEGO NegotiatorImpl

2023-03-09 Thread Alexey Bakhtin
On Wed, 8 Mar 2023 12:24:51 GMT, Daniel Fuchs wrote: >> This patch fixes a possible native memory leak in case of a custom native >> GSS provider. >> The actual leak was reported in production. >> >> sun/security/jgss, sun/security/krb5, sun/net/www/protocol/http jtreg tests >> are passed > >

Re: RFR: 8303809: Dispose context in SPNEGO NegotiatorImpl

2023-03-09 Thread Alexey Bakhtin
On Wed, 8 Mar 2023 09:05:19 GMT, Alexey Bakhtin wrote: > This patch fixes a possible native memory leak in case of a custom native GSS > provider. > The actual leak was reported in production. > > sun/security/jgss, sun/security/krb5, sun/net/www/protocol/http jtreg tests > are passed @dfunch