On Mon, 6 Mar 2023 21:27:07 GMT, Mat Carter wrote:
> Use the correct API for freeing key handles when directed to by the output of
> CryptAcquireCertificatePrivateKey [1].
> Specifically when [out] pfCallerFreeProvOrNCryptKey is true we test [out]
> pdwKeySpec for the CERT_NCRYPT_KEY_SPEC flag.
On Mon, 6 Mar 2023 21:27:07 GMT, Mat Carter wrote:
> Use the correct API for freeing key handles when directed to by the output of
> CryptAcquireCertificatePrivateKey [1].
> Specifically when [out] pfCallerFreeProvOrNCryptKey is true we test [out]
> pdwKeySpec for the CERT_NCRYPT_KEY_SPEC flag.
Can I please get reviews for this PR to add support for the rematerialization
of scalar-replaced objects that participate in allocation merges?
The most common and frequent use of NonEscaping Phis merging object allocations
is for debugging information. The two graphs below show numbers for Rena
Weijun,
Would you be so kind as to review and sponsor this change for me given that you
are familiar with my previous changes [1] (although this issue existed prior)
Once this is in tip, I'll look to backport to 19, 17 and 11
Thanks in advance
Mat
[1] https://bugs.openjdk.org/browse/JDK-828485
The message from this sender included one or more files
which could not be scanned for virus detection; do not
open these files unless you are certain of the sender's intent.
--
Use the correct API for freeing key handles when dir
On Mon, 6 Mar 2023 20:22:48 GMT, Pavel Rappo wrote:
>> Please review this superficial documentation cleanup that was triggered by
>> unrelated analysis of doc comments in JDK API.
>>
>> The only effect that this multi-area PR has on the JDK API Documentation
>> (i.e. the observable effect on t
On Mon, 6 Mar 2023 20:22:48 GMT, Pavel Rappo wrote:
>> Please review this superficial documentation cleanup that was triggered by
>> unrelated analysis of doc comments in JDK API.
>>
>> The only effect that this multi-area PR has on the JDK API Documentation
>> (i.e. the observable effect on t
The message from this sender included one or more files
which could not be scanned for virus detection; do not
open these files unless you are certain of the sender's intent.
--
On Mon, 6 Mar 2023 20:22:48 GMT, Pavel Rappo wrote:
On Fri, 3 Mar 2023 11:31:04 GMT, Alexey Ivanov wrote:
>> Yes, iff means if-and-only-if and is used for extra precision in formal
>> logic, mathematics. As @pavelrappo points out it's a relatively common
>> occurrence in the OpenJDK sources, though perhaps not in the public
>> javadocs. Perhaps
> Please review this superficial documentation cleanup that was triggered by
> unrelated analysis of doc comments in JDK API.
>
> The only effect that this multi-area PR has on the JDK API Documentation
> (i.e. the observable effect on the generated HTML pages) can be summarized as
> follows:
>
On Mon, 6 Mar 2023 18:52:52 GMT, Weijun Wang wrote:
> BTW, you don't need to touch `jarsigner.1`. It is auto-generated and another
> team maintains the source.
Thanks, I was not aware. I have reverted the changes to this file and trust it
will be updated through some other channel.
--
> The `-altsigner` and `-altsignerpath` options in JarSigner with the
> underlying `ContentSigner` mechanism were deprected in Java 9, for removal in
> Java 15. See [JDK-8076535](https://bugs.openjdk.org/browse/JDK-8076535),
> [JDK-8242260](https://bugs.openjdk.org/browse/JDK-8242260).
>
> This
On Tue, 28 Feb 2023 19:09:00 GMT, Eirik Bjorsnos wrote:
> The `-altsigner` and `-altsignerpath` options in JarSigner with the
> underlying `ContentSigner` mechanism were deprected in Java 9, for removal in
> Java 15. See [JDK-8076535](https://bugs.openjdk.org/browse/JDK-8076535),
> [JDK-824226
On Tue, 28 Feb 2023 19:09:00 GMT, Eirik Bjorsnos wrote:
> The `-altsigner` and `-altsignerpath` options in JarSigner with the
> underlying `ContentSigner` mechanism were deprected in Java 9, for removal in
> Java 15. See [JDK-8076535](https://bugs.openjdk.org/browse/JDK-8076535),
> [JDK-824226
On Fri, 3 Feb 2023 17:35:45 GMT, Weijun Wang wrote:
> Change blocklist to allowlist for encoding null parameters in `AlgorithmId`.
This pull request has now been integrated.
Changeset: a97271e3
Author:Weijun Wang
URL:
https://git.openjdk.org/jdk/commit/a97271e3b5d5a08fc503a11cd3e253
> Change blocklist to allowlist for encoding null parameters in `AlgorithmId`.
Weijun Wang has updated the pull request incrementally with one additional
commit since the last revision:
unexpected
-
Changes:
- all: https://git.openjdk.org/jdk/pull/12412/files
- new: https://g
On Mon, 6 Mar 2023 16:04:13 GMT, Sean Mullan wrote:
> Looks good other than the minor test comment but I think this is probably an
> Enhancement rather than a Bug.
Thanks. Fixed the test and updated the issue as an enhancement.
> test/jdk/sun/security/x509/AlgorithmId/NullParams.java line 108:
On Fri, 3 Feb 2023 17:35:45 GMT, Weijun Wang wrote:
> Change blocklist to allowlist for encoding null parameters in `AlgorithmId`.
Looks good other than the minor test comment but I think this is probably an
Enhancement rather than a Bug.
-
Marked as reviewed by mullan (Reviewer).
On Fri, 3 Feb 2023 17:35:45 GMT, Weijun Wang wrote:
> Change blocklist to allowlist for encoding null parameters in `AlgorithmId`.
test/jdk/sun/security/x509/AlgorithmId/NullParams.java line 108:
> 106: } else {
> 107: if (data.available() != 0) {
> 108: Syst
19 matches
Mail list logo
