Re: Remove com.sun.jarsigner package with related options

2023-02-28 Thread Eirik Bjørsnøs
> > This needs a CSR and a release note. Do you volunteer to write them? If > yes, you can write as comments in the PR and I can move them into JBS. You > can look at the CSRs for the 2 related bugs. > Thanks Weijun! Happy to write the CRS and release notes, I have included them as comments in the

Re: RFR: JDK-8303354: addCertificatesToKeystore in KeystoreImpl.m needs CFRelease call in early potential CHECK_NULL return

2023-02-28 Thread Matthias Baesken
On Tue, 28 Feb 2023 17:55:39 GMT, Christoph Langer wrote: > Makes sense. Hi Christoph, thanks for the review ! May I have a second review ? Thanks, Matthias - PR: https://git.openjdk.org/jdk/pull/12788

Re: RFR: 8301553: Support Password-Based Cryptography in SunPKCS11

2023-02-28 Thread Francisco Ferrari Bihurriet
On Tue, 28 Feb 2023 22:57:31 GMT, Valerie Peng wrote: >> We would like to propose an implementation for the [JDK-8301553: Support >> Password-Based Cryptography in >> SunPKCS11](https://bugs.openjdk.org/browse/JDK-8301553) enhancement >> requirement. >> >> In addition to pursuing the requirem

Re: RFR: 8295425: Match the default priv exp length between SunPKCS11 and other JDK providers [v2]

2023-02-28 Thread Valerie Peng
On Tue, 28 Feb 2023 23:51:51 GMT, Valerie Peng wrote: >> This changes the SunPKCS11 provider to use the same default private exponent >> length as the value used by SunJCE provider when initializing the DH Key >> Pair Generator impl using key size. In addition, the generated key pair will >> c

Re: RFR: 8295425: Match the default priv exp length between SunPKCS11 and other JDK providers [v2]

2023-02-28 Thread Weijun Wang
On Tue, 28 Feb 2023 23:51:51 GMT, Valerie Peng wrote: >> This changes the SunPKCS11 provider to use the same default private exponent >> length as the value used by SunJCE provider when initializing the DH Key >> Pair Generator impl using key size. In addition, the generated key pair will >> c

Re: RFR: 8295425: Match the default priv exp length between SunPKCS11 and other JDK providers [v2]

2023-02-28 Thread Valerie Peng
> This changes the SunPKCS11 provider to use the same default private exponent > length as the value used by SunJCE provider when initializing the DH Key Pair > Generator impl using key size. In addition, the generated key pair will > contain the specified parameters. If the supplied parameter d

Re: Remove com.sun.jarsigner package with related options

2023-02-28 Thread Wei-Jun Wang
Hi Eirik, I've filed https://bugs.openjdk.org/browse/JDK-8303410. This needs a CSR and a release note. Do you volunteer to write them? If yes, you can write as comments in the PR and I can move them into JBS. You can look at the CSRs for the 2 related bugs. Thanks, Weijun > On Feb 28, 2023, a

Re: RFR: 8301553: Support Password-Based Cryptography in SunPKCS11

2023-02-28 Thread Valerie Peng
On Fri, 3 Feb 2023 01:41:41 GMT, Martin Balao wrote: > We would like to propose an implementation for the [JDK-8301553: Support > Password-Based Cryptography in > SunPKCS11](https://bugs.openjdk.org/browse/JDK-8301553) enhancement > requirement. > > In addition to pursuing the requirement goa

Remove com.sun.jarsigner package with related options

2023-02-28 Thread Eirik Bjørsnøs
Hi, The following PR suggests we remove the com.sun.jarsigner package with related jarsigner options -altsigner and -altsignerpath options. These have been deprecated since Java 9, for removal since 16: https://github.com/openjdk/jdk/pull/12791 Thanks, Eirik.

Re: RFR: JDK-8303354: addCertificatesToKeystore in KeystoreImpl.m needs CFRelease call in early potential CHECK_NULL return

2023-02-28 Thread Christoph Langer
On Tue, 28 Feb 2023 15:17:19 GMT, Matthias Baesken wrote: > We have a (potential) early return in addCertificatesToKeystore in > KeystoreImpl.m . This is implemented by the CHECK_NULL macro. However this > missed a CFRelease call. Makes sense. - Marked as reviewed by clanger (Rev

RFR: JDK-8303354: addCertificatesToKeystore in KeystoreImpl.m needs CFRelease call in early potential CHECK_NULL return

2023-02-28 Thread Matthias Baesken
We have a (potential) early return in addCertificatesToKeystore in KeystoreImpl.m . This is implemented by the CHECK_NULL macro. However this missed a CFRelease call. - Commit messages: - JDK-8303354 Changes: https://git.openjdk.org/jdk/pull/12788/files Webrev: https://webrevs.op

Integrated: 8299817: [s390] AES-CTR mode intrinsic fails with multiple short update() calls

2023-02-28 Thread Lutz Schmidt
On Thu, 12 Jan 2023 14:29:34 GMT, Lutz Schmidt wrote: > This PR addresses an issue in the AES-CTR mode intrinsic on s390. When a > message is ciphered in multiple, small (< 16 bytes) segments, the result is > incorrect. > > This is not just a band-aid fix. The issue was taken as a chance to >