Re: RFR: 8301553: Support Password-Based Cryptography in SunPKCS11

2023-02-27 Thread Valerie Peng
On Fri, 3 Feb 2023 01:41:41 GMT, Martin Balao wrote: > We would like to propose an implementation for the [JDK-8301553: Support > Password-Based Cryptography in > SunPKCS11](https://bugs.openjdk.org/browse/JDK-8301553) enhancement > requirement. > > In addition to pursuing the requirement goa

Re: RFR: 8284047: Harmonize/Standardize the SSLSocket/SSLEngine/SSLSocketSSLEngine test templates [v2]

2023-02-27 Thread Matthew Donovan
> * Refactored SSLContextTemplate and SSLSocketTemplate to put common code in > one base class (SSLContextTemplate) > * Updated TLS/SSL tests to extend SSLSocketTemplate where possible. > * Updated SSLEngineTemplate to accommodate changes in SSLContextTemplate. To > keep this changeset to a reaso

Re: RFR: 8284047: Harmonize/Standardize the SSLSocket/SSLEngine/SSLSocketSSLEngine test templates

2023-02-27 Thread Matthew Donovan
On Thu, 16 Feb 2023 18:40:56 GMT, Rajan Halade wrote: >> * Refactored SSLContextTemplate and SSLSocketTemplate to put common code in >> one base class (SSLContextTemplate) >> * Updated TLS/SSL tests to extend SSLSocketTemplate where possible. >> * Updated SSLEngineTemplate to accommodate changes

Re: RFR: 8284047: Harmonize/Standardize the SSLSocket/SSLEngine/SSLSocketSSLEngine test templates

2023-02-27 Thread Matthew Donovan
On Thu, 16 Feb 2023 18:59:15 GMT, Rajan Halade wrote: >> test/jdk/sun/security/ssl/SignatureScheme/SigAlgosExtTestWithTLS13.java line >> 2: >> >>> 1: /* >>> 2: * Copyright (C) 2021, 2023 THL A29 Limited, a Tencent company. All >>> rights reserved. >> >> Missing comma and this is not Oracle c

Re: RFR: 8284047: Harmonize/Standardize the SSLSocket/SSLEngine/SSLSocketSSLEngine test templates

2023-02-27 Thread Matthew Donovan
On Thu, 16 Feb 2023 18:31:30 GMT, Rajan Halade wrote: >> * Refactored SSLContextTemplate and SSLSocketTemplate to put common code in >> one base class (SSLContextTemplate) >> * Updated TLS/SSL tests to extend SSLSocketTemplate where possible. >> * Updated SSLEngineTemplate to accommodate changes

Re: RFR: 8302017: Allocate BadPaddingException only if it will be thrown

2023-02-27 Thread Ahmed Muhsin
On Sat, 25 Feb 2023 02:38:47 GMT, David Schlosnagle wrote: >> This change will move the instantiation of BadPaddingException into the >> branch of the if statement where it is thrown. This will decrease the >> overhead of calling `unpadV15` and `unpadOAEP`. Please see the associated >> work i

Re: RFR: 8299817: [s390] AES-CTR mode intrinsic fails with multiple short update() calls [v5]

2023-02-27 Thread Lutz Schmidt
On Mon, 27 Feb 2023 09:03:49 GMT, Lutz Schmidt wrote: >> This PR addresses an issue in the AES-CTR mode intrinsic on s390. When a >> message is ciphered in multiple, small (< 16 bytes) segments, the result is >> incorrect. >> >> This is not just a band-aid fix. The issue was taken as a chance

Re: RFR: 8299817: [s390] AES-CTR mode intrinsic fails with multiple short update() calls [v5]

2023-02-27 Thread Lutz Schmidt
> This PR addresses an issue in the AES-CTR mode intrinsic on s390. When a > message is ciphered in multiple, small (< 16 bytes) segments, the result is > incorrect. > > This is not just a band-aid fix. The issue was taken as a chance to > restructure the code. though still complicated, It is n

Re: RFR: 8299817: [s390] AES-CTR mode intrinsic fails with multiple short update() calls [v4]

2023-02-27 Thread Lutz Schmidt
On Sat, 25 Feb 2023 07:51:24 GMT, Martin Doerr wrote: >> Lutz Schmidt has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains four commits: >> >> - Merge master to resolve copyright conflict >> - 829817: fixed typos, removed JIT_TIMER r