Integrated: 8301873: Avoid string decoding in ZipFile.Source.getEntryPos

2023-02-18 Thread Eirik Bjorsnos
On Mon, 30 Jan 2023 10:32:38 GMT, Eirik Bjorsnos wrote: > After finding a hash match, getEntryPos needs to compare the lookup name up > to the encoded entry name in the CEN. This comparison is done by decoding the > entry name into a String. The names can then be compared using the String > AP

Integrated: 8302623: jarsigner - use BufferedOutputStream to improve performance while creating the signed jar

2023-02-18 Thread Jaikiran Pai
On Thu, 16 Feb 2023 10:43:50 GMT, Jaikiran Pai wrote: > Can I please get a review for this change which improves the jarsigner tool's > performance (especially) when dealing with large jar files? This addresses > https://bugs.openjdk.org/browse/JDK-8302623. > > As noted in the JBS issue, wrapp

Re: RFR: 8302623: jarsigner - use BufferedOutputStream to improve performance while creating the signed jar [v3]

2023-02-18 Thread Jaikiran Pai
On Fri, 17 Feb 2023 15:49:56 GMT, Jaikiran Pai wrote: >> Can I please get a review for this change which improves the jarsigner >> tool's performance (especially) when dealing with large jar files? This >> addresses https://bugs.openjdk.org/browse/JDK-8302623. >> >> As noted in the JBS issue,

Re: RFR: 8301873: Avoid string decoding in ZipFile.Source.getEntryPos [v15]

2023-02-18 Thread Lance Andersen
On Wed, 15 Feb 2023 11:44:17 GMT, Eirik Bjorsnos wrote: >> After finding a hash match, getEntryPos needs to compare the lookup name up >> to the encoded entry name in the CEN. This comparison is done by decoding >> the entry name into a String. The names can then be compared using the >> Strin