On Fri, 3 Feb 2023 19:32:52 GMT, Alexey Ivanov wrote:
>> Julian Waters has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains four additional
>> commit
Hi All,
Thanks for all the feedbacks. One of them [1] from Bernd Eckenfels is about
Hybrid TLS Key Exchange. I read the IETF draft on it [2] and noticed something
that the current KEM API cannot handle. It says the 2 ciphertext for each
sub-KEM will be concatenated into a longer byte array as t
On Thu, 5 Jan 2023 01:18:55 GMT, Matthew Donovan wrote:
> Updated the test for TLS 1.2 and removed from ProblemList.txt
This pull request has now been integrated.
Changeset: e7247b10
Author:Matthew Donovan
Committer: Rajan Halade
URL:
https://git.openjdk.org/jdk/commit/e7247b10ccd2
On Fri, 3 Feb 2023 15:18:27 GMT, Julian Waters wrote:
>> Several comments are technically broken in Windows code, this change cleans
>> up the broken comments that managed to slip past reviewers during Integration
>
> Julian Waters has updated the pull request with a new target base due to a
>
On Tue, 31 Jan 2023 22:35:21 GMT, Bill Huang wrote:
> Root.java is changed to a manual test because it requires test to be run with
> the root user privilege, and it requires to modify the user policy file in
> the home director.
This pull request has now been integrated.
Changeset: 20579e48
On Thu, 2 Feb 2023 17:32:06 GMT, Sean Mullan wrote:
>> test/jdk/javax/xml/crypto/dsig/SecureValidationSystemProperty.java line 38:
>>
>>> 36: * @library /test/lib
>>> 37: * @run main/othervm -Dorg.jcp.xml.dsig.secureValidation=false
>>> SecureValidationSystemProperty
>>> 38: */
>>
>> the jt
On Fri, 3 Feb 2023 00:41:29 GMT, Bill Huang wrote:
>> Root.java is changed to a manual test because it requires test to be run
>> with the root user privilege, and it requires to modify the user policy file
>> in the home director.
>
> Bill Huang has updated the pull request incrementally with
On Thu, 2 Feb 2023 22:14:13 GMT, Matthew Donovan wrote:
>> Refactored the code a little bit and updated the test for changes to the TLS
>> state machine.
>
> Matthew Donovan has updated the pull request incrementally with one
> additional commit since the last revision:
>
> updated SSL conte
On Fri, 3 Feb 2023 15:26:13 GMT, Matthew Donovan wrote:
>> Updated the test for TLS 1.2 and removed from ProblemList.txt
>
> Matthew Donovan has updated the pull request incrementally with one
> additional commit since the last revision:
>
> renamed CheckStatus to CheckTlsEngineResults
Marke
On Fri, 3 Feb 2023 17:14:41 GMT, Mark Powers wrote:
> It's not clear to me what is causing this test failure, but your fix is to
> drain the input stream and flush the output?
Yes, that's the gist of it. I didn't realize originally that I was leaving
unread data in the input stream, so draini
Change blocklist to allowlist for encoding null parameters in `AlgorithmId`.
-
Commit messages:
- the fix
Changes: https://git.openjdk.org/jdk/pull/12412/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=12412&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8301793
Sta
On Thu, 2 Feb 2023 18:33:23 GMT, Jamil Nimeh wrote:
>> Hello all,
>>
>> This addresses a test bug where the SimpleOCSPServer would reset the
>> connections made by a client CertPathValidator. I've made some minor
>> changes to how the network data is read and sent from OCSP HTTP GET URLs and
On Fri, 3 Feb 2023 14:12:42 GMT, Yuri Nesterenko wrote:
> This small change should fix a possible under certain circumstances native
> memory leak. In fact, the actual leak was reported in production.
Looks good to me. I'll run some tests, does not look like there will be an
unexpected excepti
> Keep the "NAME -> 1.2.3.4" mapping unchanged but modify "1.2.3.4 -> NAME" to
> "1.2.3.4 -> Name".
Weijun Wang has updated the pull request incrementally with one additional
commit since the last revision:
impl not necessary
-
Changes:
- all: https://git.openjdk.org/jdk/pull/
Keep the "NAME -> 1.2.3.4" mapping unchanged but modify "1.2.3.4 -> NAME" to
"1.2.3.4 -> Name".
-
Commit messages:
- the fix
Changes: https://git.openjdk.org/jdk/pull/12410/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=12410&range=00
Issue: https://bugs.openjdk.org/brow
On Fri, 3 Feb 2023 15:30:50 GMT, Sean Mullan wrote:
>> You are correct. How did I come up with 220?
>
> @mcpowers Some comments in the code explaining this better would help.
That makes sense, thanks @seanjmullan
-
PR: https://git.openjdk.org/jdk/pull/12348
On Thu, 2 Feb 2023 22:24:48 GMT, Mark Powers wrote:
>> I think you mean line 126? :
>>
>> `tempArray = new byte[n]; `
>
> You are correct. How did I come up with 220?
@mcpowers Some comments in the code explaining this better would help.
-
PR: https://git.openjdk.
On Wed, 1 Feb 2023 15:13:41 GMT, Matthew Donovan wrote:
>> Mark Powers has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Sean's comment
>
> test/jdk/java/security/MessageDigest/TestCloneable.java line 95:
>
>> 93:
>> 94: System.o
> Updated the test for TLS 1.2 and removed from ProblemList.txt
Matthew Donovan has updated the pull request incrementally with one additional
commit since the last revision:
renamed CheckStatus to CheckTlsEngineResults
-
Changes:
- all: https://git.openjdk.org/jdk/pull/11857/f
> Several comments are technically broken in Windows code, this change cleans
> up the broken comments that managed to slip past reviewers during Integration
Julian Waters has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelate
This small change should fix a possible under certain circumstances native
memory leak. In fact, the actual leak was reported in production.
-
Commit messages:
- 8301760: Fix possible leak in SpNegoContext dispose
Changes: https://git.openjdk.org/jdk/pull/12407/files
Webrev: https
On Thu, 2 Feb 2023 17:35:14 GMT, Sean Mullan wrote:
>> src/java.base/share/conf/security/java.security line 953:
>>
>>> 951: # "false". Any other value for the system property is also treated as
>>> "false".
>>> 952: # If the system property is set, it supersedes the XMLCryptoContext
>>> prope
On Wed, 1 Feb 2023 14:46:28 GMT, Sean Mullan wrote:
> This change adds a system property that can be used to enable/disable the XML
> Signature secure validation mode. This is useful for enabling/disabling the
> mode at runtime. The system property will supersede and have the same name as
> th
> This PR resurrects VerifySignedJar which currently tests nothing.
>
> VerifySignedJar currently verifies a binary JAR which was signed with SHA-1
> back in April 2000. Because SHA-1 signed JARs has been disabled for a while,
> the JAR is treated as unsigned so the test doesn't really test anyt
24 matches
Mail list logo