Re: RFR: 8301167: Update VerifySignedJar to actually exercise and test verification

2023-02-02 Thread Andrey Turbanov
On Wed, 25 Jan 2023 17:38:13 GMT, Eirik Bjorsnos wrote: > This PR resurrects VerifySignedJar which currently tests nothing. > > VerifySignedJar currently verifies a binary JAR which was signed with SHA-1 > back in April 2000. Because SHA-1 signed JARs has been disabled for a while, > the JAR i

Integrated: 8180266: Convert sun/security/provider/KeyStore/DKSTest.sh to Java Jtreg Test

2023-02-02 Thread Sibabrata Sahoo
On Fri, 27 Jan 2023 15:20:09 GMT, Sibabrata Sahoo wrote: > Convert sun/security/provider/KeyStore/DKSTest.sh to Java Jtreg Test. This pull request has now been integrated. Changeset: 7f313b0c Author:Sibabrata Sahoo URL: https://git.openjdk.org/jdk/commit/7f313b0cef7d0e9732beed6c6129

RFR: 8301553: Support Password-Based Cryptography in SunPKCS11

2023-02-02 Thread Martin Balao
We would like to propose an implementation for the [JDK-8301553: Support Password-Based Cryptography in SunPKCS11](https://bugs.openjdk.org/browse/JDK-8301553) enhancement requirement. In addition to pursuing the requirement goals and guidelines of [JDK-8301553](https://bugs.openjdk.org/browse/

Re: RFR: JDK-8299994: java/security/Policy/Root/Root.java fails when home directory is read-only [v5]

2023-02-02 Thread Bill Huang
> Root.java is changed to a manual test because it requires test to be run with > the root user privilege, and it requires to modify the user policy file in > the home director. Bill Huang has updated the pull request incrementally with one additional commit since the last revision: Exclude

Re: RFR: JDK-8300416 java.security.MessageDigestSpi clone can result in thread-unsafe clones [v3]

2023-02-02 Thread Mark Powers
> https://bugs.openjdk.org/browse/JDK-8300416 Mark Powers has updated the pull request incrementally with one additional commit since the last revision: Sean's comment - Changes: - all: https://git.openjdk.org/jdk/pull/12348/files - new: https://git.openjdk.org/jdk/pull/12348

Re: RFR: JDK-8300416 java.security.MessageDigestSpi clone can result in thread-unsafe clones [v2]

2023-02-02 Thread Mark Powers
On Thu, 2 Feb 2023 22:01:03 GMT, Sean Mullan wrote: >> Mark Powers has updated the pull request incrementally with one additional >> commit since the last revision: >> >> copyright > > src/java.base/share/classes/java/security/MessageDigestSpi.java line 208: > >> 206: public Object clone

Re: RFR: JDK-8300416 java.security.MessageDigestSpi clone can result in thread-unsafe clones [v2]

2023-02-02 Thread Mark Powers
On Thu, 2 Feb 2023 22:06:42 GMT, Sean Mullan wrote: >> In the case where ByteBuffer has allocated a direct buffer, a new internal >> byte array gets allocated. This is the shared memory that's causing the >> problem. See MessageDigestSpi.java line 220. >> >> Oops got to update the copyright. >

Re: RFR: 8298868: Update EngineCloseOnAlert.java for changes to TLS implementation [v5]

2023-02-02 Thread Matthew Donovan
> Refactored the code a little bit and updated the test for changes to the TLS > state machine. Matthew Donovan has updated the pull request incrementally with one additional commit since the last revision: updated SSL context - Changes: - all: https://git.openjdk.org/jdk/pull

Re: RFR: JDK-8299994: java/security/Policy/Root/Root.java fails when home directory is read-only [v4]

2023-02-02 Thread Bill Huang
> Root.java is changed to a manual test because it requires test to be run with > the root user privilege, and it requires to modify the user policy file in > the home director. Bill Huang has updated the pull request incrementally with one additional commit since the last revision: Check no

Re: RFR: JDK-8300416 java.security.MessageDigestSpi clone can result in thread-unsafe clones [v2]

2023-02-02 Thread Sean Mullan
On Wed, 1 Feb 2023 17:56:05 GMT, Mark Powers wrote: >> test/jdk/java/security/MessageDigest/TestCloneable.java line 95: >> >>> 93: >>> 94: System.out.println(": Shared data check"); >>> 95: if (!Arrays.equals(d1.digest(), d2.digest())) { >> >> If d1 and d2 don't share memory an

Re: RFR: JDK-8300416 java.security.MessageDigestSpi clone can result in thread-unsafe clones [v2]

2023-02-02 Thread Sean Mullan
On Thu, 2 Feb 2023 15:32:14 GMT, Mark Powers wrote: >> https://bugs.openjdk.org/browse/JDK-8300416 > > Mark Powers has updated the pull request incrementally with one additional > commit since the last revision: > > copyright src/java.base/share/classes/java/security/MessageDigestSpi.java li

Integrated: 8286907: keytool should warn about weak PBE algorithms

2023-02-02 Thread Hai-May Chao
On Tue, 17 Jan 2023 23:25:42 GMT, Hai-May Chao wrote: > Please review the fix to address the problem in keytool -genseckey and > -importpass. This pull request has now been integrated. Changeset: b00b70c2 Author:Hai-May Chao URL: https://git.openjdk.org/jdk/commit/b00b70c2400d28070

Re: RFR: 8286907: keytool should warn about weak PBE algorithms [v2]

2023-02-02 Thread Hai-May Chao
On Thu, 26 Jan 2023 17:39:34 GMT, Sean Mullan wrote: >> Hai-May Chao has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update with Max's comment > > Yeah, this is a little tricky. My feeling is that if you disable an algorithm > like "RC2

Re: RFR: 8301260: Add system property to toggle XML Signature secure validation mode

2023-02-02 Thread Weijun Wang
On Wed, 1 Feb 2023 14:46:28 GMT, Sean Mullan wrote: > This change adds a system property that can be used to enable/disable the XML > Signature secure validation mode. This is useful for enabling/disabling the > mode at runtime. The system property will supersede and have the same name as > th

Re: RFR: 8300939: sun/security/provider/certpath/OCSP/OCSPNoContentLength.java fails due to network errors [v2]

2023-02-02 Thread Jamil Nimeh
> Hello all, > > This addresses a test bug where the SimpleOCSPServer would reset the > connections made by a client CertPathValidator. I've made some minor changes > to how the network data is read and sent from OCSP HTTP GET URLs and on > responses, respectively. This will take the test off

Re: RFR: 8298872: Update CheckStatus.java for changes to TLS implementation [v5]

2023-02-02 Thread Rajan Halade
On Wed, 1 Feb 2023 21:51:53 GMT, Matthew Donovan wrote: >> Updated the test for TLS 1.2 and removed from ProblemList.txt > > Matthew Donovan has updated the pull request incrementally with one > additional commit since the last revision: > > did some additional cleanup Marked as reviewed by

Re: RFR: 8301260: Add system property to toggle XML Signature secure validation mode

2023-02-02 Thread Sean Mullan
On Thu, 2 Feb 2023 16:56:26 GMT, Sean Coffey wrote: >> This change adds a system property that can be used to enable/disable the >> XML Signature secure validation mode. This is useful for enabling/disabling >> the mode at runtime. The system property will supersede and have the same >> name a

Re: RFR: 8301260: Add system property to toggle XML Signature secure validation mode

2023-02-02 Thread Sean Mullan
On Thu, 2 Feb 2023 17:00:36 GMT, Sean Coffey wrote: >> This change adds a system property that can be used to enable/disable the >> XML Signature secure validation mode. This is useful for enabling/disabling >> the mode at runtime. The system property will supersede and have the same >> name a

Re: RFR: 8301260: Add system property to toggle XML Signature secure validation mode

2023-02-02 Thread Sean Coffey
On Wed, 1 Feb 2023 14:46:28 GMT, Sean Mullan wrote: > This change adds a system property that can be used to enable/disable the XML > Signature secure validation mode. This is useful for enabling/disabling the > mode at runtime. The system property will supersede and have the same name as > th

Re: RFR: JDK-8300416 java.security.MessageDigestSpi clone can result in thread-unsafe clones [v2]

2023-02-02 Thread Mark Powers
> https://bugs.openjdk.org/browse/JDK-8300416 Mark Powers has updated the pull request incrementally with one additional commit since the last revision: copyright - Changes: - all: https://git.openjdk.org/jdk/pull/12348/files - new: https://git.openjdk.org/jdk/pull/12348/file

Re: RFR: 8217633: Configurable extensions with system properties [v2]

2023-02-02 Thread Michele Da Meda
On Tue, 26 Jan 2021 18:33:04 GMT, Xue-Lei Andrew Fan wrote: >> Xue-Lei Andrew Fan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update copyright years to 2021 > > Hi Bernd, > > I agree with you that System property is not as useful to

Re: RFR: 8298868: Update EngineCloseOnAlert.java for changes to TLS implementation [v4]

2023-02-02 Thread Matthew Donovan
> Refactored the code a little bit and updated the test for changes to the TLS > state machine. Matthew Donovan has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains six commits: - fixed conflict - removed import, updated ProblemList -

Re: RFR: 8298868: Update EngineCloseOnAlert.java for changes to TLS implementation [v3]

2023-02-02 Thread Matthew Donovan
> Refactored the code a little bit and updated the test for changes to the TLS > state machine. Matthew Donovan has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits: - removed import, updated ProblemList - Merge branch 'mas