Re: RFR: 8301443: Clean broken comments from Windows code

2023-01-30 Thread Julian Waters
On Tue, 31 Jan 2023 06:28:21 GMT, Julian Waters wrote: > Several comments are technically broken in Windows code, this change cleans > up the broken comments that managed to slip past reviewers during Integration @wangweij Sorry for the abrupt tag, but would the sspi.cpp change be fine with yo

RFR: 8301443: Clean broken comments from Windows code

2023-01-30 Thread Julian Waters
Several comments are technically broken in Windows code, this change cleans up the broken comments that managed to slip past reviewers during Integration - Commit messages: - Partial Revert - sspi.cpp - Comments Changes: https://git.openjdk.org/jdk/pull/12305/files Webrev: https

Re: RFR: 8298874: Update TestAllSuites.java for TLS v1.2 and 1.3 [v2]

2023-01-30 Thread Rajan Halade
On Mon, 30 Jan 2023 12:17:10 GMT, Matthew Donovan wrote: >> * updated test for new TLS protocols and ciphersuites >> * code cleanup > > Matthew Donovan has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains three commits: > > - incorpora

Re: RFR: 8294527: Some java.security.debug options missing from security docs

2023-01-30 Thread Sean Mullan
On Mon, 30 Jan 2023 10:23:59 GMT, Ryan Wallace wrote: > Hi, small change to the java.security.debug to enhance help() with missing > options. src/java.base/share/classes/sun/security/util/Debug.java line 90: > 88: System.err.println(" PKCS11 KeyStore debugging"); > 89:

Re: RFR: 8299817: [s390] AES-CTR mode intrinsic fails with multiple short update() calls [v2]

2023-01-30 Thread Lutz Schmidt
On Mon, 23 Jan 2023 09:23:54 GMT, Martin Doerr wrote: >> Lutz Schmidt has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8299817: Update copyright > > test/hotspot/jtreg/compiler/codegen/aes/Test8299817.java line 4: > >> 2: * Copyright (c

Re: RFR: 8299817: [s390] AES-CTR mode intrinsic fails with multiple short update() calls [v2]

2023-01-30 Thread Lutz Schmidt
> This PR addresses an issue in the AES-CTR mode intrinsic on s390. When a > message is ciphered in multiple, small (< 16 bytes) segments, the result is > incorrect. > > This is not just a band-aid fix. The issue was taken as a chance to > restructure the code. though still complicated, It is n

Re: RFR: 8298874: Update TestAllSuites.java for TLS v1.2 and 1.3 [v2]

2023-01-30 Thread Matthew Donovan
On Fri, 27 Jan 2023 21:33:13 GMT, Rajan Halade wrote: >> The test verifies the handshake negotiation for each ciphersuite/protocol >> combination. The `getSupportedCipherSuites()` and `getEnabledCipherSuites()` >> are independent of the enabled protocols. In other words, if you called >> `engi

Re: RFR: 8298874: Update TestAllSuites.java for TLS v1.2 and 1.3 [v2]

2023-01-30 Thread Matthew Donovan
> * updated test for new TLS protocols and ciphersuites > * code cleanup Matthew Donovan has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits: - incorporated Rajan's patch - Merge branch 'master' into test-all-suites - 829

RFR: 8294527: Some java.security.debug options missing from security docs

2023-01-30 Thread Ryan Wallace
Hi, small change to the java.security.debug to enhance help() with missing options. - Commit messages: - 8294527: Some java.security.debug options missing from security docs Changes: https://git.openjdk.org/jdk/pull/12289/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=1228