Re: RFR: 8288050: Add support of SHA-512/224 and SHA-512/256 to the PBKDF2 and PBES2 impls in SunJCE provider [v5]

2023-01-27 Thread Bernd
On Wed, 25 Jan 2023 22:33:59 GMT, Valerie Peng wrote: >> This RFE enhances existing PBE algorithms with the "SHA512/224" and >> "SHA512/256" support. >> Current transformation parsing in javax.crypto.Cipher class is re-written to >> handle the additional "/" in the "SHA512/224" and "SHA512/256

Pem util javadoc has copy and paste problem

2023-01-27 Thread Bernd Eckenfels
Hello, I think this Javadoc comment for the class does not belong there? https://github.com/openjdk/jdk/blob/391c2bb03a375dc22e416e6d1c015b86bbb958f7/src/java.base/share/classes/sun/security/util/Pem.java#L33 /** * The Length interface defines the length of an object */ public class Pem { Wou

Integrated: 8300140: ZipFile.isSignatureRelated returns true for files in META-INF subdirectories

2023-01-27 Thread Eirik Bjorsnos
On Thu, 12 Jan 2023 18:44:26 GMT, Eirik Bjorsnos wrote: > Some call sites of SignatureFileVerifier.isBlockOrSF fails to check that > files reside in META-INF directly, and not in a subdirectory of META-INF. > > The mentioned call sites needs updates to check and ignore such files. > > A new te

Re: RFR: 8300140: ZipFile.isSignatureRelated returns true for files in META-INF subdirectories [v15]

2023-01-27 Thread Eirik Bjorsnos
On Fri, 27 Jan 2023 22:16:18 GMT, Weijun Wang wrote: > Maybe we can rename `ZipFile::isSignatureRelated` to `ZipFile::isBlockOrSF` > as well? The term "signature related" seems to be used quite extensively around ZipFile and also in JavaUtilZipFileAccess. Semantics are very similar, but not ex

Re: RFR: 8300140: ZipFile.isSignatureRelated returns true for files in META-INF subdirectories [v15]

2023-01-27 Thread Weijun Wang
On Tue, 24 Jan 2023 12:31:30 GMT, Eirik Bjorsnos wrote: >> Some call sites of SignatureFileVerifier.isBlockOrSF fails to check that >> files reside in META-INF directly, and not in a subdirectory of META-INF. >> >> The mentioned call sites needs updates to check and ignore such files. >> >> A

Re: RFR: 8286907: keytool should warn about weak PBE algorithms [v2]

2023-01-27 Thread Weijun Wang
On Fri, 20 Jan 2023 22:03:29 GMT, Hai-May Chao wrote: >> Please review the fix to address the problem in keytool -genseckey and >> -importpass. > > Hai-May Chao has updated the pull request incrementally with one additional > commit since the last revision: > > Update with Max's comment Mar

Re: RFR: 8298874: Update TestAllSuites.java for TLS v1.2 and 1.3

2023-01-27 Thread Rajan Halade
On Fri, 27 Jan 2023 01:30:59 GMT, Matthew Donovan wrote: >> test/jdk/javax/net/ssl/SSLEngine/TestAllSuites.java line 333: >> >>> 331: >>> 332: enum SupportedCipherSuites { >>> 333: TLSv11("TLSv1.1", new String []{ >> >> Instead of this can we not continue with old approach of using

RFR: 8301274: update for deprecated sprintf for security components

2023-01-27 Thread Xue-Lei Andrew Fan
The sprintf is deprecated in Xcode 14 because of security concerns. The issue was addressed in [JDK-8296812](https://bugs.openjdk.org/browse/JDK-8296812) for building failure, and [JDK-8299378](https://bugs.openjdk.org/browse/JDK-8299378)/[JDK-8299635](https://bugs.openjdk.org/browse/JDK-8299635

Withdrawn: 8296546: Add @spec tags to API

2023-01-27 Thread duke
On Thu, 10 Nov 2022 01:10:13 GMT, Jonathan Gibbons wrote: > Please review a "somewhat automated" change to insert `@spec` tags into doc > comments, as appropriate, to leverage the recent new javadoc feature to > generate a new page listing the references to all external specifications > listed

RFR: 8180266: Convert sun/security/provider/KeyStore/DKSTest.sh to Java Jtreg Test

2023-01-27 Thread Sibabrata Sahoo
Convert sun/security/provider/KeyStore/DKSTest.sh to Java Jtreg Test. - Commit messages: - 8180266: Convert sun/security/provider/KeyStore/DKSTest.sh to Java Jtreg Test Changes: https://git.openjdk.org/jdk/pull/12257/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=12257&rang

Re: RFR: 8298872: Update CheckStatus.java for changes to TLS implementation [v4]

2023-01-27 Thread Matthew Donovan
> Updated the test for TLS 1.2 and removed from ProblemList.txt Matthew Donovan has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains six commits: - Merge branch 'master' into check-status - reverted ConnectionTest.java; added newline at

Re: RFR: 8298868: Update EngineCloseOnAlert.java for changes to TLS implementation [v2]

2023-01-27 Thread Matthew Donovan
On Thu, 26 Jan 2023 18:53:34 GMT, Rajan Halade wrote: >> Matthew Donovan has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains three commits: >> >> - Merge branch 'master' into engine-close >> - removed unnecessary line >> - 8298868:

Re: RFR: 8298868: Update EngineCloseOnAlert.java for changes to TLS implementation [v2]

2023-01-27 Thread Matthew Donovan
> Refactored the code a little bit and updated the test for changes to the TLS > state machine. Matthew Donovan has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits: - Merge branch 'master' into engine-close - removed unne

Re: RFR: 8298872: Update CheckStatus.java for changes to TLS implementation [v3]

2023-01-27 Thread Matthew Donovan
> Updated the test for TLS 1.2 and removed from ProblemList.txt Matthew Donovan has updated the pull request incrementally with one additional commit since the last revision: reverted ConnectionTest.java; added newline at end of CheckStatus.java - Changes: - all: https://git.op