Integrated: 8300272: Improve readability of the test JarWithOneNonDisabledDigestAlg

2023-01-24 Thread Eirik Bjorsnos
On Fri, 13 Jan 2023 20:12:56 GMT, Eirik Bjorsnos wrote: > This PR attempts to make JarWithOneNonDisabledDigestAlg a little easier to > read. > > Some changes are made in the choice of algorithms and naming. The intent here > is to reduce confusion and make the purpose of the test clearer: >

Re: RFR: 8300140: ZipFile.isSignatureRelated returns true for files in META-INF subdirectories [v15]

2023-01-24 Thread Eirik Bjorsnos
On Tue, 24 Jan 2023 18:54:59 GMT, Weijun Wang wrote: > Precisely `ZipFile::isSignatureRelated` should also contain those `SIG-` > files. Should they though? These files are ultimately read by JarFile.initializeVerifier, which I guess only cares about signature/block files it actually knows

Re: RFR: 8300140: ZipFile.isSignatureRelated returns true for files in META-INF subdirectories [v15]

2023-01-24 Thread Weijun Wang
On Tue, 24 Jan 2023 12:31:30 GMT, Eirik Bjorsnos wrote: >> Some call sites of SignatureFileVerifier.isBlockOrSF fails to check that >> files reside in META-INF directly, and not in a subdirectory of META-INF. >> >> The mentioned call sites needs updates to check and ignore such files. >> >> A

Re: RFR: 8300272: Improve readability of the test JarWithOneNonDisabledDigestAlg [v4]

2023-01-24 Thread Weijun Wang
On Tue, 24 Jan 2023 12:18:10 GMT, Eirik Bjorsnos wrote: >> This PR attempts to make JarWithOneNonDisabledDigestAlg a little easier to >> read. >> >> Some changes are made in the choice of algorithms and naming. The intent >> here is to reduce confusion and make the purpose of the test clearer

Re: RFR: 8298874: Update TestAllSuites.java for TLS v1.2 and 1.3

2023-01-24 Thread Matthew Donovan
On Fri, 23 Dec 2022 17:08:03 GMT, Matthew Donovan wrote: > * updated test for new TLS protocols and ciphersuites > * code cleanup Can someone take a look at this? Thanks! - PR: https://git.openjdk.org/jdk/pull/11780

Re: RFR: 8300140: ZipFile.isSignatureRelated returns true for files in META-INF subdirectories [v15]

2023-01-24 Thread Eirik Bjorsnos
> Some call sites of SignatureFileVerifier.isBlockOrSF fails to check that > files reside in META-INF directly, and not in a subdirectory of META-INF. > > The mentioned call sites needs updates to check and ignore such files. > > A new test IgnoreUnrelatedSignatureFiles is added which verifies t

Re: RFR: 8300272: Improve readability of the test JarWithOneNonDisabledDigestAlg [v4]

2023-01-24 Thread Eirik Bjorsnos
> This PR attempts to make JarWithOneNonDisabledDigestAlg a little easier to > read. > > Some changes are made in the choice of algorithms and naming. The intent here > is to reduce confusion and make the purpose of the test clearer: > > - Updated the **enabled** digestAlgorithm in use from SH

Re: RFR: 8300272: Improve readability of the test JarWithOneNonDisabledDigestAlg [v3]

2023-01-24 Thread Eirik Bjorsnos
> This PR attempts to make JarWithOneNonDisabledDigestAlg a little easier to > read. > > Some changes are made in the choice of algorithms and naming. The intent here > is to reduce confusion and make the purpose of the test clearer: > > - Updated the **enabled** digestAlgorithm in use from SH

Withdrawn: 8296408: Make the PCSCException public accessible

2023-01-24 Thread duke
On Mon, 7 Nov 2022 05:55:18 GMT, Johannes Waigel wrote: > The `PCSCException` is thrown, but the error type is not visible due to the > "private-packe" access rule. > By changing the visibility it is possible to handle / access this exception > type explicitly in the catch. This pull request h