CSR RFR: JDK-8300722: The unit of OCSP timeout should be changed from seconds to milliseconds

2023-01-19 Thread Jamil Nimeh
Hello all, I put together a draft CSR for enhancing the com.sun.security.ocsp.timeout System property to allow it to be specified either in seconds (as it is currently done, no change to the format) or by appending "ms" (case-insensitive) to allow the numeric value to be interpreted in millis

Re: RFR: 8296343: CPVE thrown on missing content-length in OCSP response [v3]

2023-01-19 Thread Sean Mullan
On Thu, 12 Jan 2023 15:46:46 GMT, Jamil Nimeh wrote: >> This fixes an issue where HTTP responses that do not have an explicit >> Content-Length are causing an EOFException which unravels into a >> CertPathValidatorException during validations that involve OCSP checks. >> >> - JBS: https://bugs

Re: RFR: 8297972: Poly1305 Endianness on ByteBuffer not enforced [v2]

2023-01-19 Thread Jamil Nimeh
On Thu, 19 Jan 2023 22:13:07 GMT, Volodymyr Paprotski wrote: >> Looks good to me. > > @jnimeh would you mind running this through your tests? The build failures > reported above seem unrelated.. @vpaprotsk Yes, happy to take it through a regression run on my side. I'll will run it later tonig

Re: RFR: 8297972: Poly1305 Endianness on ByteBuffer not enforced [v2]

2023-01-19 Thread Volodymyr Paprotski
On Thu, 19 Jan 2023 18:49:30 GMT, Jamil Nimeh wrote: >> Volodymyr Paprotski has updated the pull request with a new target base due >> to a merge or a rebase. The incremental webrev excludes the unrelated >> changes brought in by the merge/rebase. The pull request contains three >> additional

Re: RFR: 8299870: TLS record version check allows invalid records [v4]

2023-01-19 Thread Rajan Halade
On Tue, 17 Jan 2023 17:12:05 GMT, Matthew Donovan wrote: >> - Updated ProtocolVersion.isNegotiable() to check a bounded range of version >> numbers. >> - Removed IllegalRecordVersion.java from ProblemList.txt >> >> Tested with jdk_security and jdk_security3 test groups. > > Matthew Donovan has

Re: RFR: 8299870: TLS record version check allows invalid records [v4]

2023-01-19 Thread Rajan Halade
On Tue, 10 Jan 2023 22:46:06 GMT, Rajan Halade wrote: >> Matthew Donovan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> removed extra whitespace > > test/jdk/ProblemList.txt line 590: > >> 588: >> 589: javax/net/ssl/SSLEngine/TestAllS

Re: RFR: 8297972: Poly1305 Endianness on ByteBuffer not enforced [v2]

2023-01-19 Thread Jamil Nimeh
On Thu, 19 Jan 2023 18:30:04 GMT, Volodymyr Paprotski wrote: >> Per rfc7539 Section 2.5, "Read the block as a little-endian number." >> >> sun.security.util.math.intpoly.IntegerPolynomial1305 enforces this on input >> when input is provided as `[]byte` but not when input is in `ByteBuffer` >>

Integrated: 8300399: EdDSA does not verify when there is no message

2023-01-19 Thread Weijun Wang
On Wed, 18 Jan 2023 03:21:29 GMT, Weijun Wang wrote: > Verify should go on even if there is no message. This pull request has now been integrated. Changeset: b317658d Author:Weijun Wang URL: https://git.openjdk.org/jdk/commit/b317658d69a477df04ded3cc2e107970f8a6e20d Stats: 54 li

Re: RFR: 8297972: Poly1305 Endianness on ByteBuffer not enforced [v2]

2023-01-19 Thread Volodymyr Paprotski
> Per rfc7539 Section 2.5, "Read the block as a little-endian number." > > sun.security.util.math.intpoly.IntegerPolynomial1305 enforces this on input > when input is provided as `[]byte` but not when input is in `ByteBuffer` > > Tested with `Poly1305IntrinsicFuzzTest.java` from > https://githu

Re: RFR: 8300399: EdDSA does not verify when there is no message

2023-01-19 Thread Anthony Scarpino
On Wed, 18 Jan 2023 03:21:29 GMT, Weijun Wang wrote: > Verify should go on even if there is no message. Marked as reviewed by ascarpino (Reviewer). - PR: https://git.openjdk.org/jdk/pull/12059

Integrated: 8300647: Miscellaneous hashCode improvements in java.base

2023-01-19 Thread Claes Redestad
On Thu, 19 Jan 2023 11:45:12 GMT, Claes Redestad wrote: > Went through the jdk and found a few more places where > `ArraysSupport::vectorizedHashCode` can be used, and a few where adhoc > methods could be replaced with a plain call to `java.util.Arrays` > equivalents. This patch addresses that

Re: RFR: 8300647: Miscellaneous hashCode improvements in java.base [v2]

2023-01-19 Thread Claes Redestad
On Thu, 19 Jan 2023 13:46:26 GMT, Claes Redestad wrote: >> Went through the jdk and found a few more places where >> `ArraysSupport::vectorizedHashCode` can be used, and a few where adhoc >> methods could be replaced with a plain call to `java.util.Arrays` >> equivalents. This patch addresses

Re: RFR: 8300647: Miscellaneous hashCode improvements in java.base [v2]

2023-01-19 Thread Roger Riggs
On Thu, 19 Jan 2023 13:46:26 GMT, Claes Redestad wrote: >> Went through the jdk and found a few more places where >> `ArraysSupport::vectorizedHashCode` can be used, and a few where adhoc >> methods could be replaced with a plain call to `java.util.Arrays` >> equivalents. This patch addresses

Re: RFR: 8300647: Miscellaneous hashCode improvements in java.base [v2]

2023-01-19 Thread Sergey Tsypanov
On Thu, 19 Jan 2023 13:46:26 GMT, Claes Redestad wrote: >> Went through the jdk and found a few more places where >> `ArraysSupport::vectorizedHashCode` can be used, and a few where adhoc >> methods could be replaced with a plain call to `java.util.Arrays` >> equivalents. This patch addresses

Re: RFR: 8300647: Miscellaneous hashCode improvements in java.base [v2]

2023-01-19 Thread Viktor Klang
On Thu, 19 Jan 2023 13:46:26 GMT, Claes Redestad wrote: >> Went through the jdk and found a few more places where >> `ArraysSupport::vectorizedHashCode` can be used, and a few where adhoc >> methods could be replaced with a plain call to `java.util.Arrays` >> equivalents. This patch addresses

Re: RFR: 8300647: Miscellaneous hashCode improvements in java.base [v2]

2023-01-19 Thread Claes Redestad
> Went through the jdk and found a few more places where > `ArraysSupport::vectorizedHashCode` can be used, and a few where adhoc > methods could be replaced with a plain call to `java.util.Arrays` > equivalents. This patch addresses that. > > After this, #12068, and #12077 I think we're reachi

RFR: 8300647: Miscellaneous hashCode improvements in java.base

2023-01-19 Thread Claes Redestad
Went through the jdk and found a few more places where `ArraysSupport::vectorizedHashCode` can be used, and a few where adhoc methods could be replaced with a plain call to `java.util.Arrays` equivalents. This patch addresses that. After this, #12068, and #12077 I think we're reaching the limit

Re: RFR: 8300493: Use ArraysSupport.vectorizedHashCode in j.u.zip.ZipCoder

2023-01-19 Thread Claes Redestad
On Wed, 18 Jan 2023 16:53:04 GMT, Claes Redestad wrote: > `ZipCoder::checkedHashCode` emulates `StringLatin1::hashCode` but operates on > a `byte[]` subrange. It can profitably use the recently introduced > `ArraysSupport::vectorizedHashCode` method to see a speed-up, which > translates to a s