Re: RFR: 8015831: Add lint check for calling overridable methods from a constructor

2023-01-06 Thread Archie L . Cobbs
On Fri, 6 Jan 2023 15:38:31 GMT, Alan Bateman wrote: >>> The associated JBS issue has been dormant for 6+ years and this is a very >>> intrusive change affecting many, many files. Has the resurrection of this >>> project previously been discussed somewhere? >> >> Hi @dholmes-ora, >> >> The wo

Re: RFR: 8015831: Add lint check for calling overridable methods from a constructor [v2]

2023-01-06 Thread Archie L . Cobbs
> This PR adds a new lint warning category `this-escape`. > > It also adds `@SuppressWarnings` annotations as needed to the JDK itself to > allow the JDK to continue to compile with `-Xlint:all`. > > A 'this' escape warning is generated for a constructor `A()` in a class `A` > when the compiler

Re: RFR: 8299746: Accept unknown signatureAlgorithm in PKCS7 SignerInfo

2023-01-06 Thread Weijun Wang
On Fri, 6 Jan 2023 18:48:51 GMT, Xue-Lei Andrew Fan wrote: >> Modern signature algorithms provided by a 3rd-party provider might not be >> recognized by JDK code yet. > > src/java.base/share/classes/sun/security/pkcs/SignerInfo.java line 540: > >> 538: } >> 539:

Re: RFR: 8299746: Accept unknown signatureAlgorithm in PKCS7 SignerInfo

2023-01-06 Thread Xue-Lei Andrew Fan
On Fri, 6 Jan 2023 15:52:03 GMT, Weijun Wang wrote: > Modern signature algorithms provided by a 3rd-party provider might not be > recognized by JDK code yet. src/java.base/share/classes/sun/security/pkcs/SignerInfo.java line 540: > 538: } > 539: if (keyAlg.equal

Integrated: 8299746: Accept unknown signatureAlgorithm in PKCS7 SignerInfo

2023-01-06 Thread Weijun Wang
On Fri, 6 Jan 2023 15:52:03 GMT, Weijun Wang wrote: > Modern signature algorithms provided by a 3rd-party provider might not be > recognized by JDK code yet. This pull request has now been integrated. Changeset: ba03f42a Author:Weijun Wang URL: https://git.openjdk.org/jdk/commit/ba

Re: RFR: 8299746: Accept unknown signatureAlgorithm in PKCS7 SignerInfo

2023-01-06 Thread Hai-May Chao
On Fri, 6 Jan 2023 15:52:03 GMT, Weijun Wang wrote: > Modern signature algorithms provided by a 3rd-party provider might not be > recognized by JDK code yet. Marked as reviewed by hchao (Committer). - PR: https://git.openjdk.org/jdk/pull/11883

Re: RFR: 8299746: Accept unknown signatureAlgorithm in PKCS7 SignerInfo

2023-01-06 Thread Anthony Scarpino
On Fri, 6 Jan 2023 15:52:03 GMT, Weijun Wang wrote: > Modern signature algorithms provided by a 3rd-party provider might not be > recognized by JDK code yet. looks good - Marked as reviewed by ascarpino (Reviewer). PR: https://git.openjdk.org/jdk/pull/11883

Re: RFR: 8299746: Accept unknown signatureAlgorithm in PKCS7 SignerInfo

2023-01-06 Thread Kevin Driver
On Fri, 6 Jan 2023 15:52:03 GMT, Weijun Wang wrote: > Modern signature algorithms provided by a 3rd-party provider might not be > recognized by JDK code yet. Marked as reviewed by kdriver (Author). - PR: https://git.openjdk.org/jdk/pull/11883

RFR: 8299746: Accept unknown signatureAlgorithm in PKCS7 SignerInfo

2023-01-06 Thread Weijun Wang
Modern signature algorithms provided by a 3rd-party provider might not be recognized by JDK code yet. - Commit messages: - the fix Changes: https://git.openjdk.org/jdk/pull/11883/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=11883&range=00 Issue: https://bugs.openjdk.or

Re: RFR: 8015831: Add lint check for calling overridable methods from a constructor

2023-01-06 Thread Maurizio Cimadamore
On Fri, 6 Jan 2023 15:38:31 GMT, Alan Bateman wrote: >>> The associated JBS issue has been dormant for 6+ years and this is a very >>> intrusive change affecting many, many files. Has the resurrection of this >>> project previously been discussed somewhere? >> >> Hi @dholmes-ora, >> >> The wo

Re: RFR: 8015831: Add lint check for calling overridable methods from a constructor

2023-01-06 Thread Alan Bateman
On Fri, 6 Jan 2023 14:49:16 GMT, Archie L. Cobbs wrote: > Sounds reasonable... so I take it you would also be in favor of patching > `make/modules` instead of adding `@SuppressWarnings` annotations > everywhere... is that correct? > > If this is generally agreed as a better route then let me k

Re: RFR: 8015831: Add lint check for calling overridable methods from a constructor

2023-01-06 Thread Archie L . Cobbs
On Fri, 6 Jan 2023 04:48:27 GMT, David Holmes wrote: > The associated JBS issue has been dormant for 6+ years and this is a very > intrusive change affecting many, many files. Has the resurrection of this > project previously been discussed somewhere? Hi @dholmes-ora, The work to add this war

RFR: 8298869: Update ConnectionTest.java for changes to TLS implementation

2023-01-06 Thread Matthew Donovan
* Updated the test for changes to the TLS implementation * Test supports TLS 1.2 and 1.3 * Removed from ProblemList.txt * Refactored code a bit - Commit messages: - removed extra whitespace - 8298869: Update ConnectionTest.java for changes to TLS implementation Changes: https://git