On Wed, 21 Dec 2022 15:05:13 GMT, Volker Simonis wrote:
>> Currently, TLS session tickets introduced by
>> [JDK-8211018](https://bugs.openjdk.org/browse/JDK-8211018) in JDK 13 (i.e.
>> `SessionTicketExtension$StatelessKey`) are generated in the class
>> `SessionTicketExtension` and they use a
On Wed, 21 Dec 2022 20:15:57 GMT, Xue-Lei Andrew Fan wrote:
>> Volker Simonis has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Optimized initialisation of currentKeyID and deletion of expired session
>> keys as proposed by @schlosna
>
>
On Wed, 21 Dec 2022 21:38:22 GMT, Mark Powers wrote:
> https://bugs.openjdk.org/browse/JDK-8299230
Marked as reviewed by xuelei (Reviewer).
-
PR: https://git.openjdk.org/jdk20/pull/69
On Wed, 21 Dec 2022 23:42:48 GMT, Matthew Donovan wrote:
> Updated to use specific ciphersuite and TLS protocol.
> Updated tests based on changes to SSLEngine implementation
Looks good to me, although it would be nice to check more protocols.
-
Marked as reviewed by xuelei (Reviewe
Updated to use specific ciphersuite and TLS protocol.
Updated tests based on changes to SSLEngine implementation
-
Commit messages:
- 8298867: Basics.java fails with SSL handshake exception
Changes: https://git.openjdk.org/jdk/pull/11760/files
Webrev: https://webrevs.openjdk.org/?r
On Wed, 21 Dec 2022 21:38:22 GMT, Mark Powers wrote:
> https://bugs.openjdk.org/browse/JDK-8299230
Marked as reviewed by mullan (Reviewer).
-
PR: https://git.openjdk.org/jdk20/pull/69
On Wed, 21 Dec 2022 21:38:22 GMT, Mark Powers wrote:
> https://bugs.openjdk.org/browse/JDK-8299230
Marked as reviewed by jjg (Reviewer).
-
PR: https://git.openjdk.org/jdk20/pull/69
On Tue, 20 Dec 2022 19:23:10 GMT, Bill Huang wrote:
>> This task converts 5 manual tests to automated tests.
>>
>> sun/security/provider/PolicyParser/ExtDirsDefaultPolicy.java
>> sun/security/provider/PolicyParser/ExtDirsChange.java
>> sun/security/provider/PolicyParser/ExtDirs.java
>> java/s
On Wed, 21 Dec 2022 21:37:27 GMT, Bill Huang wrote:
>> I have not seen this used in any other tests. It is a good learning, I
>> didn't knew that multiple tests in single file are run in parallel. It seems
>> like good option. Do you know of any other regression test written this way?
>
> I did
https://bugs.openjdk.org/browse/JDK-8299230
-
Commit messages:
- first iteration
Changes: https://git.openjdk.org/jdk20/pull/69/files
Webrev: https://webrevs.openjdk.org/?repo=jdk20&pr=69&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8299230
Stats: 2 lines in 2 files chan
On Wed, 21 Dec 2022 20:39:03 GMT, Rajan Halade wrote:
>> Multiple "run" in a single test fails the whole test when one test run fails
>> and all subsequent test run get terminated. Multiple tests with only one
>> "run" each allows all test run to be excused, and they can be run in
>> parallel.
On Wed, 21 Dec 2022 19:58:18 GMT, Bill Huang wrote:
>> test/jdk/sun/security/provider/PolicyParser/ExtDirs.java line 33:
>>
>>> 31:
>>> 32: /*
>>> 33: * @test
>>
>> Why are these tags duplicated here?
>
> Multiple "run" in a single test fails the whole test when one test run fails
> and all
On Wed, 21 Dec 2022 15:05:13 GMT, Volker Simonis wrote:
>> Currently, TLS session tickets introduced by
>> [JDK-8211018](https://bugs.openjdk.org/browse/JDK-8211018) in JDK 13 (i.e.
>> `SessionTicketExtension$StatelessKey`) are generated in the class
>> `SessionTicketExtension` and they use a
On Wed, 21 Dec 2022 18:51:32 GMT, Rajan Halade wrote:
>> Bill Huang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Implemented review comments.
>
> test/jdk/sun/security/provider/PolicyParser/ExtDirs.java line 33:
>
>> 31:
>> 32: /*
>
On Wed, 19 Oct 2022 16:49:33 GMT, Mahendra Chhipa wrote:
>> Are you saying that we don't need to run the ExtDir2.policy and
>> ExtDir3.policy?
>
> Its fine, ignore my previous comment.
you can add multiple run tags under same test tag, no need to repeat tag, bug,
and summary tags.
---
On Tue, 20 Dec 2022 19:23:10 GMT, Bill Huang wrote:
>> This task converts 5 manual tests to automated tests.
>>
>> sun/security/provider/PolicyParser/ExtDirsDefaultPolicy.java
>> sun/security/provider/PolicyParser/ExtDirsChange.java
>> sun/security/provider/PolicyParser/ExtDirs.java
>> java/s
> Currently, TLS session tickets introduced by
> [JDK-8211018](https://bugs.openjdk.org/browse/JDK-8211018) in JDK 13 (i.e.
> `SessionTicketExtension$StatelessKey`) are generated in the class
> `SessionTicketExtension` and they use a single, global key ID
> (`currentKeyID`) for all `SSLContext`
On Wed, 21 Dec 2022 00:10:08 GMT, David Schlosnagle wrote:
>> Volker Simonis has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Some refactoring and simplification. Moved most of the implementation
>> from SessionTicketExtension to SSLSe
On Wed, 21 Dec 2022 00:22:37 GMT, David Schlosnagle wrote:
>> Volker Simonis has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Some refactoring and simplification. Moved most of the implementation
>> from SessionTicketExtension to SSLSe
19 matches
Mail list logo
