Re: RFR: 8298710: Fix typos in test/jdk/sun/security/tools/jarsigner/

2022-12-13 Thread Jaikiran Pai
On Wed, 14 Dec 2022 06:17:29 GMT, Jaikiran Pai wrote: > Can I please get a review of this change which fixes some typos in the files > under test/jdk/sun/security/tools/jarsigner/? There was another trivial typo fix from the original PR in test/jdk/javax/security/auth/x500/X500Principal/Escape

Re: RFR: 8298710: Fix typos in test/jdk/sun/security/tools/jarsigner/ [v2]

2022-12-13 Thread Jaikiran Pai
> Can I please get a review of this change which fixes some typos in the files > under test/jdk/sun/security/tools/jarsigner/? Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision: typo in test/jdk/javax/security/auth/x500/X500Principal/Es

RFR: 8298710: Fix typos in test/jdk/sun/security/tools/jarsigner/

2022-12-13 Thread Jaikiran Pai
Can I please get a review of this change which fixes some typos in the files under test/jdk/sun/security/tools/jarsigner/? - Commit messages: - 8298710: Fix typos in test/jdk/sun/security/tools/jarsigner/ Changes: https://git.openjdk.org/jdk/pull/11662/files Webrev: https://webrev

Re: RFR: 8288050: Add support of SHA-512/224 and SHA-512/256 to the PBKDF2 and PBES2 impls in SunJCE provider [v4]

2022-12-13 Thread Valerie Peng
> This RFE enhances existing PBE algorithms with the "SHA512/224" and > "SHA512/256" support. > Current transformation parsing in javax.crypto.Cipher class is re-written to > handle the additional "/" in the "SHA512/224" and "SHA512/256" algorithm > names. Existing tests are updated with the ad

Re: RFR: 8298249: Excessive memory allocation in CipherInputStream AEAD decryption

2022-12-13 Thread Valerie Peng
On Thu, 8 Dec 2022 16:33:06 GMT, Daniel Jeliński wrote: > This patch modifies `CipherInputStream` to avoid pointless memory allocations > when decrypting data using AEAD ciphers. > > `Cipher.update` on AEAD decryption does not output any data; instead, all > data is buffered and returned in on

Re: Disabled brainpool curves

2022-12-13 Thread Anthony Scarpino
Additionally JDK-8235540, was a java.security configuration change for JDK7 and JDK8. If you want to re-enable brainpool curves, change the java.disabled.namedCurves and/or jdk.[tls|certpath|jar].disabledAlgorithms properties in the java.security. One policy won't fit everyone's needs, tha

Integrated: Merge jdk20

2022-12-13 Thread Jesper Wilhelmsson
On Tue, 13 Dec 2022 13:55:12 GMT, Jesper Wilhelmsson wrote: > Forwardport JDK 20 -> JDK 21 This pull request has now been integrated. Changeset: 23e18275 Author:Jesper Wilhelmsson URL: https://git.openjdk.org/jdk/commit/23e18275ac2a7297ba806a1835fabb7141949967 Stats: 181 lines

RFR: Merge jdk20

2022-12-13 Thread Jesper Wilhelmsson
Forwardport JDK 20 -> JDK 21 - Commit messages: - Merge remote-tracking branch 'jdk20/master' into Merge_jdk20 - 8298084: Memory leak in Method::build_profiling_method_data - 8296955: Kitchensink.java failed with "double free or corruption (!prev): " - 8298488: [macos13] tools/jp

Withdrawn: Merge jdk20

2022-12-13 Thread Jesper Wilhelmsson
On Mon, 12 Dec 2022 18:49:49 GMT, Jesper Wilhelmsson wrote: > Forwardport JDK 20 -> JDK 21 This pull request has been closed without being integrated. - PR: https://git.openjdk.org/jdk/pull/11637

Re: Disabled brainpool curves

2022-12-13 Thread Sean Mullan
On 12/13/22 2:39 AM, benjamin.marw...@f-i.de wrote: Hi everyone! I just stumbled over “Disable weak named curves”, e.g. • https://bugs.openjdk.org/browse/JDK-8235540 • http://cr.openjdk.java.net/~alexsch/sercher/8233228/webrev.00/src/share/lib/security/java.security-aix.udiff.html Interest

Re: RFR: 8297798: Timeout with DTLSOverDatagram test template [v2]

2022-12-13 Thread Matthew Donovan
On Thu, 8 Dec 2022 19:40:12 GMT, Rajan Halade wrote: >> test/jdk/javax/net/ssl/DTLS/DTLSOverDatagram.java line 617: >> >>> 615: clientException = e; >>> 616: >>> 617: if (testCase.isGoodJob()) { >> >> Same here. Check if this is method is even used and what is the purpo

Re: RFR: 8297798: Timeout with DTLSOverDatagram test template [v2]

2022-12-13 Thread Matthew Donovan
> This fix is intended to address various time-out errors in tests that use > DTLSOverDatagram as a test template. Based on test output from those bugs > (JDK-8202059, JDK-8249562, JDK-8280185, JDK-8280186, JDK-8269887, > JDK-8268899), this fix: > > * refactors the class to only create one addi