RFR: 8298249: Excessive memory allocation in CipherInputStream AEAD decryption

2022-12-08 Thread Daniel JeliƄski
This patch modifies `CipherInputStream` to avoid pointless memory allocations when decrypting data using AEAD ciphers. `Cipher.update` on AEAD decryption does not output any data; instead, all data is buffered and returned in one shot from `doFinal` call. On the other hand, the value returned b

Re: RFR: 8297798: Timeout with DTLSOverDatagram test template

2022-12-08 Thread Rajan Halade
On Thu, 8 Dec 2022 12:54:30 GMT, Matthew Donovan wrote: > I'm not completely comfortable marking them as duplicate because there are a > few different errors going on and I wasn't able to reproduce them. Can we > mark mark them as "cannot reproduce" and include a link to this fix? Since all of

Re: RFR: 8297798: Timeout with DTLSOverDatagram test template

2022-12-08 Thread Rajan Halade
On Thu, 8 Dec 2022 19:33:09 GMT, Rajan Halade wrote: >> This fix is intended to address various time-out errors in tests that use >> DTLSOverDatagram as a test template. Based on test output from those bugs >> (JDK-8202059, JDK-8249562, JDK-8280185, JDK-8280186, JDK-8269887, >> JDK-8268899), t

Re: RFR: 8295803: Console should be usable in jshell and other environments [v7]

2022-12-08 Thread Naoto Sato
On Tue, 6 Dec 2022 18:10:38 GMT, Naoto Sato wrote: >> src/java.base/share/classes/java/io/Console.java line 99: >> >>> 97: */ >>> 98: >>> 99: public class Console implements Flushable >> >> Should we perhaps `seal` this class and only `permit` `ProxyingConsole` to >> `extend` it? > > Right.

Re: RFR: 8297798: Timeout with DTLSOverDatagram test template

2022-12-08 Thread Rajan Halade
On Wed, 7 Dec 2022 13:04:28 GMT, Matthew Donovan wrote: > This fix is intended to address various time-out errors in tests that use > DTLSOverDatagram as a test template. Based on test output from those bugs > (JDK-8202059, JDK-8249562, JDK-8280185, JDK-8280186, JDK-8269887, > JDK-8268899), th

Re: RFR: 8297798: Timeout with DTLSOverDatagram test template

2022-12-08 Thread Rajan Halade
On Wed, 7 Dec 2022 13:04:28 GMT, Matthew Donovan wrote: > This fix is intended to address various time-out errors in tests that use > DTLSOverDatagram as a test template. Based on test output from those bugs > (JDK-8202059, JDK-8249562, JDK-8280185, JDK-8280186, JDK-8269887, > JDK-8268899), th

Re: RFR: 8298381: Improve handling of session tickets for multiple SSLContexts

2022-12-08 Thread Sergey Bylokhov
On Thu, 8 Dec 2022 13:09:11 GMT, Volker Simonis wrote: > Currently, TLS session tickets introduced by > [JDK-8211018](https://bugs.openjdk.org/browse/JDK-8211018) in JDK 13 (i.e. > `SessionTicketExtension$StatelessKey`) are generated in the class > `SessionTicketExtension` and they use a singl

Re: RFR: 8297798: Timeout with DTLSOverDatagram test template

2022-12-08 Thread Rajan Halade
On Wed, 7 Dec 2022 13:04:28 GMT, Matthew Donovan wrote: > This fix is intended to address various time-out errors in tests that use > DTLSOverDatagram as a test template. Based on test output from those bugs > (JDK-8202059, JDK-8249562, JDK-8280185, JDK-8280186, JDK-8269887, > JDK-8268899), th

Re: RFR: 8298381: Improve handling of session tickets for multiple SSLContexts

2022-12-08 Thread Sergey Bylokhov
On Thu, 8 Dec 2022 13:09:11 GMT, Volker Simonis wrote: > Currently, TLS session tickets introduced by > [JDK-8211018](https://bugs.openjdk.org/browse/JDK-8211018) in JDK 13 (i.e. > `SessionTicketExtension$StatelessKey`) are generated in the class > `SessionTicketExtension` and they use a singl

Re: RFR: 8296507: GCM using more memory than necessary with in-place operations [v7]

2022-12-08 Thread Carter Kozak
On Thu, 8 Dec 2022 18:24:03 GMT, Andrew Haley wrote: >> Anthony Scarpino has updated the pull request incrementally with three >> additional commits since the last revision: >> >> - editor screwed up >> - why won't this merge hell stop 2 >> - why won't this merge hell stop 3 > > What benchma

Re: RFR: 8296507: GCM using more memory than necessary with in-place operations [v7]

2022-12-08 Thread Andrew Haley
On Tue, 6 Dec 2022 20:29:56 GMT, Anthony Scarpino wrote: >> I would like a review of an update to the GCM code. A recent report showed >> that GCM memory usage for TLS was very large. This was a result of in-place >> buffers, which TLS uses, and how the code handled the combined intrinsic >>

RFR: 8298381: Improve handling of session tickets for multiple SSLContexts

2022-12-08 Thread Volker Simonis
Currently, TLS session tickets introduced by [JDK-8211018](https://bugs.openjdk.org/browse/JDK-8211018) in JDK 13 (i.e. `SessionTicketExtension$StatelessKey`) are generated in the class `SessionTicketExtension` and they use a single, global key ID (`currentKeyID`) for all `SSLContext`s. This i

Re: The question about 8211018: Session Resumption without Server-Side State

2022-12-08 Thread Volker Simonis
Hi Sergey, Thanks for starting this discussion. I've opened "8298381: Improve handling of session tickets for multiple SSLContexts" [1] to track this issue and submitted a pull request with a potential fix [2]. Let's continue the discussion there if you don't mind :) Best regards, Volker [1] htt

Withdrawn: 8298277: Replace "session" with "scope" for FFM access

2022-12-08 Thread Per Minborg
On Wed, 7 Dec 2022 21:55:43 GMT, Per Minborg wrote: > This PR suggests renaming various names from "session" to "scope" in > accordance with https://openjdk.org/jeps/434 > > The PRs contains changes for several sub-components. This pull request has been closed without being integrated. --

Re: RFR: 8298277: Replace "session" with "scope" for FFM access [v2]

2022-12-08 Thread Per Minborg
On Thu, 8 Dec 2022 08:17:44 GMT, Per Minborg wrote: >> This PR suggests renaming various names from "session" to "scope" in >> accordance with https://openjdk.org/jeps/434 >> >> The PRs contains changes for several sub-components. > > Per Minborg has updated the pull request incrementally with

Re: RFR: 8297798: Timeout with DTLSOverDatagram test template

2022-12-08 Thread Matthew Donovan
On Wed, 7 Dec 2022 20:34:00 GMT, Rajan Halade wrote: > Since this fix will address intermittent failures from these 5 tests, can we > close those 5 bugs as duplicate of this fix? I'm not completely comfortable marking them as duplicate because there are a few different errors going on and I wa

Re: RFR: 8298277: Replace "session" with "scope" for FFM access [v2]

2022-12-08 Thread Per Minborg
> This PR suggests renaming various names from "session" to "scope" in > accordance with https://openjdk.org/jeps/434 > > The PRs contains changes for several sub-components. Per Minborg has updated the pull request incrementally with one additional commit since the last revision: Revert ren