Re: RFR: 8295010: Reduce if required in EC limbs operations [v6]

2022-11-27 Thread John Jiang
On Wed, 23 Nov 2022 06:21:05 GMT, Xue-Lei Andrew Fan wrote: >> Hi, >> >> May I have this update reviewed? With this update, the result will be >> reduced if required in EC limbs operations in the JDK implementation. >> >> In the current implementation, the EC limbs addition and subtraction re

Re: RFR: 8294321: Fix typos in files under test/jdk/java, test/jdk/jdk, test/jdk/jni [v2]

2022-11-27 Thread Michael Ernst
On Mon, 26 Sep 2022 16:51:36 GMT, Michael Ernst wrote: >> 8294321: Fix typos in files under test/jdk/java, test/jdk/jdk, test/jdk/jni > > Michael Ernst has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains six commits: > > - Reinstate t

Re: RFR: 8296024: Usage of DIrectBuffer::address should be guarded [v14]

2022-11-27 Thread Alan Bateman
On Thu, 24 Nov 2022 16:21:42 GMT, Per Minborg wrote: >> This PR proposes the introduction of **guarding** of the use of >> `DirectBuffer::address` within the JDK. With the introduction of the Foreign >> Function and Memory access, it is possible to derive Buffer instances that >> are backed by

Re: RFR: 8296024: Usage of DIrectBuffer::address should be guarded [v14]

2022-11-27 Thread Alan Bateman
On Thu, 24 Nov 2022 16:21:42 GMT, Per Minborg wrote: >> This PR proposes the introduction of **guarding** of the use of >> `DirectBuffer::address` within the JDK. With the introduction of the Foreign >> Function and Memory access, it is possible to derive Buffer instances that >> are backed by

Re: RFR: 8297065: DerOutputStream operations should not throw IOExceptions [v2]

2022-11-27 Thread Weijun Wang
On Sun, 27 Nov 2022 07:57:35 GMT, Valerie Peng wrote: >> Weijun Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> one more > > src/java.base/share/classes/sun/security/x509/X509CRLImpl.java line 300: > >> 298: * @exception C

Re: RFR: 8297519: Improve expressions and modernise code

2022-11-27 Thread ExE Boss
On Thu, 24 Nov 2022 08:24:37 GMT, Per Minborg wrote: > During the work of another PR (https://github.com/openjdk/jdk/pull/11260), > several improvement areas were identified. These are now adressed in this > separate PR proposing the use of more modern Java constructs as well as > simplifying

Re: RFR: 8296142: CertAttrSet::(getName|getElements|delete) are mostly useless

2022-11-27 Thread Andrey Turbanov
On Tue, 1 Nov 2022 13:34:40 GMT, Weijun Wang wrote: > This code change removes `getElements()` and `delete()` from `CertAttrSet` > and all its subclasses. The `getName()` method is moved to `s.s.x.Extension` > since it's only useful there. > > Except for removing lines, the only place where re

RFR: 8297683: Use enhanced-for cycle instead of Enumeration in java.security.jgss

2022-11-27 Thread Andrey Turbanov
java.util.Enumeration is a legacy interface from java 1.0. There are a few places with cycles which use it to iterate over collections. We can replace this manual cycle with enchanced-for, which is shorter and easier to read. sun.security.jgss.ProviderList#addAllMechsFromProvider sun.security.jg

Re: RFR: 8288050: Add support of SHA-512/224 and SHA-512/256 to the PBKDF2 and PBES2 impls in SunJCE provider [v2]

2022-11-27 Thread Valerie Peng
> This RFE enhances existing PBE algorithms with the "SHA512/224" and > "SHA512/256" support. > Current transformation parsing in javax.crypto.Cipher class is re-written to > handle the additional "/" in the "SHA512/224" and "SHA512/256" algorithm > names. Existing tests are updated with the ad

Re: RFR: 8288050: Add support of SHA-512/224 and SHA-512/256 to the PBKDF2 and PBES2 impls in SunJCE provider

2022-11-27 Thread Valerie Peng
On Thu, 24 Nov 2022 20:13:20 GMT, Andrey Turbanov wrote: >> This RFE enhances existing PBE algorithms with the "SHA512/224" and >> "SHA512/256" support. >> Current transformation parsing in javax.crypto.Cipher class is re-written to >> handle the additional "/" in the "SHA512/224" and "SHA512/

Re: RFR: 8297065: DerOutputStream operations should not throw IOExceptions [v2]

2022-11-27 Thread Valerie Peng
On Wed, 23 Nov 2022 19:48:48 GMT, Weijun Wang wrote: >> This is mostly cleanup. Everything around `DerOutputStream` no longer throws >> an `IOException`. This includes: >> >> - Remove unnecessary `throws IOException` in code and spec >> - Remove `catch (IOException ioe)` blocks. If new exceptio

Re: RFR: 8297065: DerOutputStream operations should not throw IOExceptions [v2]

2022-11-27 Thread Valerie Peng
On Wed, 23 Nov 2022 19:48:48 GMT, Weijun Wang wrote: >> This is mostly cleanup. Everything around `DerOutputStream` no longer throws >> an `IOException`. This includes: >> >> - Remove unnecessary `throws IOException` in code and spec >> - Remove `catch (IOException ioe)` blocks. If new exceptio

Re: RFR: 8297065: DerOutputStream operations should not throw IOExceptions [v2]

2022-11-27 Thread Valerie Peng
On Wed, 23 Nov 2022 19:48:48 GMT, Weijun Wang wrote: >> This is mostly cleanup. Everything around `DerOutputStream` no longer throws >> an `IOException`. This includes: >> >> - Remove unnecessary `throws IOException` in code and spec >> - Remove `catch (IOException ioe)` blocks. If new exceptio

Re: RFR: 8297065: DerOutputStream operations should not throw IOExceptions [v2]

2022-11-27 Thread Valerie Peng
On Wed, 23 Nov 2022 19:48:48 GMT, Weijun Wang wrote: >> This is mostly cleanup. Everything around `DerOutputStream` no longer throws >> an `IOException`. This includes: >> >> - Remove unnecessary `throws IOException` in code and spec >> - Remove `catch (IOException ioe)` blocks. If new exceptio