Re: RFR: 8295010: Reduce if required in EC limbs operations [v5]

2022-11-20 Thread Daniel Jeliński
On Sat, 19 Nov 2022 07:17:19 GMT, Xue-Lei Andrew Fan wrote: >> Hi, >> >> May I have this update reviewed? With this update, the result will be >> reduced if required in EC limbs operations in the JDK implementation. >> >> In the current implementation, the EC limbs addition and subtraction re

Re: RFR: 8295010: Reduce if required in EC limbs operations [v5]

2022-11-20 Thread Daniel Jeliński
On Sat, 19 Nov 2022 07:17:19 GMT, Xue-Lei Andrew Fan wrote: >> Hi, >> >> May I have this update reviewed? With this update, the result will be >> reduced if required in EC limbs operations in the JDK implementation. >> >> In the current implementation, the EC limbs addition and subtraction re

Re: RFR: 8295010: Reduce if required in EC limbs operations

2022-11-20 Thread Xue-Lei Andrew Fan
On Mon, 10 Oct 2022 12:11:54 GMT, Daniel Jeliński wrote: >> Hi, >> >> May I have this update reviewed? With this update, the result will be >> reduced if required in EC limbs operations in the JDK implementation. >> >> In the current implementation, the EC limbs addition and subtraction resul

Re: RFR: 8295010: Reduce if required in EC limbs operations [v4]

2022-11-20 Thread Xue-Lei Andrew Fan
On Wed, 9 Nov 2022 14:27:26 GMT, Ferenc Rakoczi wrote: >> Xue-Lei Andrew Fan has updated the pull request with a new target base due >> to a merge or a rebase. The pull request now contains six commits: >> >> - Merge master >> - missed reduce >> - reduce if needed >> - add the key pair gene

Re: Undo deprecation of brainpool EC

2022-11-20 Thread Xuelei Fan
Hi, As I’m working on this area recently, I will see if I can contribute. But it may be no easier than JDK 21. If you don’t mind, I may ask for more requirement details later and help for testing. Thanks, Xuelei > On Nov 15, 2022, at 11:23 PM, > wrote: > > Hi Xuelei and Sean, > > We use

Re: RFR: 8281236: (D)TLS key exchange named groups [v3]

2022-11-20 Thread Xue-Lei Andrew Fan
On Tue, 8 Nov 2022 22:07:35 GMT, Sean Mullan wrote: >>> Unfortunately, I only have author status and can only comment. >> >> I think OpenJDK Author can approve as well. I just need to get another >> Reviewer approval before integration. > >> > Unfortunately, I only have author status and can o

Re: RFR: 8247645: ChaCha20 intrinsics [v4]

2022-11-20 Thread Jamil Nimeh
> This PR delivers ChaCha20 intrinsics that accelerate the core block function > that generates key stream from the key, counter and nonce. Intrinsics have > been written for the following platforms and instruction sets: > > - x86_64: AVX, AVX2 and AVX512 > - aarch64: platforms that support the

Re: RFR: 8294073: Performance improvement for message digest implementations

2022-11-20 Thread John Jiang
On Tue, 20 Sep 2022 22:12:04 GMT, Xue-Lei Andrew Fan wrote: > Hi, > > In the message digest implementation, for example SHA256, in JDK, two bitwise > operations could be improved with equivalent arithmetic, and then the number > bitwise operations could be reduced accordingly. Specifically >

Re: RFR: 8295146: Clean up native code with newer C/C++ language features [v3]

2022-11-20 Thread Julian Waters
On Tue, 15 Nov 2022 06:33:00 GMT, Kim Barrett wrote: >> Julian Waters has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Revert to using simpler solution similar to the original 8274980 > > src/hotspot/share/utilities/globalDefinitions.hpp

Re: RFR: JDK-8297164: Update troff man pages and CheckManPageOptions.java

2022-11-20 Thread David Holmes
On Thu, 17 Nov 2022 22:23:53 GMT, Jonathan Gibbons wrote: > Please review an update for the troff man pages, following the recent update > to upgrade to use pandoc 2.19.2 > (See https://bugs.openjdk.org/browse/JDK-8297165) > > In conjunction with this, one javadoc test also needs to be updated,

Re: RFR: 8297301: Cleanup unused methods in JavaUtilJarAccess [v5]

2022-11-20 Thread pandaapo
On Sun, 20 Nov 2022 15:37:24 GMT, Weijun Wang wrote: > `codomain`, `VerifierCodeSource`, `isSigningRelated`, and `getUnsignedCS` > also used nowhere. Thanks. I think your `codomain` must mean `csdomain`. - PR: https://git.openjdk.org/jdk/pull/11072

Re: RFR: 8297301: Cleanup unused methods in JavaUtilJarAccess [v6]

2022-11-20 Thread pandaapo
> The cache named `signerToCodeSource` in `JarVerifier` is never used now. pandaapo has updated the pull request incrementally with one additional commit since the last revision: Modify as review and update copyright. - Changes: - all: https://git.openjdk.org/jdk/pull/11072/fil

Re: RFR: 8297301: Cleanup unused methods in JavaUtilJarAccess [v5]

2022-11-20 Thread Weijun Wang
On Sun, 20 Nov 2022 06:27:32 GMT, pandaapo wrote: >> The cache named `signerToCodeSource` in `JarVerifier` is never used now. > > pandaapo has updated the pull request incrementally with one additional > commit since the last revision: > > Modify as reviews. `codomain`, `VerifierCodeSource`,