Re: RFR: 8297301: Cleanup unused methods in JavaUtilJarAccess [v5]

2022-11-19 Thread pandaapo
> The cache named `signerToCodeSource` in `JarVerifier` is never used now. pandaapo has updated the pull request incrementally with one additional commit since the last revision: Modify as reviews. - Changes: - all: https://git.openjdk.org/jdk/pull/11072/files - new: https://

Re: RFR: 8296734: JarVerifier:: mapSignersToCodeSource should cache in map [v4]

2022-11-19 Thread Weijun Wang
On Sat, 19 Nov 2022 04:31:13 GMT, pandaapo wrote: >> The cache named `signerToCodeSource` in `JarVerifier` is never used now. > > pandaapo has updated the pull request incrementally with one additional > commit since the last revision: > > Modify as reviews. I just filed https://bugs.openjdk

Re: RFR: 8296734: JarVerifier:: mapSignersToCodeSource should cache in map [v4]

2022-11-19 Thread pandaapo
On Sat, 19 Nov 2022 23:00:44 GMT, Weijun Wang wrote: > since this bug description is about a coding error but you fix is about > cleanup, how about I file another bug and you use it in the title? OK. Thanks. > I am trying to add a noreg-cleanup label to the bug and it does not apply to > the

Re: RFR: 8296734: JarVerifier:: mapSignersToCodeSource should cache in map [v4]

2022-11-19 Thread Weijun Wang
On Sat, 19 Nov 2022 04:31:13 GMT, pandaapo wrote: >> The cache named `signerToCodeSource` in `JarVerifier` is never used now. > > pandaapo has updated the pull request incrementally with one additional > commit since the last revision: > > Modify as reviews. BTW, since this bug description i

Re: RFR: 8296734: JarVerifier:: mapSignersToCodeSource should cache in map [v4]

2022-11-19 Thread Weijun Wang
On Sat, 19 Nov 2022 04:31:13 GMT, pandaapo wrote: >> The cache named `signerToCodeSource` in `JarVerifier` is never used now. > > pandaapo has updated the pull request incrementally with one additional > commit since the last revision: > > Modify as reviews. Great to see more lines removed.