> Hi,
>
> Please review this performance improvement for Secp256R1 implementation in
> OpenJDK. With this update, there is an about 20% performance improvement for
> Secp256R1 key generation and signature.
>
> Basically, 256 bits EC curves could use 9 integer limbs for the computation.
> The
> Hi,
>
> May I have this update reviewed? With this update, the result will be
> reduced if required in EC limbs operations in the JDK implementation.
>
> In the current implementation, the EC limbs addition and subtraction result
> is not reduced before the value is returned. This behavior
> The cache named `signerToCodeSource` in `JarVerifier` is never used now.
pandaapo has updated the pull request incrementally with one additional commit
since the last revision:
Modify as reviews.
-
Changes:
- all: https://git.openjdk.org/jdk/pull/11072/files
- new: https://
On Fri, 18 Nov 2022 15:38:47 GMT, Weijun Wang wrote:
>> pandaapo has updated the pull request with a new target base due to a merge
>> or a rebase. The incremental webrev excludes the unrelated changes brought
>> in by the merge/rebase. The pull request contains three additional commits
>> sin
> The cache named `signerToCodeSource` in `JarVerifier` is never used now.
pandaapo has updated the pull request incrementally with one additional commit
since the last revision:
Modify as reviews.
-
Changes:
- all: https://git.openjdk.org/jdk/pull/11072/files
- new: https://
On Thu, 17 Nov 2022 12:26:18 GMT, Sean Coffey wrote:
> A doc edit to indicate that modifications of values in java.security conf
> file would require a JVM restart in order for such changes to be detected.
src/java.base/share/conf/security/java.security line 29:
> 27: # an unspecified error wh
On Fri, 18 Nov 2022 17:56:27 GMT, Xue-Lei Andrew Fan wrote:
>> Hi,
>>
>> May I have this update reviewed?
>>
>> The EC point multiplication for secp256r1 could be improved for better
>> performance, by using more efficient algorithm and pre-computation.
>> Improvement for other curves are si
On Fri, 18 Nov 2022 02:31:19 GMT, David Holmes wrote:
> Hi @jonathan-gibbons ,
>
> I notice that in the new version dash characters are no longer escaped as
> `-`, do these still display correctly?
Yes, at least in all the files I verified and I have no reason to believe it
might be different
> Hi,
>
> May I have this update reviewed?
>
> The EC point multiplication for secp256r1 could be improved for better
> performance, by using more efficient algorithm and pre-computation.
> Improvement for other curves are similar, but will be addressed in separated
> PRs.
>
> The basic idea
On Fri, 18 Nov 2022 13:07:06 GMT, Ryan Wallace wrote:
>> test/jdk/sun/security/provider/PolicyFile/Comparator.java line 36:
>>
>>> 34: *
>>> 35: * Note: SubjectCodeSource removed, but PolicyFile might have the same
>>> problem. Keep the test as-is
>>> 36: *
>>
>> I may have the note in a bu
On Sun, 13 Nov 2022 19:58:30 GMT, Xue-Lei Andrew Fan wrote:
> Hi,
>
> May I have this update reviewed?
>
> In the current key pair generation micro-benchmark, there is no cases for
> `EdDSA`, `XDH`, and `RSASSA-PSS`. This PR is trying to add these algorithms.
>
> BTW, here is the benchmarkin
On Thu, 3 Nov 2022 16:51:47 GMT, Mark Powers wrote:
>> Xue-Lei Andrew Fan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> typo correction
>
> Is this improvement also derived from the paper by Renes, Costello, and
> Batina?
@mcpowers @
On Fri, 18 Nov 2022 16:02:31 GMT, Weijun Wang wrote:
> Sure, you can choose your style. It's just that the original test was able to
> use multiple algorithm names in a single class but your enhancement abandoned
> this feature.
Did you refer to other bench case, like Signatures.java where I
On Fri, 18 Nov 2022 01:52:33 GMT, Weijun Wang wrote:
>> When `X509CRLSelector ` requires a CRL number extension but a CRL does not
>> have it, the CRL should not be selected.
>>
>> Note: the test uses a new internal API introduced in
>> https://github.com/openjdk/jdk/pull/11151.
>
> Weijun Wan
On Thu, 3 Nov 2022 18:18:42 GMT, Xue-Lei Andrew Fan wrote:
>> Hi,
>>
>> May I have this update reviewed?
>>
>> The EC point multiplication for secp256r1 could be improved for better
>> performance, by using more efficient algorithm and pre-computation.
>> Improvement for other curves are sim
On Thu, 3 Nov 2022 18:17:44 GMT, Xue-Lei Andrew Fan wrote:
>> Thanks!
>
> @ferakocz All good suggestions to me. Thank you very much!
> @XueleiFan Please hold off on integrating this, as I want to review some
> parts of this and need more time.
I'm ok with this now, but please check with other
On Sun, 13 Nov 2022 19:58:30 GMT, Xue-Lei Andrew Fan wrote:
> Hi,
>
> May I have this update reviewed?
>
> In the current key pair generation micro-benchmark, there is no cases for
> `EdDSA`, `XDH`, and `RSASSA-PSS`. This PR is trying to add these algorithms.
>
> BTW, here is the benchmarkin
On Fri, 18 Nov 2022 03:57:32 GMT, pandaapo wrote:
>> The cache named `signerToCodeSource` in `JarVerifier` is never used now.
>
> pandaapo has updated the pull request with a new target base due to a merge
> or a rebase. The incremental webrev excludes the unrelated changes brought in
> by the
On Fri, 18 Nov 2022 03:57:32 GMT, pandaapo wrote:
>> The cache named `signerToCodeSource` in `JarVerifier` is never used now.
>
> pandaapo has updated the pull request with a new target base due to a merge
> or a rebase. The incremental webrev excludes the unrelated changes brought in
> by the
On Fri, 18 Nov 2022 03:57:32 GMT, pandaapo wrote:
>> The cache named `signerToCodeSource` in `JarVerifier` is never used now.
>
> pandaapo has updated the pull request with a new target base due to a merge
> or a rebase. The incremental webrev excludes the unrelated changes brought in
> by the
On Tue, 8 Nov 2022 16:41:07 GMT, Xue-Lei Andrew Fan wrote:
>> Ryan Wallace has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains seven additional
>> c
On Fri, 18 Nov 2022 03:37:02 GMT, Xue-Lei Andrew Fan wrote:
> I guess the compatibility impact is low?
Without the fix, an NPE will be thrown.
-
PR: https://git.openjdk.org/jdk/pull/11215
22 matches
Mail list logo
