Re: RFR: 8294731: Improve multiplicative inverse for secp256r1 implementation [v2]

2022-11-13 Thread Xue-Lei Andrew Fan
On Wed, 2 Nov 2022 14:44:30 GMT, Ferenc Rakoczi wrote: >>> ... you only have one chance to measure, so cannot average out noise ... >> >> There are cases that one chance is enough to place an attack. We normally >> don't discuss vulnerability details in public, please send me an email in >> p

Re: RFR: 8294073: Performance improvement for message digest implementations

2022-11-13 Thread Xue-Lei Andrew Fan
On Wed, 21 Sep 2022 18:29:08 GMT, Aleksey Shipilev wrote: >> @shipilev Good points and I agree with them. >> >>> Are you getting +0.8% throughput on microbenchmarks? >> >> Yes, I got it a few times. I tested on MacOS/M1 and Linux/AMD for >> 64/512/2048/16384 bytes. As the improvement is not s

Re: RFR: 8295146: Clean up native code with newer C/C++ language features [v2]

2022-11-13 Thread Julian Waters
On Sun, 13 Nov 2022 22:58:11 GMT, David Holmes wrote: >> Julian Waters has updated the pull request incrementally with one additional >> commit since the last revision: >> >> ATTRIBUTE_SCANF > > src/hotspot/os/linux/os_perf_linux.cpp line 233: > >> 231: * Ensure that 'fmt' does _NOT_ conta

Re: RFR: 8295146: Clean up native code with newer C/C++ language features [v2]

2022-11-13 Thread Julian Waters
> After [JDK-8292008](https://bugs.openjdk.org/browse/JDK-8292008) and > [JDK-8247283](https://bugs.openjdk.org/browse/JDK-8247283), some C and C++ > code across the JDK can be replaced and simplified with cleaner language > features that were previously not available due to required compatibili

Re: RFR: 8295146: Clean up native code with newer C/C++ language features

2022-11-13 Thread Julian Waters
On Sun, 13 Nov 2022 23:16:47 GMT, David Holmes wrote: >> After [JDK-8292008](https://bugs.openjdk.org/browse/JDK-8292008) and >> [JDK-8247283](https://bugs.openjdk.org/browse/JDK-8247283), some C and C++ >> code across the JDK can be replaced and simplified with cleaner language >> features th

Re: RFR: 8295146: Clean up native code with newer C/C++ language features

2022-11-13 Thread Julian Waters
On Sun, 13 Nov 2022 23:08:53 GMT, David Holmes wrote: >> After [JDK-8292008](https://bugs.openjdk.org/browse/JDK-8292008) and >> [JDK-8247283](https://bugs.openjdk.org/browse/JDK-8247283), some C and C++ >> code across the JDK can be replaced and simplified with cleaner language >> features th

Re: RFR: 8295146: Clean up native code with newer C/C++ language features

2022-11-13 Thread Julian Waters
On Sun, 13 Nov 2022 23:07:35 GMT, David Holmes wrote: >> After [JDK-8292008](https://bugs.openjdk.org/browse/JDK-8292008) and >> [JDK-8247283](https://bugs.openjdk.org/browse/JDK-8247283), some C and C++ >> code across the JDK can be replaced and simplified with cleaner language >> features th

Re: RFR: 8295146: Clean up native code with newer C/C++ language features

2022-11-13 Thread Julian Waters
On Sun, 13 Nov 2022 22:59:01 GMT, David Holmes wrote: >> After [JDK-8292008](https://bugs.openjdk.org/browse/JDK-8292008) and >> [JDK-8247283](https://bugs.openjdk.org/browse/JDK-8247283), some C and C++ >> code across the JDK can be replaced and simplified with cleaner language >> features th

Re: RFR: 8295146: Clean up native code with newer C/C++ language features

2022-11-13 Thread David Holmes
On Thu, 10 Nov 2022 06:20:41 GMT, Julian Waters wrote: > After [JDK-8292008](https://bugs.openjdk.org/browse/JDK-8292008) and > [JDK-8247283](https://bugs.openjdk.org/browse/JDK-8247283), some C and C++ > code across the JDK can be replaced and simplified with cleaner language > features that

RFR: 8296900: CertificateValidity fields are not be optional

2022-11-13 Thread Weijun Wang
Make two fields inside `CertificateValidity` final. - Commit messages: - the fix Changes: https://git.openjdk.org/jdk/pull/11126/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=11126&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8296900 Stats: 112 lines in 2 files

Re: RFR: 8296746: NativePRNG SecureRandom doesn't scale with threads

2022-11-13 Thread Xue-Lei Andrew Fan
On Wed, 9 Nov 2022 20:15:57 GMT, Xubo Zhang wrote: > NativePRNG SecureRandom doesn’t scale with number of threads. The performance > starts dropping as we increase the number of threads. Even going from 1 > thread to 2 threads shows significant drop. The bottleneck is the singleton > RandomIO

Re: RFR: 8296746: NativePRNG SecureRandom doesn't scale with threads

2022-11-13 Thread Andrey Turbanov
On Wed, 9 Nov 2022 20:15:57 GMT, Xubo Zhang wrote: > NativePRNG SecureRandom doesn’t scale with number of threads. The performance > starts dropping as we increase the number of threads. Even going from 1 > thread to 2 threads shows significant drop. The bottleneck is the singleton > RandomIO