On Wed, 2 Nov 2022 04:37:44 GMT, Mark Powers wrote:
> tier1 and tier2 tests all pass
Thank you very much, @mcpowers! Please let me know if you need more time for
the review.
-
PR: https://git.openjdk.org/jdk/pull/10893
On Tue, 1 Nov 2022 19:10:13 GMT, Xue-Lei Andrew Fan wrote:
>> Hi,
>>
>> May I have this update reviewed?
>>
>> The EC point multiplication for secp256r1 could be improved for better
>> performance, by using more efficient algorithm and pre-computation.
>> Improvement for other curves are sim
On Tue, 1 Nov 2022 23:04:45 GMT, Vladimir Ivanov wrote:
>> Hmm.. interesting. Is this for loading? `evmovdquq` vs `evmovdqaq`? I was
>> actually looking at using evmovdqaq but there is no encoding for it yet (And
>> just looking now on uops.info, they seem to have identical timings? perhaps
>>
On Tue, 1 Nov 2022 23:49:17 GMT, Vladimir Ivanov wrote:
>> src/hotspot/cpu/x86/stubGenerator_x86_64.cpp line 2002:
>>
>>> 2000: }
>>> 2001:
>>> 2002: address StubGenerator::generate_poly1305_masksCP() {
>>
>> I suggest to turn it into a C++ literal constant and move the declaration
>> next to
On Tue, 1 Nov 2022 22:59:14 GMT, Mark Powers wrote:
> > Anyone from Oracle can help me to run Mach5 testing, just in case I missed
> > something?
>
> Do you have any specific mach5 tests in mind?
Please have tier 1 and tier2 covered. Thanks!
-
PR: https://git.openjdk.org/jdk/pul
On Tue, 1 Nov 2022 23:17:46 GMT, Vladimir Ivanov wrote:
>> vpaprotsk has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> invalidkeyexception and some review comments
>
> src/hotspot/cpu/x86/stubGenerator_x86_64.cpp line 2002:
>
>> 2000: }
>
On Fri, 28 Oct 2022 20:19:35 GMT, vpaprotsk wrote:
> And just looking now on uops.info, they seem to have identical timings?
Actual instruction being used (aligned vs unaligned versions) doesn't matter
much here, because it's a dynamic property of the address being accessed:
misaligned accesse
On Fri, 28 Oct 2022 20:39:44 GMT, vpaprotsk wrote:
>> Handcrafted x86_64 asm for Poly1305. Main optimization is to process 16
>> message blocks at a time. For more details, left a lot of comments in
>> `macroAssembler_x86_poly.cpp`.
>>
>> - Added new KAT test for Poly1305 and a fuzz test to co
On Mon, 31 Oct 2022 17:33:57 GMT, Xue-Lei Andrew Fan wrote:
> Anyone from Oracle can help me to run Mach5 testing, just in case I missed
> something?
Do you have any specific mach5 tests in mind?
-
PR: https://git.openjdk.org/jdk/pull/10893
Hi Carter,
I'll have to review your data more and look into it.
thanks
Tony
On 10/31/22 4:51 PM, Carter Kozak wrote:
Hello,
TLS performance has appreciably regressed in JDK-18 and JDK-19 from earlier
releases using TLS_AES_128_GCM_SHA256 and TLS_AES_256_GCM_SHA384 ciphers. I
suspect the th
On Tue, 1 Nov 2022 17:43:22 GMT, Mark Powers wrote:
>> Xue-Lei Andrew Fan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> remove tailing whitespaces
>
> src/jdk.crypto.ec/share/classes/sun/security/ec/ECOperations.java line 588:
>
>> 58
> Hi,
>
> May I have this update reviewed?
>
> The EC point multiplication for secp256r1 could be improved for better
> performance, by using more efficient algorithm and pre-computation.
> Improvement for other curves are similar, but will be addressed in separated
> PRs.
>
> The basic idea
On Mon, 31 Oct 2022 21:23:19 GMT, Stuart Marks wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add @SafeVarargs declarations
>
> src/java.base/share/classes/java/lang/template/TemplateRuntime.java line 99:
>
>> 97:
On Mon, 31 Oct 2022 15:51:23 GMT, Rémi Forax wrote:
>> Actually instance interpolate() is the most important method. Each synthetic
>> StringTemplate gets a specialized interpolate providing performance
>> equivalent to string concat. And, a good percentage of processors will work
>> with the
On Mon, 31 Oct 2022 20:50:49 GMT, Rémi Forax wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add @SafeVarargs declarations
>
> src/java.base/share/classes/java/lang/template/TemplateRuntime.java line 119:
>
>> 117:
On Mon, 31 Oct 2022 13:43:24 GMT, Jim Laskey wrote:
>> src/java.base/share/classes/java/lang/template/TemplateRuntime.java line 45:
>>
>>> 43: */
>>> 44: @PreviewFeature(feature=PreviewFeature.Feature.STRING_TEMPLATES)
>>> 45: public final class TemplateRuntime {
>>
>> Why this class is public
On Thu, 27 Oct 2022 10:04:07 GMT, Sean Coffey wrote:
> Thanks for the feedback Sean. Yes - this event should also cater for the
> internal `new X509CertImpl` type calls that are sprinkled through some of the
> security libraries.
>
> Some look a bit suspicious perhaps ? I see OCSP/CertPath typ
On Mon, 31 Oct 2022 20:11:34 GMT, Jim Laskey wrote:
>> Enhance the Java programming language with string templates, which are
>> similar to string literals but contain embedded expressions. A string
>> template is interpreted at run time by replacing each expression with the
>> result of evalu
On Fri, 28 Oct 2022 18:05:30 GMT, Xue-Lei Andrew Fan wrote:
>> Hi,
>>
>> May I have this update reviewed?
>>
>> The EC point multiplication for secp256r1 could be improved for better
>> performance, by using more efficient algorithm and pre-computation.
>> Improvement for other curves are si
On Tue, 1 Nov 2022 16:10:47 GMT, Daniel Fuchs wrote:
>> Deprecate URL constructors. Developers are encouraged to use `java.net.URI`
>> to parse or construct any URL.
>>
>> The `java.net.URL` class does not itself encode or decode any URL components
>> according to the escaping mechanism define
On Tue, 1 Nov 2022 14:47:49 GMT, Alan Bateman wrote:
>> Actually... Maybe I could move up the paragraph that says that URL
>> constructors are deprecated up here, just after the title? Would
>> that be better?
>
> Try it, it might be better. I think the main thing is that link brings the
> Deprecate URL constructors. Developers are encouraged to use `java.net.URI`
> to parse or construct any URL.
>
> The `java.net.URL` class does not itself encode or decode any URL components
> according to the escaping mechanism defined in RFC2396. It is the
> responsibility of the caller to e
On Mon, 31 Oct 2022 20:11:34 GMT, Jim Laskey wrote:
>> Enhance the Java programming language with string templates, which are
>> similar to string literals but contain embedded expressions. A string
>> template is interpreted at run time by replacing each expression with the
>> result of evalu
On Tue, 1 Nov 2022 14:22:18 GMT, Daniel Fuchs wrote:
>> To be discussed: I actually wanted the deprecation link ( the link from
>> `@deprecated` ) to lead here because I find that the whole section is
>> relevant for developers who might want to decide whether to actually move
>> away from usi
On Mon, 31 Oct 2022 13:45:10 GMT, Jim Laskey wrote:
>> Yes, it only occurs to me mid review, that said there is already an
>> implementation in the jdk of a compact immutable that allow null inside the
>> JDK (this implementation is used when stream.toList() is used).
>> Using that implementati
On Tue, 1 Nov 2022 14:10:01 GMT, Daniel Fuchs wrote:
>> src/java.base/share/classes/java/net/URL.java line 133:
>>
>>> 131: * specified. The optional fragment is not inherited.
>>> 132: *
>>> 133: * Constructing instances of
>>> {@code URL}
>>
>> Would it be better to move the anchor to lin
On Sat, 29 Oct 2022 14:24:09 GMT, Alan Bateman wrote:
>> Daniel Fuchs has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains four additional
>> commits
On Sat, 29 Oct 2022 14:17:12 GMT, Alan Bateman wrote:
>> Daniel Fuchs has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains four additional
>> commits
On Sat, 29 Oct 2022 14:16:24 GMT, Alan Bateman wrote:
>> Daniel Fuchs has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains four additional
>> commits
On Sat, 29 Oct 2022 14:14:22 GMT, Alan Bateman wrote:
>> Daniel Fuchs has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains four additional
>> commits
On Mon, 31 Oct 2022 22:00:01 GMT, Phil Race wrote:
> Deprecate URL constructors. Developers are encouraged to use java.net.URI to
> parse or construct any URL. ... To construct a URL, using URI::toURL should
> be preferred.
>
> You have jumped through some refactoring hoops to be able to apply
This code change removes `getElements()` and `delete()` from `CertAttrSet` and
all its subclasses. The `getName()` method is moved to `s.s.x.Extension` since
it's only useful there.
-
Commit messages:
- the fix
Changes: https://git.openjdk.org/jdk/pull/10934/files
Webrev: https:/
On Mon, 31 Oct 2022 20:11:34 GMT, Jim Laskey wrote:
>> Enhance the Java programming language with string templates, which are
>> similar to string literals but contain embedded expressions. A string
>> template is interpreted at run time by replacing each expression with the
>> result of evalu
On Mon, 31 Oct 2022 20:11:34 GMT, Jim Laskey wrote:
>> Enhance the Java programming language with string templates, which are
>> similar to string literals but contain embedded expressions. A string
>> template is interpreted at run time by replacing each expression with the
>> result of evalu
On Fri, 28 Oct 2022 18:20:08 GMT, Weijun Wang wrote:
> The argument of the `CertAttrSet::encode` and `DerEncoder::derEncode`
> interface methods are modified from `OutputStream` to `DerOutputStream`. All
> implementations are modified the same way.
>
> `OutputStream` is still used by
> `sun.s
On Mon, 24 Oct 2022 19:21:07 GMT, Magnus Ihse Bursie wrote:
>> Properties files is essentially source code. It should have the same
>> whitespace checks as all other source code, so we don't get spurious
>> trailing whitespace changes.
>>
>> With the new Skara jcheck, it is possible to increas
On Fri, 28 Oct 2022 19:18:23 GMT, Jim Laskey wrote:
>> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java line 4974:
>>
>>> 4972: if (processor != null) {
>>> 4973: resultType = attribTree(processor, env, new
>>> ResultInfo(KindSelector.VAL, Type.noType));
>>>
On Fri, 28 Oct 2022 17:57:30 GMT, Jim Laskey wrote:
>> Enhance the Java programming language with string templates, which are
>> similar to string literals but contain embedded expressions. A string
>> template is interpreted at run time by replacing each expression with the
>> result of evalu
On 1/11/2022 5:52 pm, Alan Bateman wrote:
On Mon, 31 Oct 2022 22:00:01 GMT, Phil Race wrote:
You have jumped through some refactoring hoops to be able to apply the
deprecation suppression to as little code as possible .. having made such
changes, then why didn't you just make the recommended
39 matches
Mail list logo
