Re: RFR: 8294241: Deprecate URL public constructors [v2]

2022-10-29 Thread Alan Bateman
On Fri, 28 Oct 2022 14:54:26 GMT, Daniel Fuchs wrote: >> Deprecate URL constructors. Developers are encouraged to use `java.net.URI` >> to parse or construct any URL. >> >> The `java.net.URL` class does not itself encode or decode any URL components >> according to the escaping mechanism defin

Re: RFR: 8295729: Add jcheck whitespace checking for properties files [v3]

2022-10-29 Thread Alexey Ivanov
On Mon, 24 Oct 2022 19:21:07 GMT, Magnus Ihse Bursie wrote: >> Properties files is essentially source code. It should have the same >> whitespace checks as all other source code, so we don't get spurious >> trailing whitespace changes. >> >> With the new Skara jcheck, it is possible to increas

Re: RFR: 8295729: Add jcheck whitespace checking for properties files [v3]

2022-10-29 Thread Alexey Ivanov
On Mon, 24 Oct 2022 19:29:41 GMT, Andy Goryachev wrote: >> Magnus Ihse Bursie has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Revert "Remove check for .properties from jcheck" >> >>This reverts commit c91fdaa19dc06351598bd1c061

Re: RFR: 8294241: Deprecate URL public constructors [v2]

2022-10-29 Thread Jaikiran Pai
On Wed, 26 Oct 2022 17:51:31 GMT, Daniel Fuchs wrote: >> I see your point. It may be more appropriate if URI.toURL was designed as >> URL.fromURL. >> >> I was wondering to have application developers a consistent way to get an >> URL instance. Now there are two methods in different classes U

Re: RFR: 8294241: Deprecate URL public constructors [v2]

2022-10-29 Thread Jaikiran Pai
On Thu, 27 Oct 2022 11:24:32 GMT, Daniel Fuchs wrote: >> How about `_unused` or `_unused1`, `_unused2` then in the meantime? > > I'd be happy to make the change. Let's wait to see if anybody has a better > naming suggestion. Hello Daniel, I think calling it `unused` is fine. I did a quick searc