Re: RFR: 8294241: Deprecate URL public constructors

2022-10-26 Thread Alan Bateman
On 26/10/2022 23:53, Peter Firmstone wrote: The change will have some performance impact, by requiring redundant parsing. Just thought I'd mention it, in case it hasn't been thought of. If you do an internet search there are other implementations of RFC3986 in java also. https://github.com/

Re: RFR: 8294241: Deprecate URL public constructors

2022-10-26 Thread ExE Boss
On Wed, 26 Oct 2022 16:41:29 GMT, Michael McMahon wrote: >> Deprecate URL constructors. Developers are encouraged to use `java.net.URI` >> to parse or construct any URL. >> >> The `java.net.URL` class does not itself encode or decode any URL components >> according to the escaping mechanism de

Re: Clogged pipes: 50x throughput degradation with large Cipher writes

2022-10-26 Thread Bernd
Hello,good that you look into that topic. While it might not be a problem in practice (large buffers are ok, but larger than 1mb seems seldom, especially in multi threaded apps) it is still a condition which can be handled. But with AE ciphers becoming the norm, such large

Re: RFR: 8294241: Deprecate URL public constructors

2022-10-26 Thread Peter Firmstone
Interesting.  Is this RFR a done deal? While I like the concept and and understand the reasoning of URL not having a public constructor, I think this may have been thought of in isolation, I'm not sure how a custom URI, that strictly complies with RFC 3986 will behave, if it must also be parse

Re: Request - Preparation for removal of SecurityManager

2022-10-26 Thread Peter Firmstone
Thanks Alan, comments inline below. On 26/10/2022 11:07 pm, Alan Bateman wrote: : What would make a significant difference is returning non null ProtectionDomain's for JDK modules, so we can reduce the size of the trusted computing base, to make our job smaller, hopefully that will allow

Re: RFR: 8288047: Accelerate Poly1305 on x86_64 using AVX512 instructions [v5]

2022-10-26 Thread Jamil Nimeh
On Wed, 26 Oct 2022 20:45:57 GMT, Jamil Nimeh wrote: >> (The first commit in this PR actually has the code without the check if >> anyone wants to measure.. well its also trivial to edit..) >> >> I measured about 50% slowdown on 64 byte payloads. One could argue that 64 >> bytes is not all tha

Re: RFR: 8288047: Accelerate Poly1305 on x86_64 using AVX512 instructions [v5]

2022-10-26 Thread Jamil Nimeh
On Wed, 26 Oct 2022 15:47:08 GMT, vpaprotsk wrote: >> src/java.base/share/classes/com/sun/crypto/provider/Poly1305.java line 171: >> >>> 169: } >>> 170: >>> 171: if (len >= 1024) { >> >> Out of curiosity, do you have any perf numbers for the impact of this change >> on systems

Re: RFR: 8294241: Deprecate URL public constructors

2022-10-26 Thread Daniel Fuchs
On Wed, 26 Oct 2022 17:39:56 GMT, Xue-Lei Andrew Fan wrote: >> `URLStreamHandler` really belongs to `java.net.URL`, and is an >> implementation detail of the infrastructure/SPI that makes it possible to >> eventually call `URL::openConnection`. I do not think it would be >> appropriate to have

Re: RFR: 8294241: Deprecate URL public constructors

2022-10-26 Thread Xue-Lei Andrew Fan
On Wed, 26 Oct 2022 17:24:59 GMT, Daniel Fuchs wrote: >> src/java.base/share/classes/java/net/URL.java line 852: >> >>> 850: * @since 20 >>> 851: */ >>> 852: public static URL fromURI(URI uri, URLStreamHandler streamHandler) >> >> What do you think to have this method in URI inste

Re: RFR: 8294241: Deprecate URL public constructors

2022-10-26 Thread Daniel Fuchs
On Wed, 26 Oct 2022 17:09:20 GMT, Xue-Lei Andrew Fan wrote: >> Deprecate URL constructors. Developers are encouraged to use `java.net.URI` >> to parse or construct any URL. >> >> The `java.net.URL` class does not itself encode or decode any URL components >> according to the escaping mechanism

Re: RFR: 8294241: Deprecate URL public constructors

2022-10-26 Thread Xue-Lei Andrew Fan
On Wed, 26 Oct 2022 16:00:56 GMT, Daniel Fuchs wrote: > Deprecate URL constructors. Developers are encouraged to use `java.net.URI` > to parse or construct any URL. > > The `java.net.URL` class does not itself encode or decode any URL components > according to the escaping mechanism defined in

Re: RFR: 8295953: Use enhanced-for cycle instead of Enumeration in sun.security

2022-10-26 Thread Andrey Turbanov
On Tue, 18 Oct 2022 17:43:53 GMT, Weijun Wang wrote: >> java.util.Enumeration is a legacy interface from java 1.0. >> There are a few places with cycles which use it to iterate over collections. >> We can replace this manual cycle with enchanced-for, which is shorter and >> easier to read. > >

Re: RFR: 8295953: Use enhanced-for cycle instead of Enumeration in sun.security

2022-10-26 Thread Weijun Wang
On Thu, 20 Oct 2022 11:21:41 GMT, Andrey Turbanov wrote: >> src/java.base/share/classes/sun/security/x509/X509CRLEntryImpl.java line 412: >> >>> 410: ObjectIdentifier findOID = ObjectIdentifier.of(oid); >>> 411: for (Extension ex : extensions.getAllExtensions()) {

RFR: 8295953: Use enhanced-for cycle instead of Enumeration in sun.security

2022-10-26 Thread Andrey Turbanov
java.util.Enumeration is a legacy interface from java 1.0. There are a few places with cycles which use it to iterate over collections. We can replace this manual cycle with enchanced-for, which is shorter and easier to read. - Commit messages: - [PATCH] Use enhanced-for cycle inst

Re: RFR: 8295953: Use enhanced-for cycle instead of Enumeration in sun.security

2022-10-26 Thread Weijun Wang
On Mon, 17 Oct 2022 21:50:08 GMT, Andrey Turbanov wrote: > java.util.Enumeration is a legacy interface from java 1.0. > There are a few places with cycles which use it to iterate over collections. > We can replace this manual cycle with enchanced-for, which is shorter and > easier to read. src

Re: RFR: 8294241: Deprecate URL public constructors

2022-10-26 Thread Michael McMahon
On Wed, 26 Oct 2022 16:00:56 GMT, Daniel Fuchs wrote: > Deprecate URL constructors. Developers are encouraged to use `java.net.URI` > to parse or construct any URL. > > The `java.net.URL` class does not itself encode or decode any URL components > according to the escaping mechanism defined in

Re: RFR: 8294241: Deprecate URL public constructors

2022-10-26 Thread Weijun Wang
On Wed, 26 Oct 2022 16:00:56 GMT, Daniel Fuchs wrote: > Deprecate URL constructors. Developers are encouraged to use `java.net.URI` > to parse or construct any URL. > > The `java.net.URL` class does not itself encode or decode any URL components > according to the escaping mechanism defined in

RFR: 8294241: Deprecate URL public constructors

2022-10-26 Thread Daniel Fuchs
Deprecate URL constructors. Developers are encouraged to use `java.net.URI` to parse or construct any URL. The `java.net.URL` class does not itself encode or decode any URL components according to the escaping mechanism defined in RFC2396. It is the responsibility of the caller to encode any fi

Integrated: JDK-8293093 NPE in P11KeyStore.getID

2022-10-26 Thread Mark Powers
On Fri, 21 Oct 2022 19:54:57 GMT, Mark Powers wrote: > https://bugs.openjdk.org/browse/JDK-8293093 This pull request has now been integrated. Changeset: 8e5d680a Author:Mark Powers Committer: Anthony Scarpino URL: https://git.openjdk.org/jdk/commit/8e5d680a98ad28eb3607d227783bdea94

Re: RFR: 8288047: Accelerate Poly1305 on x86_64 using AVX512 instructions [v5]

2022-10-26 Thread vpaprotsk
On Tue, 25 Oct 2022 21:48:47 GMT, Jamil Nimeh wrote: >> vpaprotsk has updated the pull request incrementally with one additional >> commit since the last revision: >> >> extra whitespace character > > src/java.base/share/classes/com/sun/crypto/provider/Poly1305.java line 171: > >> 169:

Re: RFR: 8288047: Accelerate Poly1305 on x86_64 using AVX512 instructions [v5]

2022-10-26 Thread vpaprotsk
On Tue, 25 Oct 2022 23:48:49 GMT, Sandhya Viswanathan wrote: >> vpaprotsk has updated the pull request incrementally with one additional >> commit since the last revision: >> >> extra whitespace character > > src/hotspot/cpu/x86/macroAssembler_x86_poly.cpp line 806: > >> 804: evmovdquq(A0

Re: RFR: 8288047: Accelerate Poly1305 on x86_64 using AVX512 instructions [v5]

2022-10-26 Thread vpaprotsk
On Tue, 25 Oct 2022 21:57:34 GMT, Jamil Nimeh wrote: >> vpaprotsk has updated the pull request incrementally with one additional >> commit since the last revision: >> >> extra whitespace character > > src/java.base/share/classes/com/sun/crypto/provider/Poly1305.java line 296: > >> 294:

Re: RFR: JDK-8295405 : Add cause in a couple of IllegalArgumentException and InvalidParameterException shown by sun/security/pkcs11 tests [v2]

2022-10-26 Thread Sean Mullan
You are currently receiving this informational message with the original email attached. We need your help in notifying the team or sender responsible for this mail flow to ensure future email is delivered properly. The host that sent this message is not compliant with Oracle's email security p

Re: RFR: JDK-8295405 : Add cause in a couple of IllegalArgumentException and InvalidParameterException shown by sun/security/pkcs11 tests [v2]

2022-10-26 Thread Sean Mullan
You are currently receiving this informational message with the original email attached. We need your help in notifying the team or sender responsible for this mail flow to ensure future email is delivered properly. The host that sent this message is not compliant with Oracle's email security p

Re: RFR: JDK-8295405 : Add cause in a couple of IllegalArgumentException and InvalidParameterException shown by sun/security/pkcs11 tests [v2]

2022-10-26 Thread Sean Mullan
You are currently receiving this informational message with the original email attached. We need your help in notifying the team or sender responsible for this mail flow to ensure future email is delivered properly. The host that sent this message is not compliant with Oracle's email security p

Clogged pipes: 50x throughput degradation with large Cipher writes

2022-10-26 Thread Carter Kozak
Continuing a conversation I had with Sean Mullan at Java One, for a broader audience. We tend to believe that bulk operations are good. Large bulk operations give the system the most information at once, allowing it to make more informed decisions. Understanding the hotspot compiler on some lev

Re: RFR: JDK-8295405 : Add cause in a couple of IllegalArgumentException and InvalidParameterException shown by sun/security/pkcs11 tests [v2]

2022-10-26 Thread Matthias Baesken
On Wed, 26 Oct 2022 14:22:08 GMT, Martin Doerr wrote: > Change looks good. Does it need a CSR? Hi Martin , from what I read here https://wiki.openjdk.org/display/csr/CSR+FAQs no CSR is needed. But I am no expert on the topic so maybe someone else has an opinion on this ? While looking at t

Re: RFR: JDK-8295405 : Add cause in a couple of IllegalArgumentException and InvalidParameterException shown by sun/security/pkcs11 tests [v2]

2022-10-26 Thread Martin Doerr
On Tue, 18 Oct 2022 14:55:12 GMT, Matthias Baesken wrote: >> We have a number of failing sun/security/pkcs11 test on RHEL 8.6, see >> >> https://bugs.openjdk.org/browse/JDK-8295343 >> 8295343 : sun/security/pkcs11 tests fail on Linux RHEL 8.6 >> >> The exceptions generated by these tests someti

Re: Request - Preparation for removal of SecurityManager

2022-10-26 Thread Alan Bateman
On 26/10/2022 09:02, Peter Firmstone wrote: : That's correct, however some parts will bit rot faster than others, historically some parts of the JDK are very slow to change, unless someone comes through deliberately removing them, which I would hope not, but I realise that new methods and

Re: Request - Preparation for removal of SecurityManager

2022-10-26 Thread Peter Firmstone
Thanks Alan, That's correct, however some parts will bit rot faster than others, historically some parts of the JDK are very slow to change, unless someone comes through deliberately removing them, which I would hope not, but I realise that new methods and classes might open new code paths th