Re: RFR: 8295729: Add jcheck whitespace checking for properties files

2022-10-20 Thread Naoto Sato
On Thu, 20 Oct 2022 11:58:58 GMT, Magnus Ihse Bursie wrote: > Properties files is essentially source code. It should have the same > whitespace checks as all other source code, so we don't get spurious trailing > whitespace changes. > > With the new Skara jcheck, it is possible to increase the

Re: RFR: 8295729: Add jcheck whitespace checking for properties files

2022-10-20 Thread Naoto Sato
On Thu, 20 Oct 2022 11:58:58 GMT, Magnus Ihse Bursie wrote: > Properties files is essentially source code. It should have the same > whitespace checks as all other source code, so we don't get spurious trailing > whitespace changes. > > With the new Skara jcheck, it is possible to increase the

Re: RFR: 8295729: Add jcheck whitespace checking for properties files

2022-10-20 Thread Magnus Ihse Bursie
On Thu, 20 Oct 2022 11:58:58 GMT, Magnus Ihse Bursie wrote: > Properties files is essentially source code. It should have the same > whitespace checks as all other source code, so we don't get spurious trailing > whitespace changes. > > With the new Skara jcheck, it is possible to increase the

Re: RFR: 8295729: Add jcheck whitespace checking for properties files

2022-10-20 Thread Erik Joelsson
On Thu, 20 Oct 2022 11:58:58 GMT, Magnus Ihse Bursie wrote: > Properties files is essentially source code. It should have the same > whitespace checks as all other source code, so we don't get spurious trailing > whitespace changes. > > With the new Skara jcheck, it is possible to increase the

Re: RFR: 8295729: Add jcheck whitespace checking for properties files

2022-10-20 Thread Andy Goryachev
On Thu, 20 Oct 2022 18:46:04 GMT, Magnus Ihse Bursie wrote: >> I would vote against this change. Per java properties spec >> https://github.com/openjdk/jdk/pull/10792 >> >> >> White space following the property value is not ignored, and is treated as >> part of the property value. >> >> >>

Re: RFR: 8295729: Add jcheck whitespace checking for properties files

2022-10-20 Thread Chris Plummer
On Thu, 20 Oct 2022 18:38:43 GMT, Andy Goryachev wrote: > `White space following the property value is not ignored, and is treated as > part of the property value.` Although I didn't know this was in the spec, I suspected it might be the case. When looking at the jdk.management.agent changes,

Re: RFR: 8295729: Add jcheck whitespace checking for properties files

2022-10-20 Thread Magnus Ihse Bursie
On Thu, 20 Oct 2022 18:38:43 GMT, Andy Goryachev wrote: >> Properties files is essentially source code. It should have the same >> whitespace checks as all other source code, so we don't get spurious >> trailing whitespace changes. >> >> With the new Skara jcheck, it is possible to increase th

Re: RFR: 8295729: Add jcheck whitespace checking for properties files

2022-10-20 Thread Andy Goryachev
On Thu, 20 Oct 2022 11:58:58 GMT, Magnus Ihse Bursie wrote: > Properties files is essentially source code. It should have the same > whitespace checks as all other source code, so we don't get spurious trailing > whitespace changes. > > With the new Skara jcheck, it is possible to increase the

Re: RFR: 8295729: Add jcheck whitespace checking for properties files

2022-10-20 Thread Naoto Sato
On Thu, 20 Oct 2022 11:58:58 GMT, Magnus Ihse Bursie wrote: > Properties files is essentially source code. It should have the same > whitespace checks as all other source code, so we don't get spurious trailing > whitespace changes. > > With the new Skara jcheck, it is possible to increase the

Re: RFR: 8295729: Add jcheck whitespace checking for properties files

2022-10-20 Thread Erik Joelsson
On Thu, 20 Oct 2022 11:58:58 GMT, Magnus Ihse Bursie wrote: > Properties files is essentially source code. It should have the same > whitespace checks as all other source code, so we don't get spurious trailing > whitespace changes. > > With the new Skara jcheck, it is possible to increase the

Re: RFR: 8295716: Minimize disabled warnings in security libs

2022-10-20 Thread Erik Joelsson
On Thu, 20 Oct 2022 10:19:38 GMT, Magnus Ihse Bursie wrote: > After JDK-8294281, it is now possible to disable warnings for individual > files instead for whole libraries. I used this opportunity to go through all > disabled warnings in the security native libraries. > > Any warnings that were

RFR: 8295729: Add jcheck whitespace checking for properties files

2022-10-20 Thread Magnus Ihse Bursie
Properties files is essentially source code. It should have the same whitespace checks as all other source code, so we don't get spurious trailing whitespace changes. With the new Skara jcheck, it is possible to increase the coverage of the whitespace checks (in the old mercurial version, this

Integrated: 8295470: Update openjdk.java.net => openjdk.org URLs in test code

2022-10-20 Thread Magnus Ihse Bursie
On Tue, 18 Oct 2022 11:55:06 GMT, Magnus Ihse Bursie wrote: > This is a continuation of the effort to update all our URLs to the new > top-level domain. > > This patch updates (most) URLs in testing code. There still exists references > to openjdk.java.net, but that are not strictly used as no