Re: RFR: JDK-8293681 ResponseAPDU getData() method javadoc

2022-10-17 Thread Valerie Peng
On Mon, 17 Oct 2022 17:45:13 GMT, Mark Powers wrote: > https://bugs.openjdk.org/browse/JDK-8293681 Looks good. Thanks~ - Marked as reviewed by valeriep (Reviewer). PR: https://git.openjdk.org/jdk/pull/10732

Integrated: 8295231: Move all linking of native libraries to make

2022-10-17 Thread Julian Waters
On Mon, 10 Oct 2022 14:15:37 GMT, Julian Waters wrote: > Some external libraries required by native code are linked via linker > comments embedded in pragmas. Searching for which libraries are linked can > then become frustrating and confusing since they may be included in an > obscure place,

RFR: JDK-8293681 ResponseAPDU getData() method javadoc

2022-10-17 Thread Mark Powers
https://bugs.openjdk.org/browse/JDK-8293681 - Commit messages: - first iteration Changes: https://git.openjdk.org/jdk/pull/10732/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=10732&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8293681 Stats: 2 lines in 1 file cha

Re: RFR: 8295231: Move all linking of native libraries to make [v6]

2022-10-17 Thread Alexey Semenyuk
On Mon, 17 Oct 2022 17:37:11 GMT, Erik Joelsson wrote: > I believe this is part of the effort for > https://bugs.openjdk.org/browse/JDK-8288293. Agree. I'd prefer to have a different description of the bug though to make it clear that this is necessary for decoupling a compiler and an OS. ---

Re: RFR: 8295231: Move all linking of native libraries to make [v6]

2022-10-17 Thread Erik Joelsson
On Mon, 17 Oct 2022 17:16:21 GMT, Alexey Semenyuk wrote: > The change looks harmless. Howevere I don't understand how searching for the > standard Windows libs can then become frustrating. I believe this is part of the effort for https://bugs.openjdk.org/browse/JDK-8288293. - PR:

Re: RFR: 8295231: Move all linking of native libraries to make [v6]

2022-10-17 Thread Erik Joelsson
On Mon, 17 Oct 2022 14:41:06 GMT, Julian Waters wrote: >> Some external libraries required by native code are linked via linker >> comments embedded in pragmas. Searching for which libraries are linked can >> then become frustrating and confusing since they may be included in an >> obscure pla

Re: RFR: 8295231: Move all linking of native libraries to make [v6]

2022-10-17 Thread Alexey Semenyuk
On Mon, 17 Oct 2022 14:41:06 GMT, Julian Waters wrote: >> Some external libraries required by native code are linked via linker >> comments embedded in pragmas. Searching for which libraries are linked can >> then become frustrating and confusing since they may be included in an >> obscure pla

Re: RFR: JDK-8295405 : Add cause in a couple of IllegalArgumentException and InvalidParameterException shown by sun/security/pkcs11 tests

2022-10-17 Thread Mark Powers
On Mon, 17 Oct 2022 10:42:18 GMT, Matthias Baesken wrote: > We have a number of failing sun/security/pkcs11 test on RHEL 8.6, see > > https://bugs.openjdk.org/browse/JDK-8295343 > 8295343 : sun/security/pkcs11 tests fail on Linux RHEL 8.6 > > The exceptions generated by these tests sometimes mi

Re: RFR: JDK-8295087: Manual Test to Automated Test Conversion [v3]

2022-10-17 Thread Bill Huang
> This task converts 5 manual tests to automated tests. > > sun/security/provider/PolicyParser/ExtDirsDefaultPolicy.java > sun/security/provider/PolicyParser/ExtDirsChange.java > sun/security/provider/PolicyParser/ExtDirs.java > java/security/Policy/Root/Root.javajava/security/Policy/Root/Root.

Re: RFR: JDK-8295087: Manual Test to Automated Test Conversion [v2]

2022-10-17 Thread Bill Huang
On Fri, 14 Oct 2022 15:50:30 GMT, Bill Huang wrote: >> test/jdk/java/security/Policy/Root/Root.java line 48: >> >>> 46: private static final Path TARGET = Paths.get(ROOT, ".java.policy"); >>> 47: public static void main(String[] args) throws Exception { >>> 48: Files.copy(SOURCE,

Re: RFR: JDK-8295087: Manual Test to Automated Test Conversion [v2]

2022-10-17 Thread Bill Huang
> This task converts 5 manual tests to automated tests. > > sun/security/provider/PolicyParser/ExtDirsDefaultPolicy.java > sun/security/provider/PolicyParser/ExtDirsChange.java > sun/security/provider/PolicyParser/ExtDirs.java > java/security/Policy/Root/Root.javajava/security/Policy/Root/Root.

Re: RFR: 8290368: Introduce LDAP and RMI protocol-specific object factory filters to JNDI implementation [v5]

2022-10-17 Thread Aleksei Efimov
On Fri, 14 Oct 2022 17:45:50 GMT, Roger Riggs wrote: > In the general composition of filters, it is preferable that UNDECIDED is > treated as REJECTED. > That keeps unintentional holes in a filter from being permissive. That is a good point Roger. The "java.security" file was updated (4449dda)

Re: RFR: 8290368: Introduce LDAP and RMI protocol-specific object factory filters to JNDI implementation [v6]

2022-10-17 Thread Aleksei Efimov
> ### Summary of the change > This change introduces new system and security properties for specifying > factory filters for the JNDI/LDAP and the JNDI/RMI JDK provider > implementations. > > These new properties allow more granular control over the set of object > factories allowed to reconst

Re: RFR: 8295231: Move all linking of native libraries to make [v6]

2022-10-17 Thread Julian Waters
> Some external libraries required by native code are linked via linker > comments embedded in pragmas. Searching for which libraries are linked can > then become frustrating and confusing since they may be included in an > obscure place, and for all relevant compilers there is no difference bet

Re: RFR: 8295231: Move all linking of native libraries to make [v4]

2022-10-17 Thread Julian Waters
On Mon, 17 Oct 2022 14:31:46 GMT, Julian Waters wrote: >> Some external libraries required by native code are linked via linker >> comments embedded in pragmas. Searching for which libraries are linked can >> then become frustrating and confusing since they may be included in an >> obscure pla

Re: RFR: 8295231: Move all linking of native libraries to make [v5]

2022-10-17 Thread Julian Waters
> Some external libraries required by native code are linked via linker > comments embedded in pragmas. Searching for which libraries are linked can > then become frustrating and confusing since they may be included in an > obscure place, and for all relevant compilers there is no difference bet

Re: RFR: 8295231: Move all linking of native libraries to make [v4]

2022-10-17 Thread Julian Waters
> Some external libraries required by native code are linked via linker > comments embedded in pragmas. Searching for which libraries are linked can > then become frustrating and confusing since they may be included in an > obscure place, and for all relevant compilers there is no difference bet

Re: RFR: 8295231: Move all linking of native libraries to make [v3]

2022-10-17 Thread Julian Waters
On Sun, 16 Oct 2022 13:18:14 GMT, Alan Bateman wrote: >> Julian Waters has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update Guid.cpp > > src/java.base/windows/native/libnio/ch/FileDispatcherImpl.c line 38: > >> 36: >> 37: #include >

Re: RFR: 8295231: Move all linking of native libraries to make [v3]

2022-10-17 Thread Julian Waters
> Some external libraries required by native code are linked via linker > comments embedded in pragmas. Searching for which libraries are linked can > then become frustrating and confusing since they may be included in an > obscure place, and for all relevant compilers there is no difference bet

Re: RFR: 8295231: Move all linking of native libraries to make [v2]

2022-10-17 Thread Julian Waters
> Some external libraries required by native code are linked via linker > comments embedded in pragmas. Searching for which libraries are linked can > then become frustrating and confusing since they may be included in an > obscure place, and for all relevant compilers there is no difference bet

Re: RFR: 8295231: Move all linking of native libraries to make

2022-10-17 Thread Julian Waters
On Mon, 17 Oct 2022 09:24:58 GMT, Magnus Ihse Bursie wrote: > @TheShermanTanker Question: is this a Windows-specific thing, or are there > pragma-loaded libraries for other compilers as well? To my knowledge only Visual C++ has the ability to perform linking through pragmas, the comment pragma

RFR: JDK-8295405 : Add cause in a couple of IllegalArgumentException and InvalidParameterException shown by sun/security/pkcs11 tests

2022-10-17 Thread Matthias Baesken
We have a number of failing sun/security/pkcs11 test on RHEL 8.6, see https://bugs.openjdk.org/browse/JDK-8295343 8295343 : sun/security/pkcs11 tests fail on Linux RHEL 8.6 The exceptions generated by these tests sometimes miss the cause (causing exception), it would be nice to have this added t

Re: RFR: 8295231: Move all linking of native libraries to make

2022-10-17 Thread Magnus Ihse Bursie
On Mon, 10 Oct 2022 14:15:37 GMT, Julian Waters wrote: > Some external libraries required by native code are linked via linker > comments embedded in pragmas. Searching for which libraries are linked can > then become frustrating and confusing since they may be included in an > obscure place,