Re: RFR: 8294848: Unnecessary SSLCipher dispose implementations

2022-10-05 Thread Valerie Peng
On Wed, 5 Oct 2022 11:24:57 GMT, Daniel Jeliński wrote: > This PR removes the implementation of `dispose()` method for AEAD SSLCiphers. > > Invocations of > [readCipher.dispose](https://github.com/openjdk/jdk/blob/4cec141a90bc5d3b8ec17c024291d9c74a112cd4/src/java.base/share/classes/sun/security

Re: RFR: 8293810: Remove granting of RuntimePermission("stopThread") from tests

2022-10-05 Thread Mandy Chung
On Wed, 5 Oct 2022 15:01:15 GMT, Alan Bateman wrote: > This is a test only change to remove the granting of > RuntimePermission("stopThread") from the tests. With Thread.stop changed to > throw UOE it means there is nothing that requires this permission. LGTM - Marked as reviewed

Re: RFR: 8294821: Class load improvement for AES crypto engine

2022-10-05 Thread Xue-Lei Andrew Fan
On Wed, 5 Oct 2022 17:44:39 GMT, Daniel Fuchs wrote: > I wonder if it would be worthwhile to have a static method that could be > called in an assert (or in a test using --patch-module) to verify that the > various statically initialized arrays are the same than those that would have > been co

Re: RFR: 8294821: Class load improvement for AES crypto engine

2022-10-05 Thread Daniel Fuchs
On Wed, 5 Oct 2022 05:43:32 GMT, Xue-Lei Andrew Fan wrote: > Hi, > > May I have the code clean up reviewed? > > There is a lot of computation in AESCrypt class load, which could be avoid by > using the computation result directly. The computation takes 6.971875 > milliseconds in a MacOS M1 l

Re: RFR: 8294731: Improve multiplicative inverse for secp256r1 implementation [v2]

2022-10-05 Thread Xue-Lei Andrew Fan
> Hi, > > May I have this patch reviewed? > > This is one of a few steps to improve the EC performance. The multiplicative > inverse implementation could be improved for better performance. > > For secp256r1 prime p, the current multiplicative inverse impl needs 256 > square and 128 multipli

Integrated: 8294734: Redundant override in AES implementation

2022-10-05 Thread Xue-Lei Andrew Fan
On Mon, 3 Oct 2022 19:18:20 GMT, Xue-Lei Andrew Fan wrote: > Hi, > > May I have this simple code clean-up patch reviewed? > > In the AES cipher implementation, the override of engineDoFinal() method in > the following code is not necessary as it only calls super. The throws > descriptions ar

RFR: 8294821: Class load improvement for AES crypto engine

2022-10-05 Thread Xue-Lei Andrew Fan
Hi, May I have the code clean up reviewed? There is a lot of computation in AESCrypt class load, which could be avoid by using the computation result directly. The computation takes 6.971875 milliseconds in a MacOS M1 laptop. Although it is a one-time computation, but removing the computation

Re: RFR: 8294848: Unnecessary SSLCipher dispose implementations

2022-10-05 Thread Xue-Lei Andrew Fan
On Wed, 5 Oct 2022 11:24:57 GMT, Daniel Jeliński wrote: > This PR removes the implementation of `dispose()` method for AEAD SSLCiphers. > > Invocations of > [readCipher.dispose](https://github.com/openjdk/jdk/blob/4cec141a90bc5d3b8ec17c024291d9c74a112cd4/src/java.base/share/classes/sun/security

Integrated: JDK-8294618: Update openjdk.java.net => openjdk.org

2022-10-05 Thread Joe Darcy
On Fri, 30 Sep 2022 00:33:57 GMT, Joe Darcy wrote: > With the domain change from openjdk.java.net to openjdk.org, references to > URLs in the sources should be updated. > > Updates were made using a shell script. I"ll run a copyright updater before > any push. This pull request has now been i

Re: RFR: JDK-8294618: Update openjdk.java.net => openjdk.org [v9]

2022-10-05 Thread Joe Darcy
> With the domain change from openjdk.java.net to openjdk.org, references to > URLs in the sources should be updated. > > Updates were made using a shell script. I"ll run a copyright updater before > any push. Joe Darcy has updated the pull request with a new target base due to a merge or a re

Re: RFR: 8293810: Remove granting of RuntimePermission("stopThread") from tests

2022-10-05 Thread Sean Mullan
On Wed, 5 Oct 2022 15:01:15 GMT, Alan Bateman wrote: > This is a test only change to remove the granting of > RuntimePermission("stopThread") from the tests. With Thread.stop changed to > throw UOE it means there is nothing that requires this permission. Marked as reviewed by mullan (Reviewer)

Re: RFR: 8293810: Remove granting of RuntimePermission("stopThread") from tests

2022-10-05 Thread Daniel Fuchs
On Wed, 5 Oct 2022 15:01:15 GMT, Alan Bateman wrote: > This is a test only change to remove the granting of > RuntimePermission("stopThread") from the tests. With Thread.stop changed to > throw UOE it means there is nothing that requires this permission. Changes to java.net and javax.managemen

RFR: 8290368: Introduce LDAP and RMI protocol-specific object factory filters to JNDI implementation

2022-10-05 Thread Aleksei Efimov
### Summary of the change This change introduces new system and security properties for specifying factory filters for the JNDI/LDAP and the JNDI/RMI JDK provider implementations. These new properties allow more granular control over the set of object factories allowed to reconstruct Java obje

RFR: 8293810: Remove granting of RuntimePermission("stopThread") from tests

2022-10-05 Thread Alan Bateman
This is a test only change to remove the granting of RuntimePermission("stopThread") from the tests. With Thread.stop changed to throw UOE it means there is nothing that requires this permission. - Commit messages: - Initial commit Changes: https://git.openjdk.org/jdk/pull/10577/f

Re: RFR: 8294321: Fix typos in files under test/jdk/java, test/jdk/jdk, test/jdk/jni [v2]

2022-10-05 Thread Alexey Ivanov
On Mon, 26 Sep 2022 16:51:36 GMT, Michael Ernst wrote: >> 8294321: Fix typos in files under test/jdk/java, test/jdk/jdk, test/jdk/jni > > Michael Ernst has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains six commits: > > - Reinstate t

Re: RFR: 8294321: Fix typos in files under test/jdk/java, test/jdk/jdk, test/jdk/jni [v2]

2022-10-05 Thread Alexey Ivanov
On Mon, 26 Sep 2022 16:51:36 GMT, Michael Ernst wrote: >> 8294321: Fix typos in files under test/jdk/java, test/jdk/jdk, test/jdk/jni > > Michael Ernst has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains six commits: > > - Reinstate t

RFR: 8294848: Unnecessary SSLCipher dispose implementations

2022-10-05 Thread Daniel Jeliński
This PR removes the implementation of `dispose()` method for AEAD SSLCiphers. Invocations of [readCipher.dispose](https://github.com/openjdk/jdk/blob/4cec141a90bc5d3b8ec17c024291d9c74a112cd4/src/java.base/share/classes/sun/security/ssl/InputRecord.java#L118) and [disposeWriteCipher](https://git

Re: RFR: JDK-8294618: Update openjdk.java.net => openjdk.org [v8]

2022-10-05 Thread Magnus Ihse Bursie
On Mon, 3 Oct 2022 20:37:11 GMT, Joe Darcy wrote: >> With the domain change from openjdk.java.net to openjdk.org, references to >> URLs in the sources should be updated. >> >> Updates were made using a shell script. I"ll run a copyright updater before >> any push. > > Joe Darcy has updated the