On Fri, 26 Aug 2022 15:48:55 GMT, Lance Andersen wrote:
> Please review this PR which updates the JarInputStream class description to
> clarify when the Manifest is accessible via JarInputStream::getManifest and
> JarInputStream::get[Jar]Entry.
>
> It is worth noting that with this update, we
On Fri, 23 Sep 2022 17:45:26 GMT, Sean Mullan wrote:
> Do you also want to say "Otherwise, the method returns `null`."
The method description has that already, it might be too much detail to include
in the class description,.
-
PR: https://git.openjdk.org/jdk/pull/10045
On Tue, 20 Sep 2022 18:08:23 GMT, Lance Andersen wrote:
>> Please review this PR which updates the JarInputStream class description to
>> clarify when the Manifest is accessible via JarInputStream::getManifest and
>> JarInputStream::get[Jar]Entry.
>>
>> It is worth noting that with this updat
On Wed, 28 Sep 2022 08:12:09 GMT, Ferenc Rakoczi wrote:
>> Hi,
>>
>> In the message digest implementation, for example SHA256, in JDK, two
>> bitwise operations could be improved with equivalent arithmetic, and then
>> the number bitwise operations could be reduced accordingly. Specifically
>
On Wed, 28 Sep 2022 12:52:02 GMT, Sean Coffey wrote:
>> Ok, just so I understand, you want to make sure that if JFR is started after
>> the security properties have already been read, then they are still
>> recorded, right?
>
> Correct - this type of event period (beginChunk) will fire once whe
On Wed, 28 Sep 2022 15:26:13 GMT, Alexey Ivanov wrote:
> The title says under `test/jdk/*`, yet there are lots of files changed in
> `src/*`.
The title was edited by someone other than me, as you can see from the PR
history.
-
PR: https://git.openjdk.org/jdk/pull/10029
On Mon, 26 Sep 2022 16:51:36 GMT, Michael Ernst wrote:
>> 8294321: Fix typos in files under test/jdk/java, test/jdk/jdk, test/jdk/jni
>
> Michael Ernst has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains six commits:
>
> - Reinstate t
On Wed, 28 Sep 2022 14:45:54 GMT, Michael Ernst wrote:
>> Michael Ernst has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains six commits:
>>
>> - Reinstate typos in Apache code that is copied into the JDK
>> - Merge ../jdk-openjdk in
On Mon, 26 Sep 2022 16:51:36 GMT, Michael Ernst wrote:
>> 8294321: Fix typos in files under test/jdk/java, test/jdk/jdk, test/jdk/jni
>
> Michael Ernst has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains six commits:
>
> - Reinstate t
On Tue, 27 Sep 2022 23:12:43 GMT, Michael Ernst wrote:
> Feel free to break up the pull request if that is what is needed to free it
> from red tape.
Only you can do that @mernst
-
PR: https://git.openjdk.org/jdk/pull/10029
On Wed, 28 Sep 2022 12:26:49 GMT, Sean Mullan wrote:
>> Yes - the thinking here is that since this is a one time event, we can have
>> it enabled. It's similar to the InitialSystemProperty event.
>>
>> We won't force loading of Security properties/class. We shouldn't at least.
>> If no securi
On Wed, 28 Sep 2022 10:06:54 GMT, Sean Coffey wrote:
>> src/jdk.jfr/share/conf/jfr/default.jfc line 713:
>>
>>> 711:
>>> 712:
>>> 713: true
>>
>> The other security related events are not enabled by default. Is this one
>> enabled because it is only generated once? It seems it may
On Wed, 28 Sep 2022 07:06:30 GMT, Jaikiran Pai wrote:
> Hello Sean,
>
> > Debug output is also now added for these properties via
> > -Djava.security.debug=properties
>
> Looking at the existing code upstream, it appears that the value `properties`
> is already recognized for `java.security.d
> New JFR event to record state of initial security properties.
>
> Debug output is also now added for these properties via
> -Djava.security.debug=properties
Sean Coffey has updated the pull request incrementally with one additional
commit since the last revision:
Null check on Properties
On Tue, 27 Sep 2022 20:29:31 GMT, Sean Mullan wrote:
>> New JFR event to record state of initial security properties.
>>
>> Debug output is also now added for these properties via
>> -Djava.security.debug=properties
>
> src/jdk.jfr/share/classes/jdk/jfr/internal/instrument/JDKEvents.java line
On Tue, 20 Sep 2022 22:12:04 GMT, Xue-Lei Andrew Fan wrote:
> Hi,
>
> In the message digest implementation, for example SHA256, in JDK, two bitwise
> operations could be improved with equivalent arithmetic, and then the number
> bitwise operations could be reduced accordingly. Specifically
>
On Thu, 22 Sep 2022 15:57:56 GMT, Sean Coffey wrote:
> New JFR event to record state of initial security properties.
>
> Debug output is also now added for these properties via
> -Djava.security.debug=properties
Hello Sean,
> Debug output is also now added for these properties via
> -Djava.
17 matches
Mail list logo
