Re: RFR: 8294073: Performance improvement for message digest implementations

2022-09-21 Thread Xue-Lei Andrew Fan
On Wed, 21 Sep 2022 18:29:08 GMT, Aleksey Shipilev wrote: > Maybe older X86 and AArch64 are our targets, since it is not guaranteed to > have SHA hardware intrinsics? Yes, the platforms that do not support SHA intrinsics are the targets. If I read the OpenJDK CPU code correctly, RISC-V and AR

Re: RFR: 8294073: Performance improvement for message digest implementations

2022-09-21 Thread Aleksey Shipilev
On Wed, 21 Sep 2022 15:14:22 GMT, Xue-Lei Andrew Fan wrote: > But you let me convinced that this may not be worthy of the effort. Let's think about it and not discount it right away. 1% improvement on OpenJDK scale is still quite significant, if we can show the non-interpreter modes benefit fr

Re: RFR: 8254711: Add java.security.Provider.getService JFR Event [v3]

2022-09-21 Thread Sean Coffey
> Add a JFR Event for `java.security.Provider.getService(String type, String > algorithm)` calls. Sean Coffey has updated the pull request incrementally with one additional commit since the last revision: Correct Label annontation capitals - Changes: - all: https://git.openjdk

Re: RFR: 8294073: Performance improvement for message digest implementations

2022-09-21 Thread Xue-Lei Andrew Fan
On Wed, 21 Sep 2022 12:06:31 GMT, Aleksey Shipilev wrote: >> Hi, >> >> In the message digest implementation, for example SHA256, in JDK, two >> bitwise operations could be improved with equivalent arithmetic, and then >> the number bitwise operations could be reduced accordingly. Specifically

Re: RFR: 8294073: Performance improvement for message digest implementations

2022-09-21 Thread Aleksey Shipilev
On Tue, 20 Sep 2022 22:12:04 GMT, Xue-Lei Andrew Fan wrote: > Hi, > > In the message digest implementation, for example SHA256, in JDK, two bitwise > operations could be improved with equivalent arithmetic, and then the number > bitwise operations could be reduced accordingly. Specifically >

Re: RFR: 8215788: Clarify JarInputStream Manifest access [v11]

2022-09-21 Thread Lance Andersen
On Wed, 21 Sep 2022 09:23:31 GMT, Alan Bateman wrote: > > Assuming we are set with the other changes, did you want to add the > > following paragraph (or similar) at line 58 to make it clear that if the > > Manifest is not found, then the JarEntry attributes will not be available: > > This is

Re: RFR: 8215788: Clarify JarInputStream Manifest access [v11]

2022-09-21 Thread Alan Bateman
On Tue, 20 Sep 2022 18:08:21 GMT, Lance Andersen wrote: > Assuming we are set with the other changes, did you want to add the following > paragraph (or similar) at line 58 to make it clear that if the Manifest is > not found, then the JarEntry attributes will not be available: This is somethin