Re: RFR: 8215788: Clarify JarInputStream Manifest access [v4]

2022-09-17 Thread Lance Andersen
On Sat, 17 Sep 2022 08:05:37 GMT, Alan Bateman wrote: > It's a bit better but I think we can make it clearer and also link the JAR > Manifest section of the JAR file spec. Can you try this: > > ``` > * The {@link #getManifest() getManifest} method is used to read the > * JAR Manifest > * fr

Re: RFR: 8215788: Clarify JarInputStream Manifest access [v6]

2022-09-17 Thread Lance Andersen
> Please review this PR which updates the JarInputStream class description to > clarify when the Manifest is accessible via JarInputStream::getManifest and > JarInputStream::get[Jar]Entry. > > It is worth noting that with this update, we are finally documenting > behavior that dates back to w

Re: RFR: 8215788: Clarify JarInputStream Manifest access [v4]

2022-09-17 Thread Alan Bateman
On Fri, 16 Sep 2022 18:33:46 GMT, Lance Andersen wrote: >> Okay, in which case what would you think about just saying that the >> getNextEntry/getNextJarEntry method do not return the Manifest when it's at >> the start of the stream, and it's unspecified whether they return the >> Manifest whe