Re: RFR: 8215788: Clarify JarInputStream Manifest access [v4]

2022-09-16 Thread Lance Andersen
On Fri, 16 Sep 2022 18:01:40 GMT, Alan Bateman wrote: > Okay, in which case what would you think about just saying that the > getNextEntry/getNextJarEntry method do not return the Manifest when it's at > the start of the stream, and it's unspecified whether they return the > Manifest when it l

Re: RFR: 8215788: Clarify JarInputStream Manifest access [v4]

2022-09-16 Thread Alan Bateman
On Fri, 16 Sep 2022 16:15:44 GMT, Lance Andersen wrote: >> src/java.base/share/classes/java/util/jar/JarInputStream.java line 51: >> >>> 49: * If {@code META-INF/} is the first entry in the input stream it will >>> be >>> 50: * also not be returned by {@link #getNextEntry()} and >>> 51: * {@

Re: RFR: 8215788: Clarify JarInputStream Manifest access [v4]

2022-09-16 Thread Lance Andersen
On Fri, 16 Sep 2022 13:06:28 GMT, Alan Bateman wrote: >> Lance Andersen has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Address latest input regarding wording > > src/java.base/share/classes/java/util/jar/JarInputStream.java line 44: >

Re: RFR: 8215788: Clarify JarInputStream Manifest access [v5]

2022-09-16 Thread Lance Andersen
> Please review this PR which updates the JarInputStream class description to > clarify when the Manifest is accessible via JarInputStream::getManifest and > JarInputStream::get[Jar]Entry. > > It is worth noting that with this update, we are finally documenting > behavior that dates back to w

Re: RFR: JDK-8293808: mscapi destroyKeyContainer enhance KeyStoreException: Access is denied exception [v3]

2022-09-16 Thread Weijun Wang
On Fri, 16 Sep 2022 14:30:40 GMT, Matthias Baesken wrote: >> Currently we see on various Windows machines the following exception : >> https://bugs.openjdk.org/browse/JDK-8293097 >> >> java.security.KeyStoreException: Access is denied. >> >> This should probably be enhanced a bit so that the ex

Re: RFR: JDK-8293808: mscapi destroyKeyContainer enhance KeyStoreException: Access is denied exception [v2]

2022-09-16 Thread Matthias Baesken
On Fri, 16 Sep 2022 13:33:59 GMT, Weijun Wang wrote: >> Matthias Baesken has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Add errcode output to ThrowException > > src/jdk.crypto.mscapi/windows/native/libsunmscapi/security.cpp line 165: >

Re: RFR: JDK-8293808: mscapi destroyKeyContainer enhance KeyStoreException: Access is denied exception [v3]

2022-09-16 Thread Matthias Baesken
> Currently we see on various Windows machines the following exception : > https://bugs.openjdk.org/browse/JDK-8293097 > > java.security.KeyStoreException: Access is denied. > > This should probably be enhanced a bit so that the exception tell us more > about what went wrong exactly. Matthias B

Re: RFR: JDK-8293808: mscapi destroyKeyContainer enhance KeyStoreException: Access is denied exception [v2]

2022-09-16 Thread Weijun Wang
On Fri, 16 Sep 2022 07:43:00 GMT, Matthias Baesken wrote: >> Currently we see on various Windows machines the following exception : >> https://bugs.openjdk.org/browse/JDK-8293097 >> >> java.security.KeyStoreException: Access is denied. >> >> This should probably be enhanced a bit so that the ex

Re: RFR: 8215788: Clarify JarInputStream Manifest access [v4]

2022-09-16 Thread Alan Bateman
On Wed, 14 Sep 2022 16:43:43 GMT, Lance Andersen wrote: >> Please review this PR which updates the JarInputStream class description to >> clarify when the Manifest is accessible via JarInputStream::getManifest and >> JarInputStream::get[Jar]Entry. >> >> It is worth noting that with this updat

Re: RFR: JDK-8293808: mscapi destroyKeyContainer enhance KeyStoreException: Access is denied exception [v2]

2022-09-16 Thread Weijun Wang
On Fri, 16 Sep 2022 07:43:00 GMT, Matthias Baesken wrote: >> Currently we see on various Windows machines the following exception : >> https://bugs.openjdk.org/browse/JDK-8293097 >> >> java.security.KeyStoreException: Access is denied. >> >> This should probably be enhanced a bit so that the ex

Re: RFR: JDK-8293808: mscapi destroyKeyContainer enhance KeyStoreException: Access is denied exception [v2]

2022-09-16 Thread Matthias Baesken
On Fri, 16 Sep 2022 07:43:00 GMT, Matthias Baesken wrote: >> Currently we see on various Windows machines the following exception : >> https://bugs.openjdk.org/browse/JDK-8293097 >> >> java.security.KeyStoreException: Access is denied. >> >> This should probably be enhanced a bit so that the ex

Re: RFR: JDK-8293808: mscapi destroyKeyContainer enhance KeyStoreException: Access is denied exception [v2]

2022-09-16 Thread Weijun Wang
On Fri, 16 Sep 2022 07:43:00 GMT, Matthias Baesken wrote: >> Currently we see on various Windows machines the following exception : >> https://bugs.openjdk.org/browse/JDK-8293097 >> >> java.security.KeyStoreException: Access is denied. >> >> This should probably be enhanced a bit so that the ex

Re: RFR: JDK-8293808: mscapi destroyKeyContainer enhance KeyStoreException: Access is denied exception

2022-09-16 Thread Weijun Wang
On Thu, 15 Sep 2022 13:16:37 GMT, Matthias Baesken wrote: > > This is not a fix for the bug itself, therefore I suggest either create a > > new issue or create a subtask for this code change. > > Hi, this one is just for the better/more detailed exception . For the real > issue we still have J

Re: RFR: JDK-8293808: mscapi destroyKeyContainer enhance KeyStoreException: Access is denied exception

2022-09-16 Thread Weijun Wang
On Fri, 16 Sep 2022 07:26:27 GMT, Matthias Baesken wrote: > After looking into a number of logs it looks more and more like some crappy > (or awfully configured?) "security product" causes these "Access is denied" > problems on a number of our Windows test machines. Is it possible to find a Wi

Re: RFR: JDK-8293808: mscapi destroyKeyContainer enhance KeyStoreException: Access is denied exception [v2]

2022-09-16 Thread Matthias Baesken
> Currently we see on various Windows machines the following exception : > https://bugs.openjdk.org/browse/JDK-8293097 > > java.security.KeyStoreException: Access is denied. > > This should probably be enhanced a bit so that the exception tell us more > about what went wrong exactly. Matthias B

Re: RFR: JDK-8293808: mscapi destroyKeyContainer enhance KeyStoreException: Access is denied exception

2022-09-16 Thread Matthias Baesken
On Thu, 15 Sep 2022 13:16:37 GMT, Matthias Baesken wrote: >Still not 100% sure whats happening there, it might be related to some special >properties or missing privileges of the user >executing those tests. After looking into a number of logs it looks more and more like some crappy (or awfull