Re: RFR: 8293326: jdk/sun/security/tools/jarsigner/compatibility/SignTwice.java slow on Windows

2022-09-05 Thread Bradford Wetmore
On Mon, 5 Sep 2022 18:52:21 GMT, Weijun Wang wrote: >> test/jdk/sun/security/tools/jarsigner/compatibility/Compatibility.java line >> 1044: >> >>> 1042: } else { >>> 1043: cmd = new String[args.length + 4]; >>> 1044: cmd[3] = "-J-Djava.security.egd=fi

Re: RFR: 8293326: jdk/sun/security/tools/jarsigner/compatibility/SignTwice.java slow on Windows

2022-09-05 Thread Weijun Wang
On Mon, 5 Sep 2022 17:25:48 GMT, Bradford Wetmore wrote: >> This patch enables SignTwice test to complete faster on Windows machines. >> >> The test starts `keytool` and `jarsigner` a number of times, passing >> `-J-Djava.security.egd=file:/dev/./urandom` to the started process, >> presumably

Re: RFR: 8293326: jdk/sun/security/tools/jarsigner/compatibility/SignTwice.java slow on Windows

2022-09-05 Thread Bradford Wetmore
On Mon, 5 Sep 2022 09:29:49 GMT, Daniel Jeliński wrote: > This patch enables SignTwice test to complete faster on Windows machines. > > The test starts `keytool` and `jarsigner` a number of times, passing > `-J-Djava.security.egd=file:/dev/./urandom` to the started process, > presumably to avo

Re: RFR: 8293326: jdk/sun/security/tools/jarsigner/compatibility/SignTwice.java slow on Windows

2022-09-05 Thread Daniel Jeliński
On Mon, 5 Sep 2022 09:29:49 GMT, Daniel Jeliński wrote: > This patch enables SignTwice test to complete faster on Windows machines. > > The test starts `keytool` and `jarsigner` a number of times, passing > `-J-Djava.security.egd=file:/dev/./urandom` to the started process, > presumably to avo

Re: RFR: 8293326: jdk/sun/security/tools/jarsigner/compatibility/SignTwice.java slow on Windows

2022-09-05 Thread Bradford Wetmore
On Mon, 5 Sep 2022 14:37:34 GMT, Weijun Wang wrote: > @bradfordwetmore, is the `/dev/./urandom` trick not necessary anymore? Not necessary in current JDK, but not sure if this was backported to JDK 8u. - PR: https://git.openjdk.org/jdk/pull/10160

Re: RFR: 8293326: jdk/sun/security/tools/jarsigner/compatibility/SignTwice.java slow on Windows

2022-09-05 Thread Weijun Wang
On Mon, 5 Sep 2022 09:29:49 GMT, Daniel Jeliński wrote: > This patch enables SignTwice test to complete faster on Windows machines. > > The test starts `keytool` and `jarsigner` a number of times, passing > `-J-Djava.security.egd=file:/dev/./urandom` to the started process, > presumably to avo

Re: RFR: 8293326: jdk/sun/security/tools/jarsigner/compatibility/SignTwice.java slow on Windows

2022-09-05 Thread Weijun Wang
On Mon, 5 Sep 2022 09:29:49 GMT, Daniel Jeliński wrote: > This patch enables SignTwice test to complete faster on Windows machines. > > The test starts `keytool` and `jarsigner` a number of times, passing > `-J-Djava.security.egd=file:/dev/./urandom` to the started process, > presumably to avo

RFR: 8293326: jdk/sun/security/tools/jarsigner/compatibility/SignTwice.java slow on Windows

2022-09-05 Thread Daniel Jeliński
This patch enables SignTwice test to complete faster on Windows machines. The test starts `keytool` and `jarsigner` a number of times, passing `-J-Djava.security.egd=file:/dev/./urandom` to the started process, presumably to avoid blocking on VMs with insufficient entropy. This works fine on mac

Re: RFR: 8293088: Fix compilation with the new Visual Studio preprocessor

2022-09-05 Thread Daniel Jeliński
On Tue, 30 Aug 2022 12:08:09 GMT, Daniel Jeliński wrote: > Fix compilation with Zc:preprocessor enabled. > > The flag itself will be enabled in > [JDK-8247283](https://bugs.openjdk.org/browse/JDK-8247283); I enabled the > flag using instructions found in Magnus's comment on that issue. > > W

Integrated: 8293088: Fix compilation with the new Visual Studio preprocessor

2022-09-05 Thread Daniel Jeliński
On Tue, 30 Aug 2022 12:08:09 GMT, Daniel Jeliński wrote: > Fix compilation with Zc:preprocessor enabled. > > The flag itself will be enabled in > [JDK-8247283](https://bugs.openjdk.org/browse/JDK-8247283); I enabled the > flag using instructions found in Magnus's comment on that issue. > > W