On Fri, 19 Aug 2022 18:48:10 GMT, Eric Caspole wrote:
> Add a JMH for ProtectionDomain related to current work on JDK-8292375. Also,
> add the InMemoryJavaCompiler to the JMH jar, to generate the classes needed
> for this test and will be useful for future class loading JMH too.
test/micro/org
> Could you please review the changes?
> This patch is to address :
> https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug
Jayashree Huttanagoudar has updated the pull request incrementally with one
additional commit since the last revision:
Address review comment
-
On Tue, 23 Aug 2022 13:06:12 GMT, Weijun Wang wrote:
>> Jayashree Huttanagoudar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Address review comment for import statements
>
> test/jdk/javax/security/auth/login/LoginContext/OptionalJaas
> add @exception message to indicate an NPE might be thrown when the input
> parameter is null
Kevin Driver has updated the pull request incrementally with one additional
commit since the last revision:
review comments
-
Changes:
- all: https://git.openjdk.org/jdk/pull/9859/fi
On Wed, 24 Aug 2022 00:19:50 GMT, Kevin Driver wrote:
>> add @exception message to indicate an NPE might be thrown when the input
>> parameter is null
>
> Kevin Driver has updated the pull request incrementally with one additional
> commit since the last revision:
>
> remove unnecessary code
On Wed, 24 Aug 2022 00:19:50 GMT, Kevin Driver wrote:
>> add @exception message to indicate an NPE might be thrown when the input
>> parameter is null
>
> Kevin Driver has updated the pull request incrementally with one additional
> commit since the last revision:
>
> remove unnecessary code
On Tue, 23 Aug 2022 23:55:33 GMT, Valerie Peng wrote:
>> Kevin Driver has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - move test
>> - new test for MacSpi demo purposes
>
> test/jdk/com/sun/crypto/provider/Mac/Test6205692.java line 112:
> add @exception message to indicate an NPE might be thrown when the input
> parameter is null
Kevin Driver has updated the pull request incrementally with one additional
commit since the last revision:
remove unnecessary code
-
Changes:
- all: https://git.openjdk.org/jdk/pull
Invalid legacy services are screened and removed in Provider.getService(...)
call. This fix is to also screen and remove the invalid legacy services when
Provider.getServices() is called.
Leveraged existing test case to test this particular scenario by adding one
invalid legacy registration.
T
On Fri, 12 Aug 2022 23:05:11 GMT, Bradford Wetmore wrote:
>> Kevin Driver has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> adding test to demonstrate exception being thrown
>
> LGTM, but needs test cases.
@bradfordwetmore test added
---
> Fix for JDK-4958071 to add additional @throws stanza to javadocs for all init
> methods
Kevin Driver has updated the pull request incrementally with one additional
commit since the last revision:
adding test to demonstrate exception being thrown
-
Changes:
- all: https://git
On Tue, 23 Aug 2022 23:34:27 GMT, Kevin Driver wrote:
>> add @exception message to indicate an NPE might be thrown when the input
>> parameter is null
>
> Kevin Driver has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - move test
> - new te
> add @exception message to indicate an NPE might be thrown when the input
> parameter is null
Kevin Driver has updated the pull request incrementally with two additional
commits since the last revision:
- move test
- new test for MacSpi demo purposes
-
Changes:
- all: https:/
On Tue, 23 Aug 2022 20:03:19 GMT, Sean Coffey wrote:
>> So, do you want to make the log where the configuration happens? Logging in
>> one place cannot have the accuracy debug log where the problem happens, and
>> cannot easy the analysis of the debug. One just gets the configuration
>> info
> add @exception message to indicate an NPE might be thrown when the input
> parameter is null
Kevin Driver has updated the pull request incrementally with one additional
commit since the last revision:
code review comments -- replace all occurences of @exception with @throws
-
On Mon, 22 Aug 2022 12:52:54 GMT, Sean Mullan wrote:
>> Weibing Xiao has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> add or remove the blank line according to the comments
>
> src/java.base/share/classes/sun/security/ssl/ServerHello.java
On Thu, 18 Aug 2022 15:36:43 GMT, Xue-Lei Andrew Fan wrote:
>> Intend to log all of the collected information in one place. It is easy for
>> the developer to see the configuration of the server socket. Previously when
>> the handshake is failing, no information is available for the server sock
On Tue, 23 Aug 2022 10:25:19 GMT, Josef Eisl wrote:
>> Hmm, could be. Let me check into it and I will have to file a separate bug
>> to address this since the changes have already been integrated. Thanks for
>> the comments.
>
> Thanks for looking into this! Please let me if you open a new bug
On Tue, 23 Aug 2022 15:04:44 GMT, Weibing Xiao wrote:
>> Log the debugging info for server cipher suites when setting javax.net.debug
>> == ssl, handshake.
>
> Weibing Xiao has updated the pull request incrementally with one additional
> commit since the last revision:
>
> update the code ac
On Mon, 22 Aug 2022 21:45:39 GMT, Mark Powers wrote:
> https://bugs.openjdk.org/browse/JDK-8291509
Mach5 tier1 and tier2 tests all pass on all platforms.
-
PR: https://git.openjdk.org/jdk/pull/9972
> Log the debugging info for server cipher suites when setting javax.net.debug
> == ssl, handshake.
Weibing Xiao has updated the pull request incrementally with one additional
commit since the last revision:
update the code according to review comments
-
Changes:
- all: https:
On Tue, 23 Aug 2022 06:39:44 GMT, Jayashree Huttanagoudar
wrote:
>> Could you please review the changes?
>> This patch is to address :
>> https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug
>
> Jayashree Huttanagoudar has updated the pull request incrementally with one
>
On Fri, 19 Aug 2022 23:32:17 GMT, Valerie Peng wrote:
>> src/java.base/share/classes/java/security/Provider.java line 1276:
>>
>>> 1274: }
>>> 1275: if (serviceSet == null) {
>>> 1276: ensureLegacyParsed();
>>
>> Hi @valeriepeng! I believe that with this change, `get
23 matches
Mail list logo
